tangled.org / core
Monorepo for Tangled — https://tangled.org
fork atom

appview: add reaction for issues/PRs (close #65) #265

merged
opened by boltless.me targeting master from boltless.me/core: push-uoymosxlmxvl

Add sh.tangled.feed.reaction lexicon and UI to react to issues/PRs close #65 close #113

Signed-off-by: Seongmin Lee boltlessengineer@proton.me

0
by boltless.me 0 comments
expand 1 commit
f5eb4463
appview: add reaction for issues/PRs (close #65)
sign up or login to add to the discussion
1
by boltless.me 1 comment
expand 1 commit
9f9b99b3
appview: add reaction for issues/PRs (close #65)
boltless.me

I made reactions table without specific foreign key to handle both issues & prs (also potentially comments in future)

I'm not sure if this is a correct way to do this.

sign up or login to add to the discussion
2
by boltless.me 2 comments
expand 1 commit
b2377ed8
appview: add reaction for issues/PRs (close #65)
anirudh.fi

Thanks, this looks pretty awesome overall! One nit: perhaps the GetReactionCountMap can be DRY'd up? Why not just loop through it?

boltless.me

@icyphox.sh oh you're right. I have no idea why I end up like that.

sign up or login to add to the discussion
3
by boltless.me 0 comments
expand 1 commit
3503a95a
appview: add reaction for issues/PRs (close #65)
sign up or login to add to the discussion
4
by boltless.me 3 comments
expand 1 commit
ab81753c
appview: add reaction for issues/PRs (close #65)
anirudh.fi

Tried this out locally again, and another minor nit: can each reaction in the pop-up have some kind of hover: state? Perhaps just a simple p-1 mx-1 hover:bg-gray-100 dark:hover:bg-gray-700 rounded would look great!

anirudh.fi

Oh also, not sure if it's possible at all: can the pop-up be made to disappear when clicking outside anywhere else? Currently I have to click on the reaction box to toggle it.

boltless.me

@icyphox.sh Damn I forgot to add light mode hover style for those popup buttons. Thank you for catching that. I'll fix it. I think simple hover backgrounds would be enough for those UI elements (no padding/margin/rounded corners).

I'll work on auto-disappear feature. That would make this even better.

sign up or login to add to the discussion
5
by boltless.me 0 comments
expand 1 commit
d00beee7
appview: add reaction for issues/PRs (close #65)
sign up or login to add to the discussion
6
by boltless.me 2 comments
expand 1 commit
75098379
appview: add reaction for issues/PRs (close #65)
boltless.me

PR is ready for review again.

tangled.org

this is great! thanks for working on this!

pull request successfully merged
sign up or login to add to the discussion
Labels

None yet.

assignee

None yet.

Participants 3
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3ltg3qobnru22