Monorepo for Tangled โ€” https://tangled.org

appview: Update New PR Page #490

The compare forks option dropdown now shows repos in which you are a collaborator on instead of just repos you own.

0
by freshlybakedca.ke 2 comments
expand 2 commits
appview: db: Update GetForksByDid
appview: pages: Update PRCompare fork titles

copying over my comment from discord just for my own reference:

we will need some changes to the backend also here (in pulls/pulls.go):

func (s *Pulls) handleForkBasedPull(w http.ResponseWriter, r *http.Request, f *reporesolver.ResolvedRepo, user *oauth.User, forkRepo string, title, body, targetBranch, sourceBranch string, isStacked bool) {
    fork, err := db.GetForkByDid(s.db, user.Did, forkRepo)

the form that you have edited has a select where the options value is just the repo name, we then use the logged in user's DID to figure out the fork to use, so we construct userDId/repoName (whereas this DID should also come from the form)

Updated the underlying logic for both that function and

func (s *Pulls) CompareForksBranchesFragment(w http.ResponseWriter, r *http.Request)

which was the other one we talked about on discord

sign up or login to add to the discussion
expand 2 commits
appview: db: Update GetForksByDid
appview: pages: Update PRCompare fork page
sign up or login to add to the discussion
expand 2 commits
appview: db: update GetForksByDid function
appview: pages: update pr compare fork page
sign up or login to add to the discussion
expand 2 commits
appview: db: update GetForksByDid function
appview: pages: update pr compare fork page
sign up or login to add to the discussion
expand 2 commits
appview: db: update GetForksByDid function
appview: pages: update pr compare fork page
sign up or login to add to the discussion
expand 2 commits
appview: db: update GetForksByDid function
appview: pages: update pr compare fork page
sign up or login to add to the discussion
expand 2 commits
appview: db: update GetForksByDid function
appview: pages: update pr compare fork page
sign up or login to add to the discussion
expand 2 commits
appview: db: update GetForksByDid function
appview: pages: update pr compare fork page
sign up or login to add to the discussion
expand 2 commits
appview: db: update GetForksByDid function
appview: pages: update pr compare fork page
pull request successfully merged
sign up or login to add to the discussion
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:k2zmz2l3hvfr44tmlhewol2j/sh.tangled.repo.pull/3lwdxjzycgm22