close #269
nix/modules/knot: make ssh ports configurable #716
expand 1 commit
hide 1 commit
Close: #269
Signed-off-by: Seongmin Lee <git@boltless.me>
expand 1 commit
hide 1 commit
firewall should be handled by users. this change will allow setting
non-22 ssh ports
Close: #269
Signed-off-by: Seongmin Lee <git@boltless.me>
expand 1 commit
hide 1 commit
firewall should be handled by users. this change will allow setting
non-22 ssh ports
Close: #269
Signed-off-by: Seongmin Lee <git@boltless.me>
Well.. it is, but as ssh ports are also configurable and the firewall should follow the correct configured ssh ports, I think removing the firewall settings will make things simpler. Users can configure there networks by their own.
this is pretty common practice in nixpkgs.
ok I'm closing this. the description explicitly states it opens hard-coded port 22, so I think it's fine to leave it not following config.services.openssh.posts.
if
openFirewallis not set totrue, this is already configurable is it not?