boltless.me
targeting
master
from
sl/uzmtowmlwkvz
renamed starred_by_did column to did
remove foreign key constraints from repo_at column to support
targetting non-ingested repository or sh.tangled.string. the column
isn't renamed yet because I'm afraid to break somewhere with that
rename. We really need some test code here.
Signed-off-by: Seongmin Lee git@boltless.me
renamed `starred_by_did` column to `did`
remove foreign key constraints from `repo_at` column to support
targetting non-ingested repository or `sh.tangled.string`. the column
isn't renamed yet because I'm afraid to break somewhere with that
rename. We really need some test code here.
Signed-off-by: Seongmin Lee <git@boltless.me>
Actually that was my first intention, renaming repo_at to subject_at. I just didn't do that here because I was afraid to find all .repo_at usages in raw sql queries. And I thought that will also harder to review without tests.
Do you think it is worth renaming? If so, I can do that.
IIUC we'd only need to find repo_at for all queries that mention the "stars" table. searching for from stars might cover that. I'd recommend that we do fix this!
- rename `starred_by_did` column to `did`
- rename `repo_at` column to `subject_at` and removed foreign key
constraints.
- rename `RepoAt` field to `SubjectAt`
- remove `Repo` field and split `models.Star` to `RepoStar` and
`StringStar` as now there can be two kinds of reverse mappings.
Signed-off-by: Seongmin Lee <git@boltless.me>
- rename `starred_by_did` column to `did`
- rename `repo_at` column to `subject_at` and removed foreign key
constraints.
- rename `RepoAt` field to `SubjectAt`
- remove `Repo` field and split `models.Star` to `RepoStar` and
`StringStar` as now there can be two kinds of reverse mappings.
Signed-off-by: Seongmin Lee <git@boltless.me>
- rename `starred_by_did` column to `did`
- rename `repo_at` column to `subject_at` and removed foreign key
constraints.
- rename `RepoAt` field to `SubjectAt`
- remove `Repo` field and split `models.Star` to `RepoStar` and
`StringStar` as now there can be two kinds of reverse mappings.
Signed-off-by: Seongmin Lee <git@boltless.me>
- rename `starred_by_did` column to `did`
- rename `repo_at` column to `subject_at` and removed foreign key
constraints.
- rename `RepoAt` field to `SubjectAt`
- remove `Repo` field and split `models.Star` to `RepoStar` and
`StringStar` as now there can be two kinds of reverse mappings.
Signed-off-by: Seongmin Lee <git@boltless.me>
tangled.org
oppi.li
bit confusing that the
repo_atcol of the stars table can now refer to anything. can we rename that column too? to something more generic liketarget?