interactive intro to open social

code duplication: fetchAppAvatar implemented twice #4

open
opened by zzstoatzz.io

problem#

the fetchAppAvatar() function is completely duplicated in two files:

  • static/app.js:9-38 (for user's app circles)
  • static/login.js:78-99 (for atmosphere orbs)

identical logic maintained in two places, violating DRY principle.

impact#

  • harder to maintain
  • bug fixes need to be applied twice
  • inconsistencies can creep in
  • increased bundle size

affected files#

  • static/app.js
  • static/login.js
sign up or login to add to the discussion
Labels

None yet.

assignee

None yet.

Participants 1
AT URI
at://did:plc:xbtmt2zjwlrfegqvch7fboei/sh.tangled.repo.issue/1760151723660321