comparing b1fe542a9a183b9949b4471953b48d0e5f82c542 and feat/vote-xrpc-endpoints on bretton.dev/coves

+11

static/.well-known/apple-app-site-association

···

       1
       1
       +
       {

     

       2
       2
       +
         "applinks": {

     

       3
       3
       +
           "apps": [],

     

       4
       4
       +
           "details": [

     

       5
       5
       +
             {

     

       6
       6
       +
               "appID": "TEAM_ID.social.coves",

     

       7
       7
       +
               "paths": ["/app/oauth/callback"]

     

       8
       8
       +
             }

     

       9
       9
       +
           ]

     

       10
       10
       +
         }

     

       11
       11
       +
       }

+10

static/.well-known/assetlinks.json

···

       1
       1
       +
       [{

     

       2
       2
       +
         "relation": ["delegate_permission/common.handle_all_urls"],

     

       3
       3
       +
         "target": {

     

       4
       4
       +
           "namespace": "android_app",

     

       5
       5
       +
           "package_name": "social.coves",

     

       6
       6
       +
           "sha256_cert_fingerprints": [

     

       7
       7
       +
             "0B:D8:8C:99:66:25:E5:CD:06:54:80:88:01:6F:B7:38:B9:F4:5B:41:71:F7:95:C8:68:94:87:AD:EA:9F:D9:ED"

     

       8
       8
       +
           ]

     

       9
       9
       +
         }

     

       10
       10
       +
       }]

+16 -9

internal/atproto/oauth/handlers_test.go

···

       171
       171
        
       }

     

       172
       172
        
       

     

       173
       173
        
       // TestIsMobileRedirectURI tests mobile redirect URI validation with EXACT URI matching

     

       174
       174
       -
       // Only Universal Links (HTTPS) are allowed - custom schemes are blocked for security

     

       174
       174
       +
       // Per atproto spec, custom schemes must match client_id hostname in reverse-domain order

     

       175
       175
        
       func TestIsMobileRedirectURI(t *testing.T) {

     

       176
       176
        
       	tests := []struct {

     

       177
       177
        
       		uri      string

     

       178
       178
        
       		expected bool

     

       179
       179
        
       	}{

     

       180
       180
       -
       		{"https://coves.social/app/oauth/callback", true}, // Universal Link - allowed

     

       181
       181
       -
       		{"coves-app://oauth/callback", false},             // Custom scheme - blocked (insecure)

     

       182
       182
       -
       		{"coves://oauth/callback", false},                 // Custom scheme - blocked (insecure)

     

       183
       183
       -
       		{"coves-app://callback", false},                   // Custom scheme - blocked

     

       184
       184
       -
       		{"coves://oauth", false},                          // Custom scheme - blocked

     

       185
       185
       -
       		{"myapp://oauth", false},                          // Not in allowlist

     

       186
       186
       -
       		{"https://example.com", false},                    // Wrong domain

     

       187
       187
       -
       		{"http://localhost", false},                       // HTTP not allowed

     

       180
       180
       +
       		// Custom scheme per atproto spec (reverse domain of coves.social)

     

       181
       181
       +
       		{"social.coves:/callback", true},

     

       182
       182
       +
       		{"social.coves://callback", true},

     

       183
       183
       +
       		{"social.coves:/oauth/callback", true},

     

       184
       184
       +
       		{"social.coves://oauth/callback", true},

     

       185
       185
       +
       		// Universal Link - allowed (strongest security)

     

       186
       186
       +
       		{"https://coves.social/app/oauth/callback", true},

     

       187
       187
       +
       		// Wrong custom schemes - not reverse-domain of coves.social

     

       188
       188
       +
       		{"coves-app://oauth/callback", false},

     

       189
       189
       +
       		{"coves://oauth/callback", false},

     

       190
       190
       +
       		{"coves.social://callback", false}, // Not reversed

     

       191
       191
       +
       		{"myapp://oauth", false},

     

       192
       192
       +
       		// Wrong domain/scheme

     

       193
       193
       +
       		{"https://example.com", false},

     

       194
       194
       +
       		{"http://localhost", false},

     

       188
       195
        
       		{"", false},

     

       189
       196
        
       		{"not-a-uri", false},

     

       190
       197
        
       	}

+143 -2

internal/atproto/oauth/handlers.go

···

       4
       4
        
       	"context"

     

       5
       5
        
       	"encoding/json"

     

       6
       6
        
       	"fmt"

     

       7
       7
       +
       	"html/template"

     

       7
       8
        
       	"log/slog"

     

       8
       9
        
       	"net/http"

     

       9
       10
        
       	"net/url"

     
···

       12
       13
        
       	"github.com/bluesky-social/indigo/atproto/syntax"

     

       13
       14
        
       )

     

       14
       15
        
       

     

       16
       16
       +
       // mobileCallbackTemplate is the intermediate page shown after OAuth completes

     

       17
       17
       +
       // before redirecting to the mobile app via custom scheme.

     

       18
       18
       +
       // This prevents the browser from showing a stale PDS page after the redirect.

     

       19
       19
       +
       var mobileCallbackTemplate = template.Must(template.New("mobile_callback").Parse(`<!DOCTYPE html>

     

       20
       20
       +
       <html lang="en">

     

       21
       21
       +
       <head>

     

       22
       22
       +
         <meta charset="utf-8">

     

       23
       23
       +
         <meta name="viewport" content="width=device-width, initial-scale=1">

     

       24
       24
       +
         <title>Login Complete - Coves</title>

     

       25
       25
       +
         <meta http-equiv="refresh" content="1;url={{.DeepLink}}">

     

       26
       26
       +
         <style>

     

       27
       27
       +
           * { box-sizing: border-box; margin: 0; padding: 0; }

     

       28
       28
       +
           body {

     

       29
       29
       +
             font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, sans-serif;

     

       30
       30
       +
             background: #0B0F14;

     

       31
       31
       +
             color: #e4e6e7;

     

       32
       32
       +
             min-height: 100vh;

     

       33
       33
       +
             display: flex;

     

       34
       34
       +
             justify-content: center;

     

       35
       35
       +
             align-items: center;

     

       36
       36
       +
             padding: 24px;

     

       37
       37
       +
           }

     

       38
       38
       +
           .card {

     

       39
       39
       +
             text-align: center;

     

       40
       40
       +
             max-width: 320px;

     

       41
       41
       +
           }

     

       42
       42
       +
           .logo {

     

       43
       43
       +
             width: 80px;

     

       44
       44
       +
             height: 80px;

     

       45
       45
       +
             margin: 0 auto 16px;

     

       46
       46
       +
           }

     

       47
       47
       +
           .checkmark {

     

       48
       48
       +
             width: 64px;

     

       49
       49
       +
             height: 64px;

     

       50
       50
       +
             margin: 0 auto 24px;

     

       51
       51
       +
             background: #FF6B35;

     

       52
       52
       +
             border-radius: 50%;

     

       53
       53
       +
             display: flex;

     

       54
       54
       +
             align-items: center;

     

       55
       55
       +
             justify-content: center;

     

       56
       56
       +
             animation: scale-in 0.3s ease-out;

     

       57
       57
       +
           }

     

       58
       58
       +
           .checkmark svg {

     

       59
       59
       +
             width: 32px;

     

       60
       60
       +
             height: 32px;

     

       61
       61
       +
             stroke: white;

     

       62
       62
       +
             stroke-width: 3;

     

       63
       63
       +
             fill: none;

     

       64
       64
       +
           }

     

       65
       65
       +
           @keyframes scale-in {

     

       66
       66
       +
             0% { transform: scale(0); }

     

       67
       67
       +
             50% { transform: scale(1.1); }

     

       68
       68
       +
             100% { transform: scale(1); }

     

       69
       69
       +
           }

     

       70
       70
       +
           h1 {

     

       71
       71
       +
             font-size: 24px;

     

       72
       72
       +
             font-weight: 600;

     

       73
       73
       +
             margin-bottom: 8px;

     

       74
       74
       +
             color: #e4e6e7;

     

       75
       75
       +
           }

     

       76
       76
       +
           .subtitle {

     

       77
       77
       +
             font-size: 16px;

     

       78
       78
       +
             color: #B6C2D2;

     

       79
       79
       +
             margin-bottom: 24px;

     

       80
       80
       +
           }

     

       81
       81
       +
           .handle {

     

       82
       82
       +
             font-size: 14px;

     

       83
       83
       +
             color: #7CB9E8;

     

       84
       84
       +
             background: #1A1F26;

     

       85
       85
       +
             padding: 8px 16px;

     

       86
       86
       +
             border-radius: 8px;

     

       87
       87
       +
             margin-bottom: 24px;

     

       88
       88
       +
             display: inline-block;

     

       89
       89
       +
           }

     

       90
       90
       +
           .hint {

     

       91
       91
       +
             font-size: 13px;

     

       92
       92
       +
             color: #6B7280;

     

       93
       93
       +
             line-height: 1.5;

     

       94
       94
       +
           }

     

       95
       95
       +
           .spinner {

     

       96
       96
       +
             width: 20px;

     

       97
       97
       +
             height: 20px;

     

       98
       98
       +
             border: 2px solid #2A2F36;

     

       99
       99
       +
             border-top-color: #FF6B35;

     

       100
       100
       +
             border-radius: 50%;

     

       101
       101
       +
             animation: spin 1s linear infinite;

     

       102
       102
       +
             display: inline-block;

     

       103
       103
       +
             vertical-align: middle;

     

       104
       104
       +
             margin-right: 8px;

     

       105
       105
       +
           }

     

       106
       106
       +
           @keyframes spin {

     

       107
       107
       +
             to { transform: rotate(360deg); }

     

       108
       108
       +
           }

     

       109
       109
       +
         </style>

     

       110
       110
       +
       </head>

     

       111
       111
       +
       <body>

     

       112
       112
       +
         <div class="card">

     

       113
       113
       +
           <div class="checkmark">

     

       114
       114
       +
             <svg viewBox="0 0 24 24">

     

       115
       115
       +
               <polyline points="20 6 9 17 4 12"></polyline>

     

       116
       116
       +
             </svg>

     

       117
       117
       +
           </div>

     

       118
       118
       +
           <h1>Login Complete</h1>

     

       119
       119
       +
           <p class="subtitle">

     

       120
       120
       +
             <span class="spinner"></span>

     

       121
       121
       +
             Returning to Coves...

     

       122
       122
       +
           </p>

     

       123
       123
       +
           {{if .Handle}}

     

       124
       124
       +
           <div class="handle">@{{.Handle}}</div>

     

       125
       125
       +
           {{end}}

     

       126
       126
       +
           <p class="hint">If the app doesn't open automatically,<br>you can close this window.</p>

     

       127
       127
       +
         </div>

     

       128
       128
       +
         <script>

     

       129
       129
       +
           // Redirect to app immediately

     

       130
       130
       +
           window.location.href = {{.DeepLink}};

     

       131
       131
       +
           // Try to close window after a delay

     

       132
       132
       +
           setTimeout(function() {

     

       133
       133
       +
             window.close();

     

       134
       134
       +
           }, 1500);

     

       135
       135
       +
         </script>

     

       136
       136
       +
       </body>

     

       137
       137
       +
       </html>

     

       138
       138
       +
       `))

     

       139
       139
       +
       

     

       15
       140
        
       // MobileOAuthStore interface for mobile-specific OAuth operations

     

       16
       141
        
       // This extends the base OAuth store with mobile CSRF tracking

     

       17
       142
        
       type MobileOAuthStore interface {

     
···

       483
       608
        
       	// Log mobile redirect (sanitized - no token or session ID to avoid leaking credentials)

     

       484
       609
        
       	slog.Info("redirecting to mobile app", "did", sessData.AccountDID, "handle", handle)

     

       485
       610
        
       

     

       486
       486
       -
       	// Redirect to mobile app deep link

     

       487
       487
       -
       	http.Redirect(w, r, deepLink, http.StatusFound)

     

       611
       611
       +
       	// Serve intermediate page that redirects to the app

     

       612
       612
       +
       	// This prevents the browser from showing a stale PDS page after the custom scheme redirect

     

       613
       613
       +
       	w.Header().Set("Content-Type", "text/html; charset=utf-8")

     

       614
       614
       +
       	w.Header().Set("Cache-Control", "no-store, no-cache, must-revalidate")

     

       615
       615
       +
       

     

       616
       616
       +
       	data := struct {

     

       617
       617
       +
       		DeepLink string

     

       618
       618
       +
       		Handle   string

     

       619
       619
       +
       	}{

     

       620
       620
       +
       		DeepLink: deepLink,

     

       621
       621
       +
       		Handle:   handle,

     

       622
       622
       +
       	}

     

       623
       623
       +
       

     

       624
       624
       +
       	if err := mobileCallbackTemplate.Execute(w, data); err != nil {

     

       625
       625
       +
       		slog.Error("failed to render mobile callback template", "error", err)

     

       626
       626
       +
       		// Fallback to direct redirect if template fails

     

       627
       627
       +
       		http.Redirect(w, r, deepLink, http.StatusFound)

     

       628
       628
       +
       	}

     

       488
       629
        
       }

     

       489
       630
        
       

     

       490
       631
        
       // HandleLogout revokes the session and clears cookies

+115

internal/api/handlers/vote/create_vote.go

···

       1
       1
       +
       package vote

     

       2
       2
       +
       

     

       3
       3
       +
       import (

     

       4
       4
       +
       	"Coves/internal/api/middleware"

     

       5
       5
       +
       	"Coves/internal/core/votes"

     

       6
       6
       +
       	"encoding/json"

     

       7
       7
       +
       	"log"

     

       8
       8
       +
       	"net/http"

     

       9
       9
       +
       )

     

       10
       10
       +
       

     

       11
       11
       +
       // CreateVoteHandler handles vote creation

     

       12
       12
       +
       type CreateVoteHandler struct {

     

       13
       13
       +
       	service votes.Service

     

       14
       14
       +
       }

     

       15
       15
       +
       

     

       16
       16
       +
       // NewCreateVoteHandler creates a new create vote handler

     

       17
       17
       +
       func NewCreateVoteHandler(service votes.Service) *CreateVoteHandler {

     

       18
       18
       +
       	return &CreateVoteHandler{

     

       19
       19
       +
       		service: service,

     

       20
       20
       +
       	}

     

       21
       21
       +
       }

     

       22
       22
       +
       

     

       23
       23
       +
       // CreateVoteInput represents the request body for creating a vote

     

       24
       24
       +
       type CreateVoteInput struct {

     

       25
       25
       +
       	Subject struct {

     

       26
       26
       +
       		URI string `json:"uri"`

     

       27
       27
       +
       		CID string `json:"cid"`

     

       28
       28
       +
       	} `json:"subject"`

     

       29
       29
       +
       	Direction string `json:"direction"`

     

       30
       30
       +
       }

     

       31
       31
       +
       

     

       32
       32
       +
       // CreateVoteOutput represents the response body for creating a vote

     

       33
       33
       +
       type CreateVoteOutput struct {

     

       34
       34
       +
       	URI string `json:"uri"`

     

       35
       35
       +
       	CID string `json:"cid"`

     

       36
       36
       +
       }

     

       37
       37
       +
       

     

       38
       38
       +
       // HandleCreateVote creates a vote on a post or comment

     

       39
       39
       +
       // POST /xrpc/social.coves.vote.create

     

       40
       40
       +
       //

     

       41
       41
       +
       // Request body: { "subject": { "uri": "at://...", "cid": "..." }, "direction": "up" }

     

       42
       42
       +
       // Response: { "uri": "at://...", "cid": "..." }

     

       43
       43
       +
       //

     

       44
       44
       +
       // Behavior:

     

       45
       45
       +
       // - If no vote exists: creates new vote with given direction

     

       46
       46
       +
       // - If vote exists with same direction: deletes vote (toggle off)

     

       47
       47
       +
       // - If vote exists with different direction: updates to new direction

     

       48
       48
       +
       func (h *CreateVoteHandler) HandleCreateVote(w http.ResponseWriter, r *http.Request) {

     

       49
       49
       +
       	if r.Method != http.MethodPost {

     

       50
       50
       +
       		http.Error(w, "Method not allowed", http.StatusMethodNotAllowed)

     

       51
       51
       +
       		return

     

       52
       52
       +
       	}

     

       53
       53
       +
       

     

       54
       54
       +
       	// Parse request body

     

       55
       55
       +
       	var input CreateVoteInput

     

       56
       56
       +
       	if err := json.NewDecoder(r.Body).Decode(&input); err != nil {

     

       57
       57
       +
       		writeError(w, http.StatusBadRequest, "InvalidRequest", "Invalid request body")

     

       58
       58
       +
       		return

     

       59
       59
       +
       	}

     

       60
       60
       +
       

     

       61
       61
       +
       	// Validate required fields

     

       62
       62
       +
       	if input.Subject.URI == "" {

     

       63
       63
       +
       		writeError(w, http.StatusBadRequest, "InvalidRequest", "subject.uri is required")

     

       64
       64
       +
       		return

     

       65
       65
       +
       	}

     

       66
       66
       +
       	if input.Subject.CID == "" {

     

       67
       67
       +
       		writeError(w, http.StatusBadRequest, "InvalidRequest", "subject.cid is required")

     

       68
       68
       +
       		return

     

       69
       69
       +
       	}

     

       70
       70
       +
       	if input.Direction == "" {

     

       71
       71
       +
       		writeError(w, http.StatusBadRequest, "InvalidRequest", "direction is required")

     

       72
       72
       +
       		return

     

       73
       73
       +
       	}

     

       74
       74
       +
       

     

       75
       75
       +
       	// Validate direction

     

       76
       76
       +
       	if input.Direction != "up" && input.Direction != "down" {

     

       77
       77
       +
       		writeError(w, http.StatusBadRequest, "InvalidRequest", "direction must be 'up' or 'down'")

     

       78
       78
       +
       		return

     

       79
       79
       +
       	}

     

       80
       80
       +
       

     

       81
       81
       +
       	// Get OAuth session from context (injected by auth middleware)

     

       82
       82
       +
       	session := middleware.GetOAuthSession(r)

     

       83
       83
       +
       	if session == nil {

     

       84
       84
       +
       		writeError(w, http.StatusUnauthorized, "AuthRequired", "Authentication required")

     

       85
       85
       +
       		return

     

       86
       86
       +
       	}

     

       87
       87
       +
       

     

       88
       88
       +
       	// Create vote request

     

       89
       89
       +
       	req := votes.CreateVoteRequest{

     

       90
       90
       +
       		Subject: votes.StrongRef{

     

       91
       91
       +
       			URI: input.Subject.URI,

     

       92
       92
       +
       			CID: input.Subject.CID,

     

       93
       93
       +
       		},

     

       94
       94
       +
       		Direction: input.Direction,

     

       95
       95
       +
       	}

     

       96
       96
       +
       

     

       97
       97
       +
       	// Call service to create vote

     

       98
       98
       +
       	response, err := h.service.CreateVote(r.Context(), session, req)

     

       99
       99
       +
       	if err != nil {

     

       100
       100
       +
       		handleServiceError(w, err)

     

       101
       101
       +
       		return

     

       102
       102
       +
       	}

     

       103
       103
       +
       

     

       104
       104
       +
       	// Return success response

     

       105
       105
       +
       	output := CreateVoteOutput{

     

       106
       106
       +
       		URI: response.URI,

     

       107
       107
       +
       		CID: response.CID,

     

       108
       108
       +
       	}

     

       109
       109
       +
       

     

       110
       110
       +
       	w.Header().Set("Content-Type", "application/json")

     

       111
       111
       +
       	w.WriteHeader(http.StatusOK)

     

       112
       112
       +
       	if err := json.NewEncoder(w).Encode(output); err != nil {

     

       113
       113
       +
       		log.Printf("Failed to encode response: %v", err)

     

       114
       114
       +
       	}

     

       115
       115
       +
       }

+93

internal/api/handlers/vote/delete_vote.go

···

       1
       1
       +
       package vote

     

       2
       2
       +
       

     

       3
       3
       +
       import (

     

       4
       4
       +
       	"Coves/internal/api/middleware"

     

       5
       5
       +
       	"Coves/internal/core/votes"

     

       6
       6
       +
       	"encoding/json"

     

       7
       7
       +
       	"log"

     

       8
       8
       +
       	"net/http"

     

       9
       9
       +
       )

     

       10
       10
       +
       

     

       11
       11
       +
       // DeleteVoteHandler handles vote deletion

     

       12
       12
       +
       type DeleteVoteHandler struct {

     

       13
       13
       +
       	service votes.Service

     

       14
       14
       +
       }

     

       15
       15
       +
       

     

       16
       16
       +
       // NewDeleteVoteHandler creates a new delete vote handler

     

       17
       17
       +
       func NewDeleteVoteHandler(service votes.Service) *DeleteVoteHandler {

     

       18
       18
       +
       	return &DeleteVoteHandler{

     

       19
       19
       +
       		service: service,

     

       20
       20
       +
       	}

     

       21
       21
       +
       }

     

       22
       22
       +
       

     

       23
       23
       +
       // DeleteVoteInput represents the request body for deleting a vote

     

       24
       24
       +
       type DeleteVoteInput struct {

     

       25
       25
       +
       	Subject struct {

     

       26
       26
       +
       		URI string `json:"uri"`

     

       27
       27
       +
       		CID string `json:"cid"`

     

       28
       28
       +
       	} `json:"subject"`

     

       29
       29
       +
       }

     

       30
       30
       +
       

     

       31
       31
       +
       // DeleteVoteOutput represents the response body for deleting a vote

     

       32
       32
       +
       // Per lexicon: output is an empty object

     

       33
       33
       +
       type DeleteVoteOutput struct{}

     

       34
       34
       +
       

     

       35
       35
       +
       // HandleDeleteVote removes a vote from a post or comment

     

       36
       36
       +
       // POST /xrpc/social.coves.vote.delete

     

       37
       37
       +
       //

     

       38
       38
       +
       // Request body: { "subject": { "uri": "at://...", "cid": "..." } }

     

       39
       39
       +
       // Response: { "success": true }

     

       40
       40
       +
       func (h *DeleteVoteHandler) HandleDeleteVote(w http.ResponseWriter, r *http.Request) {

     

       41
       41
       +
       	if r.Method != http.MethodPost {

     

       42
       42
       +
       		http.Error(w, "Method not allowed", http.StatusMethodNotAllowed)

     

       43
       43
       +
       		return

     

       44
       44
       +
       	}

     

       45
       45
       +
       

     

       46
       46
       +
       	// Parse request body

     

       47
       47
       +
       	var input DeleteVoteInput

     

       48
       48
       +
       	if err := json.NewDecoder(r.Body).Decode(&input); err != nil {

     

       49
       49
       +
       		writeError(w, http.StatusBadRequest, "InvalidRequest", "Invalid request body")

     

       50
       50
       +
       		return

     

       51
       51
       +
       	}

     

       52
       52
       +
       

     

       53
       53
       +
       	// Validate required fields

     

       54
       54
       +
       	if input.Subject.URI == "" {

     

       55
       55
       +
       		writeError(w, http.StatusBadRequest, "InvalidRequest", "subject.uri is required")

     

       56
       56
       +
       		return

     

       57
       57
       +
       	}

     

       58
       58
       +
       	if input.Subject.CID == "" {

     

       59
       59
       +
       		writeError(w, http.StatusBadRequest, "InvalidRequest", "subject.cid is required")

     

       60
       60
       +
       		return

     

       61
       61
       +
       	}

     

       62
       62
       +
       

     

       63
       63
       +
       	// Get OAuth session from context (injected by auth middleware)

     

       64
       64
       +
       	session := middleware.GetOAuthSession(r)

     

       65
       65
       +
       	if session == nil {

     

       66
       66
       +
       		writeError(w, http.StatusUnauthorized, "AuthRequired", "Authentication required")

     

       67
       67
       +
       		return

     

       68
       68
       +
       	}

     

       69
       69
       +
       

     

       70
       70
       +
       	// Create delete vote request

     

       71
       71
       +
       	req := votes.DeleteVoteRequest{

     

       72
       72
       +
       		Subject: votes.StrongRef{

     

       73
       73
       +
       			URI: input.Subject.URI,

     

       74
       74
       +
       			CID: input.Subject.CID,

     

       75
       75
       +
       		},

     

       76
       76
       +
       	}

     

       77
       77
       +
       

     

       78
       78
       +
       	// Call service to delete vote

     

       79
       79
       +
       	err := h.service.DeleteVote(r.Context(), session, req)

     

       80
       80
       +
       	if err != nil {

     

       81
       81
       +
       		handleServiceError(w, err)

     

       82
       82
       +
       		return

     

       83
       83
       +
       	}

     

       84
       84
       +
       

     

       85
       85
       +
       	// Return success response (empty object per lexicon)

     

       86
       86
       +
       	output := DeleteVoteOutput{}

     

       87
       87
       +
       

     

       88
       88
       +
       	w.Header().Set("Content-Type", "application/json")

     

       89
       89
       +
       	w.WriteHeader(http.StatusOK)

     

       90
       90
       +
       	if err := json.NewEncoder(w).Encode(output); err != nil {

     

       91
       91
       +
       		log.Printf("Failed to encode response: %v", err)

     

       92
       92
       +
       	}

     

       93
       93
       +
       }

+24

internal/api/routes/vote.go

···

       1
       1
       +
       package routes

     

       2
       2
       +
       

     

       3
       3
       +
       import (

     

       4
       4
       +
       	"Coves/internal/api/handlers/vote"

     

       5
       5
       +
       	"Coves/internal/api/middleware"

     

       6
       6
       +
       	"Coves/internal/core/votes"

     

       7
       7
       +
       

     

       8
       8
       +
       	"github.com/go-chi/chi/v5"

     

       9
       9
       +
       )

     

       10
       10
       +
       

     

       11
       11
       +
       // RegisterVoteRoutes registers vote-related XRPC endpoints on the router

     

       12
       12
       +
       // Implements social.coves.feed.vote.* lexicon endpoints

     

       13
       13
       +
       func RegisterVoteRoutes(r chi.Router, voteService votes.Service, authMiddleware *middleware.OAuthAuthMiddleware) {

     

       14
       14
       +
       	// Initialize handlers

     

       15
       15
       +
       	createHandler := vote.NewCreateVoteHandler(voteService)

     

       16
       16
       +
       	deleteHandler := vote.NewDeleteVoteHandler(voteService)

     

       17
       17
       +
       

     

       18
       18
       +
       	// Procedure endpoints (POST) - require authentication

     

       19
       19
       +
       	// social.coves.feed.vote.create - create or update a vote on a post/comment

     

       20
       20
       +
       	r.With(authMiddleware.RequireAuth).Post("/xrpc/social.coves.feed.vote.create", createHandler.HandleCreateVote)

     

       21
       21
       +
       

     

       22
       22
       +
       	// social.coves.feed.vote.delete - delete a vote from a post/comment

     

       23
       23
       +
       	r.With(authMiddleware.RequireAuth).Post("/xrpc/social.coves.feed.vote.delete", deleteHandler.HandleDeleteVote)

     

       24
       24
       +
       }

+16

tests/integration/helpers.go

···

       322
       322
        
       

     

       323
       323
        
       // AddSession adds a session to the store

     

       324
       324
        
       func (m *MockOAuthStore) AddSession(did, sessionID, accessToken string) {

     

       325
       325
       +
       	m.AddSessionWithPDS(did, sessionID, accessToken, getTestPDSURL())

     

       326
       326
       +
       }

     

       327
       327
       +
       

     

       328
       328
       +
       // AddSessionWithPDS adds a session to the store with a specific PDS URL

     

       329
       329
       +
       func (m *MockOAuthStore) AddSessionWithPDS(did, sessionID, accessToken, pdsURL string) {

     

       325
       330
        
       	key := did + ":" + sessionID

     

       326
       331
        
       	parsedDID, _ := syntax.ParseDID(did)

     

       327
       332
        
       	m.sessions[key] = &oauthlib.ClientSessionData{

     

       328
       333
        
       		AccountDID:  parsedDID,

     

       329
       334
        
       		SessionID:   sessionID,

     

       330
       335
        
       		AccessToken: accessToken,

     

       336
       336
       +
       		HostURL:     pdsURL,

     

       331
       337
        
       	}

     

       332
       338
        
       }

     

       333
       339
        
       

     
···

       409
       415
        
       	e.store.AddSession(did, sessionID, "access-token-"+did)

     

       410
       416
        
       	return token

     

       411
       417
        
       }

     

       418
       418
       +
       

     

       419
       419
       +
       // AddUserWithPDSToken registers a user with their real PDS access token

     

       420
       420
       +
       // Use this for E2E tests that need to write to the real PDS

     

       421
       421
       +
       func (e *E2EOAuthMiddleware) AddUserWithPDSToken(did, pdsAccessToken, pdsURL string) string {

     

       422
       422
       +
       	token := "test-token-" + did

     

       423
       423
       +
       	sessionID := "session-" + did

     

       424
       424
       +
       	e.unsealer.AddSession(token, did, sessionID)

     

       425
       425
       +
       	e.store.AddSessionWithPDS(did, sessionID, pdsAccessToken, pdsURL)

     

       426
       426
       +
       	return token

     

       427
       427
       +
       }

.beads/beads.left.jsonl

···

       1
       1
       +
       {"id":"Coves-95q","content_hash":"8ec99d598f067780436b985f9ad57f0fa19632026981038df4f65f192186620b","title":"Add comprehensive API documentation","description":"","status":"open","priority":2,"issue_type":"task","created_at":"2025-11-17T20:30:34.835721854-08:00","updated_at":"2025-11-17T20:30:34.835721854-08:00","source_repo":".","dependencies":[{"issue_id":"Coves-95q","depends_on_id":"Coves-e16","type":"blocks","created_at":"2025-11-17T20:30:46.273899399-08:00","created_by":"daemon"}]}

     

       2
       2
       +
       {"id":"Coves-e16","content_hash":"7c5d0fc8f0e7f626be3dad62af0e8412467330bad01a244e5a7e52ac5afff1c1","title":"Complete post creation and moderation features","description":"","status":"open","priority":1,"issue_type":"feature","created_at":"2025-11-17T20:30:12.885991306-08:00","updated_at":"2025-11-17T20:30:12.885991306-08:00","source_repo":"."}

     

       3
       3
       +
       {"id":"Coves-fce","content_hash":"26b3e16b99f827316ee0d741cc959464bd0c813446c95aef8105c7fd1e6b09ff","title":"Implement aggregator feed federation","description":"","status":"open","priority":1,"issue_type":"feature","created_at":"2025-11-17T20:30:21.453326012-08:00","updated_at":"2025-11-17T20:30:21.453326012-08:00","source_repo":"."}

.beads/beads.left.meta.json

···

       1
       1
       +
       {"version":"0.23.1","timestamp":"2025-12-02T18:25:24.009187871-08:00","commit":"00d7d8d"}

+5 -28

cmd/server/main.go

···

       393
       393
        
       	commentRepo := postgresRepo.NewCommentRepository(db)

     

       394
       394
        
       	log.Println("✅ Comment repository initialized (Jetstream indexing only)")

     

       395
       395
        
       

     

       396
       396
       -
       	// Initialize subject validator for votes (checks posts and comments exist)

     

       397
       397
       -
       	subjectValidator := votes.NewCompositeSubjectValidator(

     

       398
       398
       -
       		// Post existence checker

     

       399
       399
       -
       		func(ctx context.Context, uri string) (bool, error) {

     

       400
       400
       -
       			_, err := postRepo.GetByURI(ctx, uri)

     

       401
       401
       -
       			if err != nil {

     

       402
       402
       -
       				if err == posts.ErrNotFound {

     

       403
       403
       -
       					return false, nil

     

       404
       404
       -
       				}

     

       405
       405
       -
       				return false, err

     

       406
       406
       -
       			}

     

       407
       407
       -
       			return true, nil

     

       408
       408
       -
       		},

     

       409
       409
       -
       		// Comment existence checker

     

       410
       410
       -
       		func(ctx context.Context, uri string) (bool, error) {

     

       411
       411
       -
       			_, err := commentRepo.GetByURI(ctx, uri)

     

       412
       412
       -
       			if err != nil {

     

       413
       413
       -
       				if err == comments.ErrCommentNotFound {

     

       414
       414
       -
       					return false, nil

     

       415
       415
       -
       				}

     

       416
       416
       -
       				return false, err

     

       417
       417
       -
       			}

     

       418
       418
       -
       			return true, nil

     

       419
       419
       -
       		},

     

       420
       420
       -
       	)

     

       421
       421
       -
       

     

       422
       396
        
       	// Initialize vote service (for XRPC API endpoints)

     

       423
       423
       -
       	voteService := votes.NewService(voteRepo, subjectValidator, oauthClient, oauthStore, nil)

     

       424
       424
       -
       	log.Println("✅ Vote service initialized (with OAuth authentication and subject validation)")

     

       397
       397
       +
       	// Note: We don't validate subject existence - the vote goes to the user's PDS regardless.

     

       398
       398
       +
       	// The Jetstream consumer handles orphaned votes correctly by only updating counts for

     

       399
       399
       +
       	// non-deleted subjects. This avoids race conditions and eventual consistency issues.

     

       400
       400
       +
       	voteService := votes.NewService(voteRepo, oauthClient, oauthStore, nil)

     

       401
       401
       +
       	log.Println("✅ Vote service initialized (with OAuth authentication)")

     

       425
       402
        
       

     

       426
       403
        
       	// Initialize comment service (for query API)

     

       427
       404
        
       	// Requires user and community repos for proper author/community hydration per lexicon

-3

internal/api/handlers/vote/errors.go

···

       34
       34
        
       	case errors.Is(err, votes.ErrVoteNotFound):

     

       35
       35
        
       		// Matches: social.coves.feed.vote.delete#VoteNotFound

     

       36
       36
        
       		writeError(w, http.StatusNotFound, "VoteNotFound", "No vote found for this subject")

     

       37
       37
       -
       	case errors.Is(err, votes.ErrSubjectNotFound):

     

       38
       38
       -
       		// Matches: social.coves.feed.vote.create#SubjectNotFound

     

       39
       39
       -
       		writeError(w, http.StatusNotFound, "SubjectNotFound", "The subject post or comment was not found")

     

       40
       37
        
       	case errors.Is(err, votes.ErrInvalidDirection):

     

       41
       38
        
       		writeError(w, http.StatusBadRequest, "InvalidRequest", "Vote direction must be 'up' or 'down'")

     

       42
       39
        
       	case errors.Is(err, votes.ErrInvalidSubject):

-3

internal/core/votes/errors.go

···

       6
       6
        
       	// ErrVoteNotFound indicates the requested vote doesn't exist

     

       7
       7
        
       	ErrVoteNotFound = errors.New("vote not found")

     

       8
       8
        
       

     

       9
       9
       -
       	// ErrSubjectNotFound indicates the post/comment being voted on doesn't exist

     

       10
       10
       -
       	ErrSubjectNotFound = errors.New("subject not found")

     

       11
       11
       -
       

     

       12
       9
        
       	// ErrInvalidDirection indicates the vote direction is not "up" or "down"

     

       13
       10
        
       	ErrInvalidDirection = errors.New("invalid vote direction: must be 'up' or 'down'")

     

       14
       11

+14 -27

internal/core/votes/service_impl.go

···

       19
       19
        
       

     

       20
       20
        
       // voteService implements the Service interface for vote operations

     

       21
       21
        
       type voteService struct {

     

       22
       22
       -
       	repo             Repository

     

       23
       23
       -
       	subjectValidator SubjectValidator

     

       24
       24
       -
       	oauthClient      *oauthclient.OAuthClient

     

       25
       25
       -
       	oauthStore       oauth.ClientAuthStore

     

       26
       26
       -
       	logger           *slog.Logger

     

       22
       22
       +
       	repo        Repository

     

       23
       23
       +
       	oauthClient *oauthclient.OAuthClient

     

       24
       24
       +
       	oauthStore  oauth.ClientAuthStore

     

       25
       25
       +
       	logger      *slog.Logger

     

       27
       26
        
       }

     

       28
       27
        
       

     

       29
       28
        
       // NewService creates a new vote service instance

     

       30
       30
       -
       // subjectValidator can be nil to skip subject existence checks (not recommended for production)

     

       31
       31
       -
       func NewService(repo Repository, subjectValidator SubjectValidator, oauthClient *oauthclient.OAuthClient, oauthStore oauth.ClientAuthStore, logger *slog.Logger) Service {

     

       29
       29
       +
       func NewService(repo Repository, oauthClient *oauthclient.OAuthClient, oauthStore oauth.ClientAuthStore, logger *slog.Logger) Service {

     

       32
       30
        
       	if logger == nil {

     

       33
       31
        
       		logger = slog.Default()

     

       34
       32
        
       	}

     

       35
       33
        
       	return &voteService{

     

       36
       36
       -
       		repo:             repo,

     

       37
       37
       -
       		subjectValidator: subjectValidator,

     

       38
       38
       -
       		oauthClient:      oauthClient,

     

       39
       39
       -
       		oauthStore:       oauthStore,

     

       40
       40
       -
       		logger:           logger,

     

       34
       34
       +
       		repo:        repo,

     

       35
       35
       +
       		oauthClient: oauthClient,

     

       36
       36
       +
       		oauthStore:  oauthStore,

     

       37
       37
       +
       		logger:      logger,

     

       41
       38
        
       	}

     

       42
       39
        
       }

     

       43
       40
        
       

     
···

       65
       62
        
       		return nil, ErrInvalidSubject

     

       66
       63
        
       	}

     

       67
       64
        
       

     

       68
       68
       -
       	// Validate subject exists in AppView (post or comment)

     

       69
       69
       -
       	// This prevents creating votes on non-existent content

     

       70
       70
       -
       	if s.subjectValidator != nil {

     

       71
       71
       -
       		exists, err := s.subjectValidator.SubjectExists(ctx, req.Subject.URI)

     

       72
       72
       -
       		if err != nil {

     

       73
       73
       -
       			s.logger.Error("failed to validate subject existence",

     

       74
       74
       -
       				"error", err,

     

       75
       75
       -
       				"subject", req.Subject.URI)

     

       76
       76
       -
       			return nil, fmt.Errorf("failed to validate subject: %w", err)

     

       77
       77
       -
       		}

     

       78
       78
       -
       		if !exists {

     

       79
       79
       -
       			return nil, ErrSubjectNotFound

     

       80
       80
       -
       		}

     

       81
       81
       -
       	}

     

       65
       65
       +
       	// Note: We intentionally don't validate subject existence here.

     

       66
       66
       +
       	// The vote record goes to the user's PDS regardless. The Jetstream consumer

     

       67
       67
       +
       	// handles orphaned votes correctly by only updating counts for non-deleted subjects.

     

       68
       68
       +
       	// This avoids race conditions and eventual consistency issues.

     

       82
       69
        
       

     

       83
       70
        
       	// Check for existing vote by querying PDS directly (source of truth)

     

       84
       71
        
       	// This avoids eventual consistency issues with the AppView database

     
···

       284
       271
        
       

     

       285
       272
        
       		// Parse the listRecords response

     

       286
       273
        
       		var result struct {

     

       274
       274
       +
       			Cursor  string `json:"cursor"`

     

       287
       275
        
       			Records []struct {

     

       288
       276
        
       				URI   string `json:"uri"`

     

       289
       277
        
       				CID   string `json:"cid"`

     
···

       297
       285
        
       					CreatedAt string `json:"createdAt"`

     

       298
       286
        
       				} `json:"value"`

     

       299
       287
        
       			} `json:"records"`

     

       300
       300
       -
       			Cursor string `json:"cursor"`

     

       301
       288
        
       		}

     

       302
       289
        
       

     

       303
       290
        
       		if err := json.Unmarshal(body, &result); err != nil {

+3 -2

internal/db/postgres/vote_repo.go

···

       64
       64
        
       	return nil

     

       65
       65
        
       }

     

       66
       66
        
       

     

       67
       67
       -
       // GetByURI retrieves a vote by its AT-URI

     

       67
       67
       +
       // GetByURI retrieves an active vote by its AT-URI

     

       68
       68
        
       // Used by Jetstream consumer for DELETE operations

     

       69
       69
       +
       // Returns ErrVoteNotFound for soft-deleted votes

     

       69
       70
        
       func (r *postgresVoteRepo) GetByURI(ctx context.Context, uri string) (*votes.Vote, error) {

     

       70
       71
        
       	query := `

     

       71
       72
        
       		SELECT

     
···

       73
       74
        
       			subject_uri, subject_cid, direction,

     

       74
       75
        
       			created_at, indexed_at, deleted_at

     

       75
       76
        
       		FROM votes

     

       76
       76
       -
       		WHERE uri = $1

     

       77
       77
       +
       		WHERE uri = $1 AND deleted_at IS NULL

     

       77
       78
        
       	`

     

       78
       79
        
       

     

       79
       80
        
       	var vote votes.Vote

Compare changes