comparing e2826acfa65504b336495683235852b9e86c2fc4 and feat/vote-xrpc-endpoints on bretton.dev/coves

+3

.beads/beads.left.jsonl

···

       1
       1
       +
       {"id":"Coves-95q","content_hash":"8ec99d598f067780436b985f9ad57f0fa19632026981038df4f65f192186620b","title":"Add comprehensive API documentation","description":"","status":"open","priority":2,"issue_type":"task","created_at":"2025-11-17T20:30:34.835721854-08:00","updated_at":"2025-11-17T20:30:34.835721854-08:00","source_repo":".","dependencies":[{"issue_id":"Coves-95q","depends_on_id":"Coves-e16","type":"blocks","created_at":"2025-11-17T20:30:46.273899399-08:00","created_by":"daemon"}]}

     

       2
       2
       +
       {"id":"Coves-e16","content_hash":"7c5d0fc8f0e7f626be3dad62af0e8412467330bad01a244e5a7e52ac5afff1c1","title":"Complete post creation and moderation features","description":"","status":"open","priority":1,"issue_type":"feature","created_at":"2025-11-17T20:30:12.885991306-08:00","updated_at":"2025-11-17T20:30:12.885991306-08:00","source_repo":"."}

     

       3
       3
       +
       {"id":"Coves-fce","content_hash":"26b3e16b99f827316ee0d741cc959464bd0c813446c95aef8105c7fd1e6b09ff","title":"Implement aggregator feed federation","description":"","status":"open","priority":1,"issue_type":"feature","created_at":"2025-11-17T20:30:21.453326012-08:00","updated_at":"2025-11-17T20:30:21.453326012-08:00","source_repo":"."}

+1

.beads/beads.left.meta.json

···

       1
       1
       +
       {"version":"0.23.1","timestamp":"2025-12-02T18:25:24.009187871-08:00","commit":"00d7d8d"}

+5 -28

cmd/server/main.go

···

       393
       393
        
       	commentRepo := postgresRepo.NewCommentRepository(db)

     

       394
       394
        
       	log.Println("✅ Comment repository initialized (Jetstream indexing only)")

     

       395
       395
        
       

     

       396
       396
       -
       	// Initialize subject validator for votes (checks posts and comments exist)

     

       397
       397
       -
       	subjectValidator := votes.NewCompositeSubjectValidator(

     

       398
       398
       -
       		// Post existence checker

     

       399
       399
       -
       		func(ctx context.Context, uri string) (bool, error) {

     

       400
       400
       -
       			_, err := postRepo.GetByURI(ctx, uri)

     

       401
       401
       -
       			if err != nil {

     

       402
       402
       -
       				if err == posts.ErrNotFound {

     

       403
       403
       -
       					return false, nil

     

       404
       404
       -
       				}

     

       405
       405
       -
       				return false, err

     

       406
       406
       -
       			}

     

       407
       407
       -
       			return true, nil

     

       408
       408
       -
       		},

     

       409
       409
       -
       		// Comment existence checker

     

       410
       410
       -
       		func(ctx context.Context, uri string) (bool, error) {

     

       411
       411
       -
       			_, err := commentRepo.GetByURI(ctx, uri)

     

       412
       412
       -
       			if err != nil {

     

       413
       413
       -
       				if err == comments.ErrCommentNotFound {

     

       414
       414
       -
       					return false, nil

     

       415
       415
       -
       				}

     

       416
       416
       -
       				return false, err

     

       417
       417
       -
       			}

     

       418
       418
       -
       			return true, nil

     

       419
       419
       -
       		},

     

       420
       420
       -
       	)

     

       421
       421
       -
       

     

       422
       396
        
       	// Initialize vote service (for XRPC API endpoints)

     

       423
       423
       -
       	voteService := votes.NewService(voteRepo, subjectValidator, oauthClient, oauthStore, nil)

     

       424
       424
       -
       	log.Println("✅ Vote service initialized (with OAuth authentication and subject validation)")

     

       397
       397
       +
       	// Note: We don't validate subject existence - the vote goes to the user's PDS regardless.

     

       398
       398
       +
       	// The Jetstream consumer handles orphaned votes correctly by only updating counts for

     

       399
       399
       +
       	// non-deleted subjects. This avoids race conditions and eventual consistency issues.

     

       400
       400
       +
       	voteService := votes.NewService(voteRepo, oauthClient, oauthStore, nil)

     

       401
       401
       +
       	log.Println("✅ Vote service initialized (with OAuth authentication)")

     

       425
       402
        
       

     

       426
       403
        
       	// Initialize comment service (for query API)

     

       427
       404
        
       	// Requires user and community repos for proper author/community hydration per lexicon

+2 -8

internal/api/handlers/vote/create_vote_test.go

···

       344
       344
        
       

     

       345
       345
        
       func TestCreateVoteHandler_ServiceError(t *testing.T) {

     

       346
       346
        
       	tests := []struct {

     

       347
       347
       -
       		name           string

     

       348
       347
        
       		serviceError   error

     

       349
       349
       -
       		expectedStatus int

     

       348
       348
       +
       		name           string

     

       350
       349
        
       		expectedError  string

     

       350
       350
       +
       		expectedStatus int

     

       351
       351
        
       	}{

     

       352
       352
       -
       		{

     

       353
       353
       -
       			name:           "subject not found",

     

       354
       354
       -
       			serviceError:   votes.ErrSubjectNotFound,

     

       355
       355
       -
       			expectedStatus: http.StatusNotFound,

     

       356
       356
       -
       			expectedError:  "SubjectNotFound", // Per lexicon: social.coves.feed.vote.create#SubjectNotFound

     

       357
       357
       -
       		},

     

       358
       352
        
       		{

     

       359
       353
        
       			name:           "invalid direction",

     

       360
       354
        
       			serviceError:   votes.ErrInvalidDirection,

+2 -8

internal/api/handlers/vote/delete_vote_test.go

···

       239
       239
        
       

     

       240
       240
        
       func TestDeleteVoteHandler_ServiceError(t *testing.T) {

     

       241
       241
        
       	tests := []struct {

     

       242
       242
       -
       		name           string

     

       243
       242
        
       		serviceError   error

     

       244
       244
       -
       		expectedStatus int

     

       243
       243
       +
       		name           string

     

       245
       244
        
       		expectedError  string

     

       245
       245
       +
       		expectedStatus int

     

       246
       246
        
       	}{

     

       247
       247
        
       		{

     

       248
       248
        
       			name:           "vote not found",

     
···

       250
       250
        
       			expectedStatus: http.StatusNotFound,

     

       251
       251
        
       			expectedError:  "VoteNotFound", // Per lexicon: social.coves.feed.vote.delete#VoteNotFound

     

       252
       252
        
       		},

     

       253
       253
       -
       		{

     

       254
       254
       -
       			name:           "subject not found",

     

       255
       255
       -
       			serviceError:   votes.ErrSubjectNotFound,

     

       256
       256
       -
       			expectedStatus: http.StatusNotFound,

     

       257
       257
       -
       			expectedError:  "SubjectNotFound", // Per lexicon: social.coves.feed.vote.create#SubjectNotFound

     

       258
       258
       -
       		},

     

       259
       253
        
       		{

     

       260
       254
        
       			name:           "invalid subject",

     

       261
       255
        
       			serviceError:   votes.ErrInvalidSubject,

-3

internal/api/handlers/vote/errors.go

···

       34
       34
        
       	case errors.Is(err, votes.ErrVoteNotFound):

     

       35
       35
        
       		// Matches: social.coves.feed.vote.delete#VoteNotFound

     

       36
       36
        
       		writeError(w, http.StatusNotFound, "VoteNotFound", "No vote found for this subject")

     

       37
       37
       -
       	case errors.Is(err, votes.ErrSubjectNotFound):

     

       38
       38
       -
       		// Matches: social.coves.feed.vote.create#SubjectNotFound

     

       39
       39
       -
       		writeError(w, http.StatusNotFound, "SubjectNotFound", "The subject post or comment was not found")

     

       40
       37
        
       	case errors.Is(err, votes.ErrInvalidDirection):

     

       41
       38
        
       		writeError(w, http.StatusBadRequest, "InvalidRequest", "Vote direction must be 'up' or 'down'")

     

       42
       39
        
       	case errors.Is(err, votes.ErrInvalidSubject):

-4

internal/atproto/lexicon/social/coves/feed/vote/create.json

···

       44
       44
        
               }

     

       45
       45
        
             },

     

       46
       46
        
             "errors": [

     

       47
       47
       -
               {

     

       48
       48
       -
                 "name": "SubjectNotFound",

     

       49
       49
       -
                 "description": "The subject post or comment was not found"

     

       50
       50
       -
               },

     

       51
       47
        
               {

     

       52
       48
        
                 "name": "NotAuthorized",

     

       53
       49
        
                 "description": "User is not authorized to vote on this content"

+4 -4

internal/atproto/oauth/handlers_security.go

···

       25
       25
        
       // - Android: Verified via /.well-known/assetlinks.json

     

       26
       26
        
       var allowedMobileRedirectURIs = map[string]bool{

     

       27
       27
        
       	// Custom scheme per atproto spec (reverse-domain of coves.social)

     

       28
       28
       -
       	"social.coves:/callback":                  true,

     

       29
       29
       -
       	"social.coves://callback":                 true, // Some platforms add double slash

     

       30
       30
       -
       	"social.coves:/oauth/callback":            true, // Alternative path

     

       31
       31
       -
       	"social.coves://oauth/callback":           true,

     

       28
       28
       +
       	"social.coves:/callback":        true,

     

       29
       29
       +
       	"social.coves://callback":       true, // Some platforms add double slash

     

       30
       30
       +
       	"social.coves:/oauth/callback":  true, // Alternative path

     

       31
       31
       +
       	"social.coves://oauth/callback": true,

     

       32
       32
        
       	// Universal Links - cryptographically bound to app (preferred for security)

     

       33
       33
        
       	"https://coves.social/app/oauth/callback": true,

     

       34
       34
        
       }

-3

internal/core/votes/errors.go

···

       6
       6
        
       	// ErrVoteNotFound indicates the requested vote doesn't exist

     

       7
       7
        
       	ErrVoteNotFound = errors.New("vote not found")

     

       8
       8
        
       

     

       9
       9
       -
       	// ErrSubjectNotFound indicates the post/comment being voted on doesn't exist

     

       10
       10
       -
       	ErrSubjectNotFound = errors.New("subject not found")

     

       11
       11
       -
       

     

       12
       9
        
       	// ErrInvalidDirection indicates the vote direction is not "up" or "down"

     

       13
       10
        
       	ErrInvalidDirection = errors.New("invalid vote direction: must be 'up' or 'down'")

     

       14
       11

+10 -6

internal/core/votes/service.go

···

       10
       10
        
       // Implements write-forward pattern: validates requests, then forwards to user's PDS

     

       11
       11
        
       //

     

       12
       12
        
       // Architecture:

     

       13
       13
       -
       // - Service validates input and checks authorization

     

       14
       14
       -
       // - Queries user's PDS directly via com.atproto.repo.listRecords to check existing votes

     

       15
       15
       -
       //   (avoids eventual consistency issues with AppView database)

     

       16
       16
       -
       // - Creates/deletes vote records via com.atproto.repo.createRecord/deleteRecord

     

       17
       17
       -
       // - AppView indexes resulting records from Jetstream firehose for aggregate counts

     

       13
       13
       +
       //   - Service validates input and checks authorization

     

       14
       14
       +
       //   - Queries user's PDS directly via com.atproto.repo.listRecords to check existing votes

     

       15
       15
       +
       //     (avoids eventual consistency issues with AppView database)

     

       16
       16
       +
       //   - Creates/deletes vote records via com.atproto.repo.createRecord/deleteRecord

     

       17
       17
       +
       //   - AppView indexes resulting records from Jetstream firehose for aggregate counts

     

       18
       18
        
       type Service interface {

     

       19
       19
        
       	// CreateVote creates a new vote or toggles off an existing vote

     

       20
       20
        
       	// Returns URI and CID of created vote, or empty strings if toggled off

     
···

       22
       22
        
       	// Validation:

     

       23
       23
        
       	// - Direction must be "up" or "down" (returns ErrInvalidDirection)

     

       24
       24
        
       	// - Subject URI must be valid AT-URI (returns ErrInvalidSubject)

     

       25
       25
       -
       	// - Subject must exist (returns ErrSubjectNotFound)

     

       25
       25
       +
       	// - Subject CID must be provided (returns ErrInvalidSubject)

     

       26
       26
       +
       	//

     

       27
       27
       +
       	// Note: Subject existence is NOT validated. Votes on non-existent or deleted

     

       28
       28
       +
       	// subjects are allowed - the Jetstream consumer handles orphaned votes correctly

     

       29
       29
       +
       	// by only updating counts for non-deleted subjects.

     

       26
       30
        
       	//

     

       27
       31
        
       	// Behavior:

     

       28
       32
        
       	// - If no vote exists: creates new vote with given direction

+14 -27

internal/core/votes/service_impl.go

···

       19
       19
        
       

     

       20
       20
        
       // voteService implements the Service interface for vote operations

     

       21
       21
        
       type voteService struct {

     

       22
       22
       -
       	repo             Repository

     

       23
       23
       -
       	subjectValidator SubjectValidator

     

       24
       24
       -
       	oauthClient      *oauthclient.OAuthClient

     

       25
       25
       -
       	oauthStore       oauth.ClientAuthStore

     

       26
       26
       -
       	logger           *slog.Logger

     

       22
       22
       +
       	repo        Repository

     

       23
       23
       +
       	oauthClient *oauthclient.OAuthClient

     

       24
       24
       +
       	oauthStore  oauth.ClientAuthStore

     

       25
       25
       +
       	logger      *slog.Logger

     

       27
       26
        
       }

     

       28
       27
        
       

     

       29
       28
        
       // NewService creates a new vote service instance

     

       30
       30
       -
       // subjectValidator can be nil to skip subject existence checks (not recommended for production)

     

       31
       31
       -
       func NewService(repo Repository, subjectValidator SubjectValidator, oauthClient *oauthclient.OAuthClient, oauthStore oauth.ClientAuthStore, logger *slog.Logger) Service {

     

       29
       29
       +
       func NewService(repo Repository, oauthClient *oauthclient.OAuthClient, oauthStore oauth.ClientAuthStore, logger *slog.Logger) Service {

     

       32
       30
        
       	if logger == nil {

     

       33
       31
        
       		logger = slog.Default()

     

       34
       32
        
       	}

     

       35
       33
        
       	return &voteService{

     

       36
       36
       -
       		repo:             repo,

     

       37
       37
       -
       		subjectValidator: subjectValidator,

     

       38
       38
       -
       		oauthClient:      oauthClient,

     

       39
       39
       -
       		oauthStore:       oauthStore,

     

       40
       40
       -
       		logger:           logger,

     

       34
       34
       +
       		repo:        repo,

     

       35
       35
       +
       		oauthClient: oauthClient,

     

       36
       36
       +
       		oauthStore:  oauthStore,

     

       37
       37
       +
       		logger:      logger,

     

       41
       38
        
       	}

     

       42
       39
        
       }

     

       43
       40
        
       

     
···

       65
       62
        
       		return nil, ErrInvalidSubject

     

       66
       63
        
       	}

     

       67
       64
        
       

     

       68
       68
       -
       	// Validate subject exists in AppView (post or comment)

     

       69
       69
       -
       	// This prevents creating votes on non-existent content

     

       70
       70
       -
       	if s.subjectValidator != nil {

     

       71
       71
       -
       		exists, err := s.subjectValidator.SubjectExists(ctx, req.Subject.URI)

     

       72
       72
       -
       		if err != nil {

     

       73
       73
       -
       			s.logger.Error("failed to validate subject existence",

     

       74
       74
       -
       				"error", err,

     

       75
       75
       -
       				"subject", req.Subject.URI)

     

       76
       76
       -
       			return nil, fmt.Errorf("failed to validate subject: %w", err)

     

       77
       77
       -
       		}

     

       78
       78
       -
       		if !exists {

     

       79
       79
       -
       			return nil, ErrSubjectNotFound

     

       80
       80
       -
       		}

     

       81
       81
       -
       	}

     

       65
       65
       +
       	// Note: We intentionally don't validate subject existence here.

     

       66
       66
       +
       	// The vote record goes to the user's PDS regardless. The Jetstream consumer

     

       67
       67
       +
       	// handles orphaned votes correctly by only updating counts for non-deleted subjects.

     

       68
       68
       +
       	// This avoids race conditions and eventual consistency issues.

     

       82
       69
        
       

     

       83
       70
        
       	// Check for existing vote by querying PDS directly (source of truth)

     

       84
       71
        
       	// This avoids eventual consistency issues with the AppView database

     
···

       284
       271
        
       

     

       285
       272
        
       		// Parse the listRecords response

     

       286
       273
        
       		var result struct {

     

       274
       274
       +
       			Cursor  string `json:"cursor"`

     

       287
       275
        
       			Records []struct {

     

       288
       276
        
       				URI   string `json:"uri"`

     

       289
       277
        
       				CID   string `json:"cid"`

     
···

       297
       285
        
       					CreatedAt string `json:"createdAt"`

     

       298
       286
        
       				} `json:"value"`

     

       299
       287
        
       			} `json:"records"`

     

       300
       300
       -
       			Cursor string `json:"cursor"`

     

       301
       288
        
       		}

     

       302
       289
        
       

     

       303
       290
        
       		if err := json.Unmarshal(body, &result); err != nil {

-50

internal/core/votes/subject_validator.go

···

       1
       1
       -
       package votes

     

       2
       2
       -
       

     

       3
       3
       -
       import (

     

       4
       4
       -
       	"context"

     

       5
       5
       -
       	"strings"

     

       6
       6
       -
       )

     

       7
       7
       -
       

     

       8
       8
       -
       // SubjectExistsFunc is a function type that checks if a subject exists

     

       9
       9
       -
       type SubjectExistsFunc func(ctx context.Context, uri string) (bool, error)

     

       10
       10
       -
       

     

       11
       11
       -
       // CompositeSubjectValidator validates subjects by checking both posts and comments

     

       12
       12
       -
       type CompositeSubjectValidator struct {

     

       13
       13
       -
       	postExists    SubjectExistsFunc

     

       14
       14
       -
       	commentExists SubjectExistsFunc

     

       15
       15
       -
       }

     

       16
       16
       -
       

     

       17
       17
       -
       // NewCompositeSubjectValidator creates a validator that checks both posts and comments

     

       18
       18
       -
       // Pass nil for either function to skip validation for that type

     

       19
       19
       -
       func NewCompositeSubjectValidator(postExists, commentExists SubjectExistsFunc) *CompositeSubjectValidator {

     

       20
       20
       -
       	return &CompositeSubjectValidator{

     

       21
       21
       -
       		postExists:    postExists,

     

       22
       22
       -
       		commentExists: commentExists,

     

       23
       23
       -
       	}

     

       24
       24
       -
       }

     

       25
       25
       -
       

     

       26
       26
       -
       // SubjectExists checks if a post or comment exists at the given URI

     

       27
       27
       -
       // Determines type from the collection in the URI (e.g., social.coves.feed.post vs social.coves.feed.comment)

     

       28
       28
       -
       func (v *CompositeSubjectValidator) SubjectExists(ctx context.Context, uri string) (bool, error) {

     

       29
       29
       -
       	// Parse collection from AT-URI: at://did/collection/rkey

     

       30
       30
       -
       	// Example: at://did:plc:xxx/social.coves.feed.post/abc123

     

       31
       31
       -
       	if strings.Contains(uri, "/social.coves.feed.post/") {

     

       32
       32
       -
       		if v.postExists != nil {

     

       33
       33
       -
       			return v.postExists(ctx, uri)

     

       34
       34
       -
       		}

     

       35
       35
       -
       		// If no post checker, assume exists (for testing)

     

       36
       36
       -
       		return true, nil

     

       37
       37
       -
       	}

     

       38
       38
       -
       

     

       39
       39
       -
       	if strings.Contains(uri, "/social.coves.feed.comment/") {

     

       40
       40
       -
       		if v.commentExists != nil {

     

       41
       41
       -
       			return v.commentExists(ctx, uri)

     

       42
       42
       -
       		}

     

       43
       43
       -
       		// If no comment checker, assume exists (for testing)

     

       44
       44
       -
       		return true, nil

     

       45
       45
       -
       	}

     

       46
       46
       -
       

     

       47
       47
       -
       	// Unknown collection type - could be from another app

     

       48
       48
       -
       	// For now, allow voting on unknown types (future-proofing)

     

       49
       49
       -
       	return true, nil

     

       50
       50
       -
       }

-9

internal/core/votes/vote.go

···

       1
       1
        
       package votes

     

       2
       2
        
       

     

       3
       3
        
       import (

     

       4
       4
       -
       	"context"

     

       5
       4
        
       	"time"

     

       6
       5
        
       )

     

       7
       6
        
       

     

       8
       8
       -
       // SubjectValidator validates that vote subjects (posts/comments) exist

     

       9
       9
       -
       // This prevents creating votes on non-existent content

     

       10
       10
       -
       type SubjectValidator interface {

     

       11
       11
       -
       	// SubjectExists checks if a post or comment exists at the given URI

     

       12
       12
       -
       	// Returns true if found, false if not found

     

       13
       13
       -
       	SubjectExists(ctx context.Context, uri string) (bool, error)

     

       14
       14
       -
       }

     

       15
       15
       -
       

     

       16
       7
        
       // Vote represents a vote in the AppView database

     

       17
       8
        
       // Votes are indexed from the firehose after being written to user repositories

     

       18
       9
        
       type Vote struct {

+3 -2

internal/db/postgres/vote_repo.go

···

       64
       64
        
       	return nil

     

       65
       65
        
       }

     

       66
       66
        
       

     

       67
       67
       -
       // GetByURI retrieves a vote by its AT-URI

     

       67
       67
       +
       // GetByURI retrieves an active vote by its AT-URI

     

       68
       68
        
       // Used by Jetstream consumer for DELETE operations

     

       69
       69
       +
       // Returns ErrVoteNotFound for soft-deleted votes

     

       69
       70
        
       func (r *postgresVoteRepo) GetByURI(ctx context.Context, uri string) (*votes.Vote, error) {

     

       70
       71
        
       	query := `

     

       71
       72
        
       		SELECT

     
···

       73
       74
        
       			subject_uri, subject_cid, direction,

     

       74
       75
        
       			created_at, indexed_at, deleted_at

     

       75
       76
        
       		FROM votes

     

       76
       76
       -
       		WHERE uri = $1

     

       77
       77
       +
       		WHERE uri = $1 AND deleted_at IS NULL

     

       77
       78
        
       	`

     

       78
       79
        
       

     

       79
       80
        
       	var vote votes.Vote

Compare changes