evan.jarrett.net / at-container-registry
A container registry that uses the AT Protocol for manifest storage and S3 for blob storage. atcr.io
docker container atproto go
fork atom

Run golangci-lint on the codebase. Fix errcheck 🙃 #4

open
opened by evan.jarrett.net

I haven't been proactively writing with the linter enabled. codebase needs some cleaning, many errors are just "not checking the error return value" golangci-lint run

asuralani.kamada.dev

I ran the linter using the config in the repo and only got an error related to the SPDX license JSON (which was fixed using go generate). Is this issue stale? If not, what config generates the errors you were seeing when you first opened the issue?

evan.jarrett.net (author) 
go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.6.0
go generate ./...
golangci-lint run -c .golangci.yml

I currently get 56 issues:

  • errcheck: 36
  • gofmt: 1
  • govet: 1
  • staticcheck: 11
  • unused: 7

The point of this ticket was to see about improving the overall linting of the codebase, and come up with a sane linter config. There is little information here, but I left it open ended for anyone to help.

sign up or login to add to the discussion
Labels
good-first-issue
assignee

None yet.

Participants 2
AT URI
at://did:plc:pddp4xt5lgnv2qsegbzzs4xg/sh.tangled.repo.issue/3m3wywexoe722