comparing 9b708c66fbc1457d78e406bc29624e3a389e9e6b and main on hauleth.dev/esl_hn

+2

config/dev.exs

···

       11
       11
        
           "TQ20YLfpm8CWUZ0wvMVvXwKLjOdxb6//anr3iafpvW15LKlsoMez2OFUTifz0gxs",

     

       12
       12
        
         watchers: []

     

       13
       13
        
       

     

       14
       14
       +
       config :esl_hn, refresh: :timer.seconds(5)

     

       15
       15
       +
       

     

       14
       16
        
       # ## SSL Support

     

       15
       17
        
       #

     

       16
       18
        
       # In order to use HTTPS in development, a self-signed

+3 -3

config/runtime.exs

···

       15
       15
        
         config :esl_hn, EslHnWeb.Endpoint, server: true

     

       16
       16
        
       end

     

       17
       17
        
       

     

       18
       18
       -
       config :esl_hn,

     

       19
       19
       -
         refresh: CR.duration("ESL_HN_REFRESH", {:minutes, 5})

     

       20
       20
       -
       

     

       21
       18
        
       if config_env() == :prod do

     

       19
       19
       +
         config :esl_hn,

     

       20
       20
       +
           refresh: CR.duration("ESL_HN_REFRESH", {:minutes, 5})

     

       21
       21
       +
       

     

       22
       22
        
         secret_key_base =

     

       23
       23
        
           System.get_env("SECRET_KEY_BASE") ||

     

       24
       24
        
             raise """

+2 -2

config/test.exs

···

       3
       3
        
       # We don't run a server during test. If one is required,

     

       4
       4
        
       # you can enable the server option below.

     

       5
       5
        
       config :esl_hn, EslHnWeb.Endpoint,

     

       6
       6
       -
         http: [ip: {127, 0, 0, 1}, port: 4002],

     

       6
       6
       +
         http: [ip: {127, 0, 0, 1}, port: 0],

     

       7
       7
        
         secret_key_base:

     

       8
       8
        
           "6iR9shI35kN7Xr5bOLgBVMHXTZQS49Gwu82WW4rsr0uhaia7D+NjfNrhhvcOp4rr",

     

       9
       9
       -
         server: false

     

       9
       9
       +
         server: true

     

       10
       10
        
       

     

       11
       11
        
       # Disable main refresher in tests

     

       12
       12
        
       config :esl_hn, refresh: 0

+29 -4

lib/esl_hn/cache.ex

···

       1
       1
        
       defmodule EslHn.Cache do

     

       2
       2
       +
         @moduledoc """

     

       3
       3
       +
         Simple cache implementation using ETS tables

     

       4
       4
       +
         """

     

       5
       5
       +
       

     

       2
       6
        
         use GenServer

     

       3
       7
        
       

     

       4
       8
        
         def start_link(opts) do

     
···

       9
       13
        
           end

     

       10
       14
        
         end

     

       11
       15
        
       

     

       16
       16
       +
         @doc """

     

       17
       17
       +
         Fetch data from cache

     

       18
       18
       +
         """

     

       12
       19
        
         def fetch(tid, key) do

     

       13
       20
        
           meta = %{key: key, tid: tid}

     

       14
       21
        
       

     
···

       20
       27
        
           end)

     

       21
       28
        
         end

     

       22
       29
        
       

     

       30
       30
       +
         @doc """

     

       31
       31
       +
         Get data from cache and returns `default` when value isn't present

     

       32
       32
       +
         """

     

       23
       33
        
         def get(tid, key, default \\ nil) do

     

       24
       34
        
           case fetch(tid, key) do

     

       25
       35
        
             {:ok, val} -> val

     
···

       27
       37
        
           end

     

       28
       38
        
         end

     

       29
       39
        
       

     

       40
       40
       +
         @doc """

     

       41
       41
       +
         Write `data` to cache under `key`

     

       42
       42
       +
         """

     

       30
       43
        
         def write(tid, key, data) do

     

       31
       44
        
           meta = %{key: key, tid: tid}

     

       32
       45
        
       

     
···

       37
       50
        
           end)

     

       38
       51
        
         end

     

       39
       52
        
       

     

       53
       53
       +
         @doc """

     

       54
       54
       +
         Bulk write to cache

     

       55
       55
       +
         """

     

       40
       56
        
         def write_all(tid, data) do

     

       41
       57
        
           meta = %{tid: tid}

     

       42
       58
        
       

     
···

       47
       63
        
           end)

     

       48
       64
        
         end

     

       49
       65
        
       

     

       50
       50
       -
         def prune(tid, id) do

     

       51
       51
       -
           :ets.delete(tid, id)

     

       66
       66
       +
         @doc """

     

       67
       67
       +
         Remove value under given key from cache

     

       68
       68
       +
         """

     

       69
       69
       +
         def prune(tid, key) do

     

       70
       70
       +
           :ets.delete(tid, key)

     

       52
       71
        
       

     

       53
       72
        
           :ok

     

       54
       73
        
         end

     

       55
       74
        
       

     

       56
       56
       -
         def prune_all(tid, ids) do

     

       57
       57
       -
           for id <- ids, do: :ets.delete(tid, id)

     

       75
       75
       +
         @doc """

     

       76
       76
       +
         Bulk removal of values from cache

     

       77
       77
       +
         """

     

       78
       78
       +
         def prune_all(tid, keys) do

     

       79
       79
       +
           for key <- keys, do: :ets.delete(tid, key)

     

       58
       80
        
       

     

       59
       81
        
           :ok

     

       60
       82
        
         end

     

       61
       83
        
       

     

       84
       84
       +
         @doc """

     

       85
       85
       +
         Remove all cached data

     

       86
       86
       +
         """

     

       62
       87
        
         def flush(tid) do

     

       63
       88
        
           :ets.delete_all_objects(tid)

     

       64
       89

+15

lib/esl_hn/config_reader.ex

···

       6
       6
        
         something like that

     

       7
       7
        
         """

     

       8
       8
        
       

     

       9
       9
       +
         @doc """

     

       10
       10
       +
         Fetch duration from environment variable `name`

     

       11
       11
       +
       

     

       12
       12
       +
         The return value will be in milliseconds.

     

       13
       13
       +
       

     

       14
       14
       +
         Supported formats are:

     

       15
       15
       +
         - `{integer}` - number of milliseconds in duration

     

       16
       16
       +
         - `{integer}(s|m|h)` - number of seconds|minutes|hours in duration

     

       17
       17
       +
       

     

       18
       18
       +
         If environment variable is not set, then it will use `default` value.

     

       19
       19
       +
         """

     

       20
       20
       +
         @spec duration(name :: String.t(), default :: duration) :: non_neg_integer()

     

       21
       21
       +
               when duration:

     

       22
       22
       +
                      non_neg_integer()

     

       23
       23
       +
                      | {:seconds | :minutes | :hours, non_neg_integer()}

     

       9
       24
        
         def duration(name, default) do

     

       10
       25
        
           case System.fetch_env(name) do

     

       11
       26
        
             :error -> default

+15

lib/esl_hn/hn/story.ex

···

       1
       1
        
       defmodule EslHn.Hn.Story do

     

       2
       2
       +
         @moduledoc """

     

       3
       3
       +
         Schema for describing Hacker News stories

     

       4
       4
       +
       

     

       5
       5
       +
         Not all fields for it are currently used.

     

       6
       6
       +
         """

     

       7
       7
       +
       

     

       2
       8
        
         use Ecto.Schema

     

       3
       9
        
       

     

       4
       10
        
         import Ecto.Changeset

     

       5
       11
        
       

     

       6
       12
        
         @primary_key {:id, :integer, []}

     

       13
       13
       +
       

     

       14
       14
       +
         @type id() :: non_neg_integer()

     

       15
       15
       +
       

     

       16
       16
       +
         @type t() :: %__MODULE__{

     

       17
       17
       +
                 id: id(),

     

       18
       18
       +
                 url: String.t() | nil,

     

       19
       19
       +
                 type: atom(),

     

       20
       20
       +
                 text: String.t()

     

       21
       21
       +
               }

     

       7
       22
        
       

     

       8
       23
        
         embedded_schema do

     

       9
       24
        
           # TODO: Make it `URL` structure

+25 -1

lib/esl_hn/hn.ex

···

       1
       1
        
       defmodule EslHn.Hn do

     

       2
       2
       +
         @moduledoc """

     

       3
       3
       +
         Simple HTTP client for Hacker News API

     

       4
       4
       +
         """

     

       5
       5
       +
       

     

       2
       6
        
         alias EslHn.Hn.Story

     

       3
       7
        
       

     

       8
       8
       +
         @type opts() :: keyword()

     

       9
       9
       +
       

     

       10
       10
       +
         @doc """

     

       11
       11
       +
         Fetch list of top stories

     

       12
       12
       +
       

     

       13
       13
       +
         ## Options

     

       14
       14
       +
       

     

       15
       15
       +
         - `:limit` - amount of stories to fetch (defaults to `50`)

     

       16
       16
       +
         """

     

       4
       17
        
         # TODO: Is there a way to limit amount of returned entries in query?

     

       18
       18
       +
         @spec top_stories_ids(opts()) :: {:ok, [Story.id()]} | {:error, term()}

     

       5
       19
        
         def top_stories_ids(opts \\ []) do

     

       6
       20
        
           limit = opts[:limit] || 50

     

       7
       21
        
       

     
···

       10
       24
        
           end

     

       11
       25
        
         end

     

       12
       26
        
       

     

       27
       27
       +
         @doc """

     

       28
       28
       +
         Fetch single story for given ID

     

       29
       29
       +
         """

     

       30
       30
       +
         @spec story(Story.id(), opts()) :: {:ok, Story.t()} | {:error, term()}

     

       13
       31
        
         def story(id, opts \\ []) do

     

       14
       32
        
           with {:ok, body} <- get("item/:id.json", [id: id], opts) do

     

       15
       33
        
             Story.changeset(body)

     
···

       17
       35
        
           end

     

       18
       36
        
         end

     

       19
       37
        
       

     

       38
       38
       +
         @doc """

     

       39
       39
       +
         Fetch stories for IDs in enumerable

     

       40
       40
       +
         """

     

       41
       41
       +
         @spec stories(Enumerable.t(Story.id()), opts()) ::

     

       42
       42
       +
                 {:ok, [Story.t()]} | {:error, term()}

     

       20
       43
        
         def stories(ids, opts \\ []) do

     

       21
       44
        
           ids

     

       22
       45
        
           |> Task.async_stream(&story(&1, opts))

     

       23
       46
        
           |> map_while(fn

     

       24
       47
        
             {:ok, {:ok, data}} -> {:cont, data}

     

       25
       25
       -
             other -> {:halt, other}

     

       48
       48
       +
             {:ok, error} -> {:halt, error}

     

       49
       49
       +
             {:error, reason} -> {:halt, {:error, {:process_error, reason}}}

     

       26
       50
        
           end)

     

       27
       51
        
           |> case do

     

       28
       52
        
             list when is_list(list) -> {:ok, list}

+4

lib/esl_hn/refresher.ex

···

       1
       1
        
       defmodule EslHn.Refresher do

     

       2
       2
       +
         @moduledoc """

     

       3
       3
       +
         Module defining process that is responsible for refreshing cached data

     

       4
       4
       +
         """

     

       5
       5
       +
       

     

       2
       6
        
         use GenServer

     

       3
       7
        
       

     

       4
       8
        
         alias EslHn.Hn

+4

lib/esl_hn_web/api/controller.ex

···

       1
       1
        
       defmodule EslHnWeb.API.Controller do

     

       2
       2
       +
         @moduledoc """

     

       3
       3
       +
         Controller for serving HN top stories cache

     

       4
       4
       +
         """

     

       5
       5
       +
       

     

       2
       6
        
         use EslHnWeb, :controller

     

       3
       7
        
       

     

       4
       8
        
         def index(conn, params) do

+4

lib/esl_hn_web/api/json.ex

···

       1
       1
        
       defmodule EslHnWeb.API.JSON do

     

       2
       2
       +
         @moduledoc """

     

       3
       3
       +
         Simple JSON view into Hacker New stories

     

       4
       4
       +
         """

     

       5
       5
       +
       

     

       2
       6
        
         def index(attrs) do

     

       3
       7
        
           Enum.map(attrs.items, &one/1)

     

       4
       8
        
         end

+10 -5

lib/esl_hn_web/api/socket.ex

···

       1
       1
        
       defmodule EslHnWeb.API.Socket do

     

       2
       2
       +
         @moduledoc """

     

       3
       3
       +
         WebSocket API for serving top stories news

     

       4
       4
       +
         """

     

       5
       5
       +
       

     

       2
       6
        
         @behaviour Phoenix.Socket.Transport

     

       7
       7
       +
       

     

       8
       8
       +
         alias EslHnWeb.API.JSON, as: View

     

       3
       9
        
       

     

       4
       10
        
         @impl true

     

       5
       11
        
         def child_spec(_opts), do: :ignore

     
···

       19
       25
        
         end

     

       20
       26
        
       

     

       21
       27
        
         @impl true

     

       22
       22
       -
         def handle_in({message, opts}, state) do

     

       23
       23
       -
           dbg({message, opts})

     

       24
       24
       -
       

     

       28
       28
       +
         def handle_in({_message, _opts}, state) do

     

       29
       29
       +
           # Ignore all incoming messages

     

       25
       30
        
           {:ok, state}

     

       26
       31
        
         end

     

       27
       32
        
       

     

       28
       33
        
         @impl true

     

       29
       34
        
         def handle_info(:do_init, state) do

     

       30
       35
        
           stories = EslHn.all(1, 50)

     

       31
       31
       -
           data = EslHnWeb.API.JSON.index(%{items: stories})

     

       36
       36
       +
           data = View.index(%{items: stories})

     

       32
       37
        
       

     

       33
       38
        
           {:push, {:text, JSON.encode_to_iodata!(data)}, state}

     

       34
       39
        
         end

     

       35
       40
        
       

     

       36
       41
        
         def handle_info({:new_stories, stories}, state) do

     

       37
       37
       -
           data = EslHnWeb.API.JSON.index(%{items: stories})

     

       42
       42
       +
           data = View.index(%{items: stories})

     

       38
       43
        
       

     

       39
       44
        
           {:push, {:text, JSON.encode_to_iodata!(data)}, state}

     

       40
       45
        
         end

+5 -1

mix.exs

···

       41
       41
        
       

     

       42
       42
        
             # Linting

     

       43
       43
        
             {:credo, ">= 0.0.0", only: [:dev]},

     

       44
       44
       +
             {:dialyxir, ">= 0.0.0", only: [:dev]},

     

       44
       45
        
       

     

       45
       46
        
             # Testing

     

       46
       47
        
             {:test_server, "~> 0.1.21", only: [:test]},

     

       47
       47
       -
             {:stream_data, "~> 1.0", only: [:dev, :test]}

     

       48
       48
       +
             {:stream_data, "~> 1.0", only: [:dev, :test]},

     

       49
       49
       +
             # Websocket client for testing custom socket transport, I have no idea how

     

       50
       50
       +
             # ti can test it better

     

       51
       51
       +
             {:fresh, "~> 0.4.4", only: [:test]}

     

       48
       52
        
           ]

     

       49
       53
        
         end

     

       50
       54

+4

mix.lock

···

       4
       4
        
         "castore": {:hex, :castore, "1.0.14", "4582dd7d630b48cf5e1ca8d3d42494db51e406b7ba704e81fbd401866366896a", [:mix], [], "hexpm", "7bc1b65249d31701393edaaac18ec8398d8974d52c647b7904d01b964137b9f4"},

     

       5
       5
        
         "credo": {:hex, :credo, "1.7.12", "9e3c20463de4b5f3f23721527fcaf16722ec815e70ff6c60b86412c695d426c1", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "8493d45c656c5427d9c729235b99d498bd133421f3e0a683e5c1b561471291e5"},

     

       6
       6
        
         "decimal": {:hex, :decimal, "2.3.0", "3ad6255aa77b4a3c4f818171b12d237500e63525c2fd056699967a3e7ea20f62", [:mix], [], "hexpm", "a4d66355cb29cb47c3cf30e71329e58361cfcb37c34235ef3bf1d7bf3773aeac"},

     

       7
       7
       +
         "dialyxir": {:hex, :dialyxir, "1.4.5", "ca1571ac18e0f88d4ab245f0b60fa31ff1b12cbae2b11bd25d207f865e8ae78a", [:mix], [{:erlex, ">= 0.2.7", [hex: :erlex, repo: "hexpm", optional: false]}], "hexpm", "b0fb08bb8107c750db5c0b324fa2df5ceaa0f9307690ee3c1f6ba5b9eb5d35c3"},

     

       7
       8
        
         "ecto": {:hex, :ecto, "3.13.2", "7d0c0863f3fc8d71d17fc3ad3b9424beae13f02712ad84191a826c7169484f01", [:mix], [{:decimal, "~> 2.0", [hex: :decimal, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "669d9291370513ff56e7b7e7081b7af3283d02e046cf3d403053c557894a0b3e"},

     

       9
       9
       +
         "erlex": {:hex, :erlex, "0.2.7", "810e8725f96ab74d17aac676e748627a07bc87eb950d2b83acd29dc047a30595", [:mix], [], "hexpm", "3ed95f79d1a844c3f6bf0cea61e0d5612a42ce56da9c03f01df538685365efb0"},

     

       8
       10
        
         "file_system": {:hex, :file_system, "1.1.0", "08d232062284546c6c34426997dd7ef6ec9f8bbd090eb91780283c9016840e8f", [:mix], [], "hexpm", "bfcf81244f416871f2a2e15c1b515287faa5db9c6bcf290222206d120b3d43f6"},

     

       9
       11
        
         "finch": {:hex, :finch, "0.20.0", "5330aefb6b010f424dcbbc4615d914e9e3deae40095e73ab0c1bb0968933cadf", [:mix], [{:mime, "~> 1.0 or ~> 2.0", [hex: :mime, repo: "hexpm", optional: false]}, {:mint, "~> 1.6.2 or ~> 1.7", [hex: :mint, repo: "hexpm", optional: false]}, {:nimble_options, "~> 0.4 or ~> 1.0", [hex: :nimble_options, repo: "hexpm", optional: false]}, {:nimble_pool, "~> 1.1", [hex: :nimble_pool, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "2658131a74d051aabfcba936093c903b8e89da9a1b63e430bee62045fa9b2ee2"},

     

       12
       12
       +
         "fresh": {:hex, :fresh, "0.4.4", "9d67a1d97112e70f4dfabd63b40e4b182ef64dfa84a2d9ee175eb4e34591e9f7", [:mix], [{:castore, "~> 1.0", [hex: :castore, repo: "hexpm", optional: false]}, {:mint, "~> 1.5", [hex: :mint, repo: "hexpm", optional: false]}, {:mint_web_socket, "~> 1.0", [hex: :mint_web_socket, repo: "hexpm", optional: false]}], "hexpm", "ba21d3fa0aa77bf18ca397e4c851de7432bb3f9c170a1645a16e09e4bba54315"},

     

       10
       13
        
         "hpax": {:hex, :hpax, "1.0.3", "ed67ef51ad4df91e75cc6a1494f851850c0bd98ebc0be6e81b026e765ee535aa", [:mix], [], "hexpm", "8eab6e1cfa8d5918c2ce4ba43588e894af35dbd8e91e6e55c817bca5847df34a"},

     

       11
       14
        
         "jason": {:hex, :jason, "1.4.4", "b9226785a9aa77b6857ca22832cffa5d5011a667207eb2a0ad56adb5db443b8a", [:mix], [{:decimal, "~> 1.0 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: true]}], "hexpm", "c5eb0cab91f094599f94d55bc63409236a8ec69a21a67814529e8d5f6cc90b3b"},

     

       12
       15
        
         "mime": {:hex, :mime, "2.0.7", "b8d739037be7cd402aee1ba0306edfdef982687ee7e9859bee6198c1e7e2f128", [:mix], [], "hexpm", "6171188e399ee16023ffc5b76ce445eb6d9672e2e241d2df6050f3c771e80ccd"},

     

       13
       16
        
         "mint": {:hex, :mint, "1.7.1", "113fdb2b2f3b59e47c7955971854641c61f378549d73e829e1768de90fc1abf1", [:mix], [{:castore, "~> 0.1.0 or ~> 1.0", [hex: :castore, repo: "hexpm", optional: true]}, {:hpax, "~> 0.1.1 or ~> 0.2.0 or ~> 1.0", [hex: :hpax, repo: "hexpm", optional: false]}], "hexpm", "fceba0a4d0f24301ddee3024ae116df1c3f4bb7a563a731f45fdfeb9d39a231b"},

     

       17
       17
       +
         "mint_web_socket": {:hex, :mint_web_socket, "1.0.4", "0b539116dbb3d3f861cdf5e15e269a933cb501c113a14db7001a3157d96ffafd", [:mix], [{:mint, ">= 1.4.1 and < 2.0.0-0", [hex: :mint, repo: "hexpm", optional: false]}], "hexpm", "027d4c5529c45a4ba0ce27a01c0f35f284a5468519c045ca15f43decb360a991"},

     

       14
       18
        
         "nimble_options": {:hex, :nimble_options, "1.1.1", "e3a492d54d85fc3fd7c5baf411d9d2852922f66e69476317787a7b2bb000a61b", [:mix], [], "hexpm", "821b2470ca9442c4b6984882fe9bb0389371b8ddec4d45a9504f00a66f650b44"},

     

       15
       19
        
         "nimble_pool": {:hex, :nimble_pool, "1.1.0", "bf9c29fbdcba3564a8b800d1eeb5a3c58f36e1e11d7b7fb2e084a643f645f06b", [:mix], [], "hexpm", "af2e4e6b34197db81f7aad230c1118eac993acc0dae6bc83bac0126d4ae0813a"},

     

       16
       20
        
         "phoenix": {:hex, :phoenix, "1.7.21", "14ca4f1071a5f65121217d6b57ac5712d1857e40a0833aff7a691b7870fc9a3b", [:mix], [{:castore, ">= 0.0.0", [hex: :castore, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: true]}, {:phoenix_pubsub, "~> 2.1", [hex: :phoenix_pubsub, repo: "hexpm", optional: false]}, {:phoenix_template, "~> 1.0", [hex: :phoenix_template, repo: "hexpm", optional: false]}, {:phoenix_view, "~> 2.0", [hex: :phoenix_view, repo: "hexpm", optional: true]}, {:plug, "~> 1.14", [hex: :plug, repo: "hexpm", optional: false]}, {:plug_cowboy, "~> 2.7", [hex: :plug_cowboy, repo: "hexpm", optional: true]}, {:plug_crypto, "~> 1.2 or ~> 2.0", [hex: :plug_crypto, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}, {:websock_adapter, "~> 0.5.3", [hex: :websock_adapter, repo: "hexpm", optional: false]}], "hexpm", "336dce4f86cba56fed312a7d280bf2282c720abb6074bdb1b61ec8095bdd0bc9"},

+64 -1

test/esl_hn/hn_test.exs

···

       32
       32
        
             assert {:error, {:http_response, 418, _}} =

     

       33
       33
        
                      @subject.top_stories_ids(base_url: TestServer.url())

     

       34
       34
        
           end

     

       35
       35
       +
       

     

       36
       36
       +
           test "returns error in case of network error" do

     

       37
       37
       +
             assert {:error, _} =

     

       38
       38
       +
                      @subject.top_stories_ids(

     

       39
       39
       +
                        adapter: fn request ->

     

       40
       40
       +
                          {request, %RuntimeError{message: "oops"}}

     

       41
       41
       +
                        end

     

       42
       42
       +
                      )

     

       43
       43
       +
           end

     

       35
       44
        
         end

     

       36
       45
        
       

     

       37
       46
        
         describe "story/2" do

     

       38
       38
       -
           test "returns error on non 200 response" do

     

       47
       47
       +
           test "returns story on 200 response" do

     

       39
       48
        
             data = %{

     

       40
       49
        
               id: 2137,

     

       41
       50
        
               title: "Foo"

     
···

       49
       58
        
       

     

       50
       59
        
             assert {:ok, %{title: "Foo"}} =

     

       51
       60
        
                      @subject.story(2137, base_url: TestServer.url())

     

       61
       61
       +
           end

     

       62
       62
       +
       

     

       63
       63
       +
           test "returns error in case of network error" do

     

       64
       64
       +
             assert {:error, _} =

     

       65
       65
       +
                      @subject.story(2137,

     

       66
       66
       +
                        adapter: fn request ->

     

       67
       67
       +
                          {request, %RuntimeError{message: "oops"}}

     

       68
       68
       +
                        end

     

       69
       69
       +
                      )

     

       70
       70
       +
           end

     

       71
       71
       +
         end

     

       72
       72
       +
       

     

       73
       73
       +
         describe "stories/2" do

     

       74
       74
       +
           test "returns stories on 200 response" do

     

       75
       75
       +
             TestServer.add("/item/2137.json",

     

       76
       76
       +
               to: fn conn ->

     

       77
       77
       +
                 Phoenix.Controller.json(conn, %{

     

       78
       78
       +
                   id: 2137,

     

       79
       79
       +
                   title: "Foo"

     

       80
       80
       +
                 })

     

       81
       81
       +
               end

     

       82
       82
       +
             )

     

       83
       83
       +
       

     

       84
       84
       +
             TestServer.add("/item/666.json",

     

       85
       85
       +
               to: fn conn ->

     

       86
       86
       +
                 Phoenix.Controller.json(conn, %{

     

       87
       87
       +
                   id: 666,

     

       88
       88
       +
                   title: "Bar"

     

       89
       89
       +
                 })

     

       90
       90
       +
               end

     

       91
       91
       +
             )

     

       92
       92
       +
       

     

       93
       93
       +
             assert {:ok, [_, _]} =

     

       94
       94
       +
                      @subject.stories([2137, 666], base_url: TestServer.url())

     

       95
       95
       +
           end

     

       96
       96
       +
       

     

       97
       97
       +
           test "returns error if at least one story returns error" do

     

       98
       98
       +
             TestServer.add("/item/2137.json",

     

       99
       99
       +
               to: fn conn ->

     

       100
       100
       +
                 Phoenix.Controller.json(conn, %{

     

       101
       101
       +
                   id: 2137,

     

       102
       102
       +
                   title: "Foo"

     

       103
       103
       +
                 })

     

       104
       104
       +
               end

     

       105
       105
       +
             )

     

       106
       106
       +
       

     

       107
       107
       +
             TestServer.add("/item/666.json",

     

       108
       108
       +
               to: fn conn ->

     

       109
       109
       +
                 Conn.send_resp(conn, 404, "")

     

       110
       110
       +
               end

     

       111
       111
       +
             )

     

       112
       112
       +
       

     

       113
       113
       +
             assert {:error, _} =

     

       114
       114
       +
                      @subject.stories([2137, 666], base_url: TestServer.url())

     

       52
       115
        
           end

     

       53
       116
        
         end

     

       54
       117
        
       end

+65

test/esl_hn_web/api/socket_test.exs

···

       1
       1
       +
       defmodule EslHnWeb.Api.SocketTest do

     

       2
       2
       +
         use ExUnit.Case, async: false

     

       3
       3
       +
       

     

       4
       4
       +
         import EslHn.Test.Data

     

       5
       5
       +
       

     

       6
       6
       +
         alias EslHn.Cache

     

       7
       7
       +
       

     

       8
       8
       +
         setup do

     

       9
       9
       +
           assert {:ok, {host, port}} = EslHnWeb.Endpoint.server_info(:http)

     

       10
       10
       +
       

     

       11
       11
       +
           on_exit(fn -> Cache.flush(EslHn) end)

     

       12
       12
       +
       

     

       13
       13
       +
           {:ok, host: host, port: port}

     

       14
       14
       +
         end

     

       15
       15
       +
       

     

       16
       16
       +
         defmodule Client do

     

       17
       17
       +
           use Fresh

     

       18
       18
       +
       

     

       19
       19
       +
           def handle_in({:text, data}, {parent, counter}) do

     

       20
       20
       +
             send(parent, {:ws, counter, JSON.decode!(data)})

     

       21
       21
       +
             {:ok, {parent, counter + 1}}

     

       22
       22
       +
           end

     

       23
       23
       +
         end

     

       24
       24
       +
       

     

       25
       25
       +
         test "receive initial list of stories", ctx do

     

       26
       26
       +
           stories = Enum.take(story(), 50)

     

       27
       27
       +
       

     

       28
       28
       +
           ids = Enum.map(stories, & &1.id)

     

       29
       29
       +
           Cache.write(EslHn, :index, ids)

     

       30
       30
       +
       

     

       31
       31
       +
           Cache.write_all(EslHn, Enum.map(stories, &{&1.id, &1}))

     

       32
       32
       +
       

     

       33
       33
       +
           start_supervised!(

     

       34
       34
       +
             {Client, uri: "ws://localhost:#{ctx.port}/websocket", state: {self(), 0}}

     

       35
       35
       +
           )

     

       36
       36
       +
       

     

       37
       37
       +
           assert_receive {:ws, 0, init}

     

       38
       38
       +
       

     

       39
       39
       +
           recv_ids = Enum.map(init, & &1["id"])

     

       40
       40
       +
       

     

       41
       41
       +
           assert Enum.all?(ids, &(&1 in recv_ids))

     

       42
       42
       +
           assert length(recv_ids) == length(ids)

     

       43
       43
       +
         end

     

       44
       44
       +
       

     

       45
       45
       +
         test "broadcasted events are sent over socket", ctx do

     

       46
       46
       +
           start_supervised!(

     

       47
       47
       +
             {Client, uri: "ws://localhost:#{ctx.port}/websocket", state: {self(), 0}}

     

       48
       48
       +
           )

     

       49
       49
       +
       

     

       50
       50
       +
           assert_receive {:ws, 0, []}

     

       51
       51
       +
       

     

       52
       52
       +
           for stories <- Enum.take(StreamData.list_of(story(), min_length: 1), 10) do

     

       53
       53
       +
             ids = Enum.map(stories, & &1.id)

     

       54
       54
       +
       

     

       55
       55
       +
             EslHn.broadcast_new(stories)

     

       56
       56
       +
       

     

       57
       57
       +
             assert_receive {:ws, _, msg}

     

       58
       58
       +
       

     

       59
       59
       +
             recv_ids = Enum.map(msg, & &1["id"])

     

       60
       60
       +
       

     

       61
       61
       +
             assert Enum.all?(ids, &(&1 in recv_ids))

     

       62
       62
       +
             assert length(recv_ids) == length(ids)

     

       63
       63
       +
           end

     

       64
       64
       +
         end

     

       65
       65
       +
       end

+4

test/support/data.ex

···

       1
       1
        
       defmodule EslHn.Test.Data do

     

       2
       2
       +
         @moduledoc """

     

       3
       3
       +
         Additional `StreamData` generators used during testing

     

       4
       4
       +
         """

     

       5
       5
       +
       

     

       2
       6
        
         use ExUnitProperties

     

       3
       7
        
       

     

       4
       8
        
         alias EslHn.Hn.Story

Compare changes