at master 1.5 kB view raw
1From e996904128653c67b04ddbdb1e10cef158098957 Mon Sep 17 00:00:00 2001 2From: Samuel Dionne-Riel <samuel@dionne-riel.com> 3Date: Fri, 6 Dec 2019 23:00:51 -0500 4Subject: [PATCH] [HACK]: Assumes Expat paths are good. 5 6The `check_lib` check fails with the cross-compilation build platform's 7Perl, since apparently `mktemp` is missing... 8 9Even then, side-stepping the issue, it seems it is not actually enough 10to work, as the compilation fails. 11--- 12 Makefile.PL | 17 +++++++++++------ 13 1 file changed, 11 insertions(+), 6 deletions(-) 14 15diff --git a/Makefile.PL b/Makefile.PL 16index 505d1df..fc38b76 100644 17--- a/Makefile.PL 18+++ b/Makefile.PL 19@@ -29,12 +29,17 @@ foreach (@ARGV) { 20 @ARGV = @replacement_args; 21 22 unless ( 23- check_lib( # fill in what you prompted the user for here 24- lib => [qw(expat)], 25- header => ['expat.h'], 26- incpath => $expat_incpath, 27- ( $expat_libpath ? ( libpath => $expat_libpath ) : () ), 28- ) 29+ #check_lib( # fill in what you prompted the user for here 30+ # lib => [qw(expat)], 31+ # header => ['expat.h'], 32+ # incpath => $expat_incpath, 33+ # ( $expat_libpath ? ( libpath => $expat_libpath ) : () ), 34+ #) 35+ # The check_lib implementation fails horribly with cross-compilation. 36+ # We are giving known good paths to expat. 37+ # And in all cases, the previous behaviour of not actually failing 38+ # seemed to work just fine :/. 39+ false 40 ) { 41 warn <<'Expat_Not_Installed;'; 42 43-- 442.23.0 45