tangled.org / core
Monorepo for Tangled — https://tangled.org
fork atom

some PR resubmits do not advance a round #220

closed
opened by oppi.li

in stacked PRs, there is an optimization to avoid resubmitting a PR if nothing about the patch changed. this is not preferable for several reasons: the contents of the patch being identical does not mean that the code behaviour is identical. this behaviour should be undone.

oppi.li (author)

to fix this issue: simply remove the logic that checks for patch equality in appview/pulls/pulls.go.

oppi.li (author)

we can improve the UX here a bit: refer to gerrit. no code change + rebase is an explicit state.

oppi.li (author)

on latest master, patch equality detection has been removed.

oppi.li (author)

and deployed!

sign up or login to add to the discussion
Labels
good-first-issue
area
appview
assignee

None yet.

Participants 1
AT URI
at://did:plc:qfpnj4og54vl56wngdriaxug/sh.tangled.repo.issue/3lzqaizx4lo22