Monorepo for Tangled โ€” https://tangled.org

look into incorrect diffs produced by patchutil.CombineDiff #222

closed
opened by oppi.li

the algorithm is slightly wrong, or needs to handle an edge-case: it sometimes adds empty lines for lines that are unknown and these are rendered in the final diff. it remains to be seen if CombinePatch is even possible without a git-index, one fix is to request the combined patch from the knotserver for a given revlist and cache that on the AV.

@a.starrysky.fyi is looking into fixing the CombineDiff algorithm.

this should be fixed on latest master; which updates the knot compare endpoint to also return combined diffs.

sign up or login to add to the discussion
Labels

None yet.

area
appview
assignee
oppi.li
a.starrysky.fyi
Participants 1
AT URI
at://did:plc:qfpnj4og54vl56wngdriaxug/sh.tangled.repo.issue/3lzqavip2ed22