Monorepo for Tangled โ€” https://tangled.org

Resubmitting stacked PRs runs round 0 commit through pipeline #238

closed
opened by a.starrysky.fyi

Description#

When resubmitting a stacked PR, the new commits will not be run through the pipelines. Instead, the commit for round 0 will be rerun through pipelines.

Expected#

I would expect every commit that has been updated (including only via rebases) to have pipelines run for it.

Reproduction steps#

  • Use a repository which has at least 1 pipeline set up
  • Create a change with jujutsu
  • Push it to tangled
  • Create a pull request from your change, make sure stacked PRs are turned on
  • Run jj metaedit your_change_id --update-committer-timestamp
  • Push it to tangled
  • Resubmit in the pull request
  • Notice that the new round does not show any pipeline status
  • Notice in the pipelines tab that a new (duplicate) job is running for the round 0 commit

Non-reproducing#

By non-stacked PR#

  • Use a repository which has at least 1 pipeline set up
  • Create a change with jujutsu
  • Push it to tangled
  • Create a pull request from your change, make sure stacked PRs are turned off
  • Run jj metaedit your_change_id --update-committer-timestamp
  • Push it to tangled
  • Resubmit in the pull request
  • Notice that the new round correctly shows pipeline status
  • Notice in the pipelines tab that a new job is running for the final commit of the new round

By updated change ID#

  • Use a repository which has at least 1 pipeline set up
  • Create a change with jujutsu
  • Push it to tangled
  • Create a pull request from your change, make sure stacked PRs are turned off
  • Run jj metaedit your_change_id --update-change-id
  • Push it to tangled
  • Resubmit in the pull request
  • Notice that your pull request is deleted and a new pull request has been created
  • Notice that the new pull request shows the pipeline status correctly
  • Notice in the pipelines tab that a new job is running for the final commit of the new round

this has been fixed and deployed; thanks for the detailed steps!

sign up or login to add to the discussion
Labels

None yet.

area
appview
assignee

None yet.

Participants 2
AT URI
at://did:plc:uuyqs6y3pwtbteet4swt5i5y/sh.tangled.repo.issue/3m23odnoylh22