Notifications show wrong merger #239

closed

opened by

a.starrysky.fyi 2 months ago

Description#

On merging a pull request in @freshlybakedca.ke/patisserie, I get a notification that "@freshlybakedca.ke merged a pull request". This isn't true, it was me who merged the pull request

Expected#

I would expect to get a notification that looked something like this if another user merged a pull request of mine:

@thecoded.prof merged a pull request #123 some-pr-title on @freshlybakedca.ke/patisserie

And no notification at all if I merged it

a.starrysky.fyi (author) 2mo ago

I'm not entirely sure of the reproduction criteria here - my guess is that we're using the repository owner rather than the submitter as the notification subject, but I'm not entirely certain

I don't know if, for example, this triggers only on your own pull requests or only on pull requests from and to a repository owned by a single owner... more testing would be needed to figure that out

willdot.net 2mo ago

I had the same thing. I closed a PR on the tangled/core repo and got a notification that Tangled had closed the PR.

oppi.li 2mo ago

right yeah, this is a known issue. thanks for the report nonetheless, good to have it tracked.

Labels

None yet.

area

appview

assignee

None yet.

Participants 3

AT URI

at://did:plc:uuyqs6y3pwtbteet4swt5i5y/sh.tangled.repo.issue/3m23olreebq22