tangled.org / core
Monorepo for Tangled — https://tangled.org
fork atom

comment without bodies #328

open
opened by boltless.me

sh.tangled.comment lexicon (introduced in #864) should support meta comments like:

  • request review to A
  • reviewed (approved)
  • reviewed (request modification)

These kind of actions should be decentralized via atproto records.

anirudh.fi

Not sure we should overload the comment lexicon type for this; especially given that it's pretty high-level already and shared between issues and pulls. Instead, what about org.tangled.pull.{review,reviewRequest}?

boltless.me (author)

but then pull have two different types of comments; sh.tangled.comment and sh.tangled.pull.reviewComment.

How about having generalized metadata field in sh.tangled.comment? like bsky's facets. and put sh.tangled.pull.review.* datatypes under this metadata list.

sign up or login to add to the discussion
Labels

None yet.

area

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.issue/3m7srps6ann22