From fc8938c55791090b5ed25d8f9db4de33741fee4b Mon Sep 17 00:00:00 2001 From: oppiliappan Date: Wed, 4 Jun 2025 12:45:57 +0100 Subject: [PATCH] appview: repo: fix potentially nil commit in branches Change-Id: rtwrkkyllvkmtqlployvwwpmtpkursyt old knots will not attach a commit to a branch. sorting by commit time fails in these responses. Signed-off-by: oppiliappan --- appview/repo/repo.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/appview/repo/repo.go b/appview/repo/repo.go index e652bbe..65d1deb 100644 --- a/appview/repo/repo.go +++ b/appview/repo/repo.go @@ -119,7 +119,7 @@ func (rp *Repo) RepoIndex(w http.ResponseWriter, r *http.Request) { if b.IsDefault { return 1 } - if a.Commit != nil { + if a.Commit != nil && b.Commit != nil { if a.Commit.Committer.When.Before(b.Commit.Committer.When) { return 1 } else { @@ -630,7 +630,7 @@ func (rp *Repo) RepoBranches(w http.ResponseWriter, r *http.Request) { if b.IsDefault { return 1 } - if a.Commit != nil { + if a.Commit != nil && b.Commit != nil { if a.Commit.Committer.When.Before(b.Commit.Committer.When) { return 1 } else { -- 2.43.0