Monorepo for Tangled โ€” https://tangled.org

appview/pages: use consistent time component #290

merged
opened by uncenter.dev targeting master from uncenter.dev/core: feat/datetime-on-hover

Creates a new template fragment, repo/fragments/time, that is a component based on the

I haven't been able to test this everywhere because I've still not get local dev-ing all under control. I also plan to make this work for the new duration times in the pipeline -TODO.

0
by uncenter.dev 0 comments
expand 1 commit
appview/pages: use consistent time component
sign up or login to add to the discussion
1
by uncenter.dev 0 comments
expand 1 commit
appview/pages: use consistent time component
sign up or login to add to the discussion
2
by uncenter.dev 3 comments
expand 2 commits
appview/pages: use consistent time component
appview/pages: use duration time component

Now supports the duration times in the pipeline code, should be good for review. Again I've tested the formats on the home page and reviewed the diff pretty carefully but I don't have much data/repositories to work with locally.

This looks pretty solid over all! However, against latest master, the time in the timeline events doesn't line up correctly with the rest of the text.

Fixed! Forgot that div elements have funky behavior within paragraph elements - used spans instead.

sign up or login to add to the discussion
3
by uncenter.dev 0 comments
expand 2 commits
appview/pages: use consistent time component
appview/pages: use duration time component
sign up or login to add to the discussion
4
by uncenter.dev 2 comments
expand 2 commits
appview/pages: use consistent time component
appview/pages: use duration time component

Resolved the merge conflicts, and I also changed all instances where I had changed time elements with extra Tailwind classes to be div wrappers around the new template fragment - using spans now since divs are problematic with layout.

this is very nice, thanks for working on this!

pull request successfully merged
sign up or login to add to the discussion
Labels

None yet.

assignee

None yet.

Participants 3
AT URI
at://did:plc:rkm6m4dsc4da2yzdlvxorhf3/sh.tangled.repo.pull/3ltsc4ceuoy22