From 1a26744508c945aecc938426712e0b01d5a90705 Mon Sep 17 00:00:00 2001 From: nelind Date: Thu, 24 Jul 2025 18:40:11 +0200 Subject: [PATCH] appview: pages: refactor base layout to be one big grid so we can avoid min-h-screen workarounds that cause permanent scrolling Change-Id: sttryvoqzmuzwomukksxrlwuywpplomn Signed-off-by: nelind --- appview/pages/templates/layouts/base.html | 49 +++++++------------ appview/pages/templates/layouts/topbar.html | 2 +- appview/pages/templates/repo/commit.html | 32 +++++++----- .../pages/templates/repo/compare/compare.html | 34 ++++++++----- .../pages/templates/repo/pulls/interdiff.html | 34 ++++++++----- appview/pages/templates/repo/pulls/patch.html | 34 ++++++++----- 6 files changed, 102 insertions(+), 83 deletions(-) diff --git a/appview/pages/templates/layouts/base.html b/appview/pages/templates/layouts/base.html index be4760d..0231760 100644 --- a/appview/pages/templates/layouts/base.html +++ b/appview/pages/templates/layouts/base.html @@ -14,20 +14,16 @@ {{ block "title" . }}{{ end }} ยท tangled {{ block "extrameta" . }}{{ end }} - -
- {{ block "topbarLayout" . }} -
-
- {{ template "layouts/topbar" . }} -
-
- {{ end }} -
+ + {{ block "topbarLayout" . }} +
+ {{ template "layouts/topbar" . }} +
+ {{ end }} -
- {{ block "contentLayout" . }} -
+ {{ block "mainLayout" . }} +
+ {{ block "contentLayout" . }}
{{ block "contentLeft" . }} {{ end }}
@@ -37,11 +33,9 @@
{{ block "contentRight" . }} {{ end }}
-
- {{ end }} - - {{ block "contentAfterLayout" . }} -
+ {{ end }} + + {{ block "contentAfterLayout" . }}
{{ block "contentAfterLeft" . }} {{ end }}
@@ -51,20 +45,15 @@
{{ block "contentAfterRight" . }} {{ end }}
-
- {{ end }} -
- -
- {{ block "footerLayout" . }} -
-
- {{ template "layouts/footer" . }} -
+ {{ end }}
- {{ end }} -
+ {{ end }} + {{ block "footerLayout" . }} +
+ {{ template "layouts/footer" . }} +
+ {{ end }} {{ end }} diff --git a/appview/pages/templates/layouts/topbar.html b/appview/pages/templates/layouts/topbar.html index 34e6be8..737ca6d 100644 --- a/appview/pages/templates/layouts/topbar.html +++ b/appview/pages/templates/layouts/topbar.html @@ -1,5 +1,5 @@ {{ define "layouts/topbar" }} -