From 6d86807218a6e89e15f6a5fdfc13beb66b916c14 Mon Sep 17 00:00:00 2001
From: nelind <nel.n.lindberg@gmail.com>
Date: Fri, 25 Jul 2025 01:42:34 +0200
Subject: [PATCH] appview: pages: remove remaining non-body min-h-screens to
 avoid the permanent scroll here as well
Change-Id: omvrpurvktoqrtynvvqptukywpmnuznq

Signed-off-by: nelind <nel.n.lindberg@gmail.com>
---
 appview/pages/templates/repo/commit.html                    | 6 +++---
 appview/pages/templates/repo/compare/compare.html           | 6 +++---
 .../pages/templates/repo/fragments/diffChangedFiles.html    | 2 +-
 appview/pages/templates/repo/fragments/interdiffFiles.html  | 2 +-
 appview/pages/templates/repo/pulls/interdiff.html           | 6 +++---
 appview/pages/templates/repo/pulls/patch.html               | 6 +++---
 6 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/appview/pages/templates/repo/commit.html b/appview/pages/templates/repo/commit.html
index 38beef9..c3a67f8 100644
--- a/appview/pages/templates/repo/commit.html
+++ b/appview/pages/templates/repo/commit.html
@@ -92,8 +92,8 @@
     {{ end }}
 
     {{ block "contentAfterLayout" . }}
-    <div class="grid grid-cols-1 md:grid-cols-12 gap-4">
-      <div class="col-span-1 md:col-span-2">
+    <div class="flex-grow grid grid-cols-1 md:grid-cols-12 gap-4">
+      <div class="flex flex-col gap-4 col-span-1 md:col-span-2">
         {{ block "contentAfterLeft" . }} {{ end }}
       </div>
       <main class="col-span-1 md:col-span-10">
@@ -118,7 +118,7 @@
   <div class="flex flex-col gap-4 col-span-1 md:col-span-2">
     {{ template "repo/fragments/diffOpts" .DiffOpts }}
   </div>
-  <div class="sticky top-0 mt-4">
+  <div class="sticky top-0 flex-grow max-h-screen">
     {{ template "repo/fragments/diffChangedFiles" .Diff }}
   </div>
 {{end}}
diff --git a/appview/pages/templates/repo/compare/compare.html b/appview/pages/templates/repo/compare/compare.html
index a23ad38..384e0f5 100644
--- a/appview/pages/templates/repo/compare/compare.html
+++ b/appview/pages/templates/repo/compare/compare.html
@@ -23,8 +23,8 @@
     {{ end }}
 
     {{ block "contentAfterLayout" . }}
-    <div class="grid grid-cols-1 md:grid-cols-12 gap-4">
-      <div class="col-span-1 md:col-span-2">
+    <div class="flex-grow grid grid-cols-1 md:grid-cols-12 gap-4">
+      <div class="flex flex-col gap-4 col-span-1 md:col-span-2">
         {{ block "contentAfterLeft" . }} {{ end }}
       </div>
       <main class="col-span-1 md:col-span-10">
@@ -49,7 +49,7 @@
   <div class="flex flex-col gap-4 col-span-1 md:col-span-2">
     {{ template "repo/fragments/diffOpts" .DiffOpts }}
   </div>
-  <div class="sticky top-0 mt-4">
+  <div class="sticky top-0 flex-grow max-h-screen">
     {{ template "repo/fragments/diffChangedFiles" .Diff }}
   </div>
 {{end}}
diff --git a/appview/pages/templates/repo/fragments/diffChangedFiles.html b/appview/pages/templates/repo/fragments/diffChangedFiles.html
index b713204..34c4302 100644
--- a/appview/pages/templates/repo/fragments/diffChangedFiles.html
+++ b/appview/pages/templates/repo/fragments/diffChangedFiles.html
@@ -1,7 +1,7 @@
 {{ define "repo/fragments/diffChangedFiles" }}
   {{ $stat := .Stat }}
   {{ $fileTree := fileTree .ChangedFiles }}
-  <section class="overflow-x-auto text-sm px-6 py-2 border border-gray-200 dark:border-gray-700 w-full mx-auto md:min-h-screen rounded bg-white dark:bg-gray-800 drop-shadow-sm">
+  <section class="overflow-x-auto text-sm px-6 py-2 border border-gray-200 dark:border-gray-700 w-full mx-auto min-h-full rounded bg-white dark:bg-gray-800 drop-shadow-sm">
     <div class="diff-stat">
       <div class="flex gap-2 items-center">
         <strong class="text-sm uppercase dark:text-gray-200">Changed files</strong>
diff --git a/appview/pages/templates/repo/fragments/interdiffFiles.html b/appview/pages/templates/repo/fragments/interdiffFiles.html
index 0825d23..26d3d99 100644
--- a/appview/pages/templates/repo/fragments/interdiffFiles.html
+++ b/appview/pages/templates/repo/fragments/interdiffFiles.html
@@ -1,6 +1,6 @@
 {{ define "repo/fragments/interdiffFiles" }}
 {{ $fileTree := fileTree .AffectedFiles }}
-<section class="mt-4 px-6 py-2 border border-gray-200 dark:border-gray-700 w-full mx-auto rounded bg-white dark:bg-gray-800 drop-shadow-sm md:min-h-screen text-sm">
+<section class="mt-4 px-6 py-2 border border-gray-200 dark:border-gray-700 w-full mx-auto rounded bg-white dark:bg-gray-800 drop-shadow-sm min-h-full text-sm">
   <div class="diff-stat">
     <div class="flex gap-2 items-center">
       <strong class="text-sm uppercase dark:text-gray-200">files</strong>
diff --git a/appview/pages/templates/repo/pulls/interdiff.html b/appview/pages/templates/repo/pulls/interdiff.html
index 78b303c..81da1b2 100644
--- a/appview/pages/templates/repo/pulls/interdiff.html
+++ b/appview/pages/templates/repo/pulls/interdiff.html
@@ -41,8 +41,8 @@
     {{ end }}
 
     {{ block "contentAfterLayout" . }}
-    <div class="grid grid-cols-1 md:grid-cols-12 gap-4">
-      <div class="col-span-1 md:col-span-2">
+    <div class="flex-grow grid grid-cols-1 md:grid-cols-12 gap-4">
+      <div class="flex flex-col gap-4 col-span-1 md:col-span-2">
         {{ block "contentAfterLeft" . }} {{ end }}
       </div>
       <main class="col-span-1 md:col-span-10">
@@ -68,7 +68,7 @@
   <div class="flex flex-col gap-4 col-span-1 md:col-span-2">
     {{ template "repo/fragments/diffOpts" .DiffOpts }}
   </div>
-  <div class="sticky top-0 mt-4">
+  <div class="sticky top-0 flex-grow max-h-screen">
     {{ template "repo/fragments/interdiffFiles" .Interdiff }}
   </div>
 {{end}}
diff --git a/appview/pages/templates/repo/pulls/patch.html b/appview/pages/templates/repo/pulls/patch.html
index cd90c43..3769c3a 100644
--- a/appview/pages/templates/repo/pulls/patch.html
+++ b/appview/pages/templates/repo/pulls/patch.html
@@ -47,8 +47,8 @@
     {{ end }}
 
     {{ block "contentAfterLayout" . }}
-    <div class="grid grid-cols-1 md:grid-cols-12 gap-4">
-      <div class="col-span-1 md:col-span-2">
+    <div class="flex-grow grid grid-cols-1 md:grid-cols-12 gap-4">
+      <div class="flex flex-col gap-4 col-span-1 md:col-span-2">
         {{ block "contentAfterLeft" . }} {{ end }}
       </div>
       <main class="col-span-1 md:col-span-10">
@@ -73,7 +73,7 @@
   <div class="flex flex-col gap-4 col-span-1 md:col-span-2">
     {{ template "repo/fragments/diffOpts" .DiffOpts }}
   </div>
-  <div class="sticky top-0 mt-4">
+  <div class="sticky top-0 flex-grow max-h-screen">
     {{ template "repo/fragments/diffChangedFiles" .Diff }}
   </div>
 {{end}}
-- 
2.50.0