patch of spindle: add sqlite backed secret manager implementation · round #0 · pull #372 · tangled.org/core

+171

spindle/secrets/sqlite.go

···

       1
       1
       +
       // an sqlite3 backed secret manager

     

       2
       2
       +
       package secrets

     

       3
       3
       +
       

     

       4
       4
       +
       import (

     

       5
       5
       +
       	"database/sql"

     

       6
       6
       +
       	"fmt"

     

       7
       7
       +
       	"time"

     

       8
       8
       +
       

     

       9
       9
       +
       	_ "github.com/mattn/go-sqlite3"

     

       10
       10
       +
       )

     

       11
       11
       +
       

     

       12
       12
       +
       type SqliteManager struct {

     

       13
       13
       +
       	db        *sql.DB

     

       14
       14
       +
       	tableName string

     

       15
       15
       +
       }

     

       16
       16
       +
       

     

       17
       17
       +
       type SqliteManagerOpt func(*SqliteManager)

     

       18
       18
       +
       

     

       19
       19
       +
       func WithTableName(name string) SqliteManagerOpt {

     

       20
       20
       +
       	return func(s *SqliteManager) {

     

       21
       21
       +
       		s.tableName = name

     

       22
       22
       +
       	}

     

       23
       23
       +
       }

     

       24
       24
       +
       

     

       25
       25
       +
       func NewSQLiteManager(dbPath string, opts ...SqliteManagerOpt) (*SqliteManager, error) {

     

       26
       26
       +
       	db, err := sql.Open("sqlite3", dbPath)

     

       27
       27
       +
       	if err != nil {

     

       28
       28
       +
       		return nil, fmt.Errorf("failed to open sqlite database: %w", err)

     

       29
       29
       +
       	}

     

       30
       30
       +
       

     

       31
       31
       +
       	manager := &SqliteManager{

     

       32
       32
       +
       		db:        db,

     

       33
       33
       +
       		tableName: "secrets",

     

       34
       34
       +
       	}

     

       35
       35
       +
       

     

       36
       36
       +
       	for _, o := range opts {

     

       37
       37
       +
       		o(manager)

     

       38
       38
       +
       	}

     

       39
       39
       +
       

     

       40
       40
       +
       	if err := manager.init(); err != nil {

     

       41
       41
       +
       		return nil, err

     

       42
       42
       +
       	}

     

       43
       43
       +
       

     

       44
       44
       +
       	return manager, nil

     

       45
       45
       +
       }

     

       46
       46
       +
       

     

       47
       47
       +
       // creates a table and sets up the schema, migrations if any can go here

     

       48
       48
       +
       func (s *SqliteManager) init() error {

     

       49
       49
       +
       	createTable :=

     

       50
       50
       +
       		`create table if not exists ` + s.tableName + `(

     

       51
       51
       +
       			id integer primary key autoincrement,

     

       52
       52
       +
       			repo text not null,

     

       53
       53
       +
       			key text not null,

     

       54
       54
       +
       			value text not null,

     

       55
       55
       +
       			created_at text not null default (strftime('%Y-%m-%dT%H:%M:%SZ', 'now')),

     

       56
       56
       +
       			created_by text not null,

     

       57
       57
       +
       

     

       58
       58
       +
       			unique(repo, key)

     

       59
       59
       +
       		);`

     

       60
       60
       +
       	_, err := s.db.Exec(createTable)

     

       61
       61
       +
       	return err

     

       62
       62
       +
       }

     

       63
       63
       +
       

     

       64
       64
       +
       func (s *SqliteManager) AddSecret(secret UnlockedSecret) error {

     

       65
       65
       +
       	query := fmt.Sprintf(`

     

       66
       66
       +
       		insert or ignore into %s (repo, key, value, created_by)

     

       67
       67
       +
       		values (?, ?, ?, ?);

     

       68
       68
       +
       	`, s.tableName)

     

       69
       69
       +
       

     

       70
       70
       +
       	res, err := s.db.Exec(query, secret.Repo, secret.Key, secret.Value, secret.CreatedBy)

     

       71
       71
       +
       	if err != nil {

     

       72
       72
       +
       		return err

     

       73
       73
       +
       	}

     

       74
       74
       +
       

     

       75
       75
       +
       	num, err := res.RowsAffected()

     

       76
       76
       +
       	if err != nil {

     

       77
       77
       +
       		return err

     

       78
       78
       +
       	}

     

       79
       79
       +
       

     

       80
       80
       +
       	if num == 0 {

     

       81
       81
       +
       		return ErrKeyAlreadyPresent

     

       82
       82
       +
       	}

     

       83
       83
       +
       

     

       84
       84
       +
       	return nil

     

       85
       85
       +
       }

     

       86
       86
       +
       

     

       87
       87
       +
       func (s *SqliteManager) RemoveSecret(secret Secret[any]) error {

     

       88
       88
       +
       	query := fmt.Sprintf(`

     

       89
       89
       +
       		delete from %s where repo = ? and key = ?;

     

       90
       90
       +
       	`, s.tableName)

     

       91
       91
       +
       

     

       92
       92
       +
       	res, err := s.db.Exec(query, secret.Repo, secret.Key)

     

       93
       93
       +
       	if err != nil {

     

       94
       94
       +
       		return err

     

       95
       95
       +
       	}

     

       96
       96
       +
       

     

       97
       97
       +
       	num, err := res.RowsAffected()

     

       98
       98
       +
       	if err != nil {

     

       99
       99
       +
       		return err

     

       100
       100
       +
       	}

     

       101
       101
       +
       

     

       102
       102
       +
       	if num == 0 {

     

       103
       103
       +
       		return ErrKeyNotFound

     

       104
       104
       +
       	}

     

       105
       105
       +
       

     

       106
       106
       +
       	return nil

     

       107
       107
       +
       }

     

       108
       108
       +
       

     

       109
       109
       +
       func (s *SqliteManager) GetSecretsLocked(didSlashRepo DidSlashRepo) ([]LockedSecret, error) {

     

       110
       110
       +
       	query := fmt.Sprintf(`

     

       111
       111
       +
       		select repo, key, created_at, created_by from %s where repo = ?;

     

       112
       112
       +
       	`, s.tableName)

     

       113
       113
       +
       

     

       114
       114
       +
       	rows, err := s.db.Query(query, didSlashRepo)

     

       115
       115
       +
       	if err != nil {

     

       116
       116
       +
       		return nil, err

     

       117
       117
       +
       	}

     

       118
       118
       +
       

     

       119
       119
       +
       	var ls []LockedSecret

     

       120
       120
       +
       	for rows.Next() {

     

       121
       121
       +
       		var l LockedSecret

     

       122
       122
       +
       		var createdAt string

     

       123
       123
       +
       		if err = rows.Scan(&l.Repo, &l.Key, &createdAt, &l.CreatedBy); err != nil {

     

       124
       124
       +
       			return nil, err

     

       125
       125
       +
       		}

     

       126
       126
       +
       

     

       127
       127
       +
       		if t, err := time.Parse(time.RFC3339, createdAt); err == nil {

     

       128
       128
       +
       			l.CreatedAt = t

     

       129
       129
       +
       		}

     

       130
       130
       +
       

     

       131
       131
       +
       		ls = append(ls, l)

     

       132
       132
       +
       	}

     

       133
       133
       +
       

     

       134
       134
       +
       	if err = rows.Err(); err != nil {

     

       135
       135
       +
       		return nil, err

     

       136
       136
       +
       	}

     

       137
       137
       +
       

     

       138
       138
       +
       	return ls, nil

     

       139
       139
       +
       }

     

       140
       140
       +
       

     

       141
       141
       +
       func (s *SqliteManager) GetSecretsUnlocked(didSlashRepo DidSlashRepo) ([]UnlockedSecret, error) {

     

       142
       142
       +
       	query := fmt.Sprintf(`

     

       143
       143
       +
       		select repo, key, value, created_at, created_by from %s where repo = ?;

     

       144
       144
       +
       	`, s.tableName)

     

       145
       145
       +
       

     

       146
       146
       +
       	rows, err := s.db.Query(query, didSlashRepo)

     

       147
       147
       +
       	if err != nil {

     

       148
       148
       +
       		return nil, err

     

       149
       149
       +
       	}

     

       150
       150
       +
       

     

       151
       151
       +
       	var ls []UnlockedSecret

     

       152
       152
       +
       	for rows.Next() {

     

       153
       153
       +
       		var l UnlockedSecret

     

       154
       154
       +
       		var createdAt string

     

       155
       155
       +
       		if err = rows.Scan(&l.Repo, &l.Key, &l.Value, &createdAt, &l.CreatedBy); err != nil {

     

       156
       156
       +
       			return nil, err

     

       157
       157
       +
       		}

     

       158
       158
       +
       

     

       159
       159
       +
       		if t, err := time.Parse(time.RFC3339, createdAt); err == nil {

     

       160
       160
       +
       			l.CreatedAt = t

     

       161
       161
       +
       		}

     

       162
       162
       +
       

     

       163
       163
       +
       		ls = append(ls, l)

     

       164
       164
       +
       	}

     

       165
       165
       +
       

     

       166
       166
       +
       	if err = rows.Err(); err != nil {

     

       167
       167
       +
       		return nil, err

     

       168
       168
       +
       	}

     

       169
       169
       +
       

     

       170
       170
       +
       	return ls, nil

     

       171
       171
       +
       }

+580

spindle/secrets/sqlite_test.go

···

       1
       1
       +
       package secrets

     

       2
       2
       +
       

     

       3
       3
       +
       import (

     

       4
       4
       +
       	"testing"

     

       5
       5
       +
       	"time"

     

       6
       6
       +
       

     

       7
       7
       +
       	"github.com/bluesky-social/indigo/atproto/syntax"

     

       8
       8
       +
       )

     

       9
       9
       +
       

     

       10
       10
       +
       func createInMemoryDB(t *testing.T) *SqliteManager {

     

       11
       11
       +
       	t.Helper()

     

       12
       12
       +
       	manager, err := NewSQLiteManager(":memory:")

     

       13
       13
       +
       	if err != nil {

     

       14
       14
       +
       		t.Fatalf("Failed to create in-memory manager: %v", err)

     

       15
       15
       +
       	}

     

       16
       16
       +
       	return manager

     

       17
       17
       +
       }

     

       18
       18
       +
       

     

       19
       19
       +
       func createTestSecret(repo, key, value, createdBy string) UnlockedSecret {

     

       20
       20
       +
       	return UnlockedSecret{

     

       21
       21
       +
       		Key:       key,

     

       22
       22
       +
       		Value:     value,

     

       23
       23
       +
       		Repo:      syntax.ATURI(repo),

     

       24
       24
       +
       		CreatedAt: time.Now(),

     

       25
       25
       +
       		CreatedBy: syntax.DID(createdBy),

     

       26
       26
       +
       	}

     

       27
       27
       +
       }

     

       28
       28
       +
       

     

       29
       29
       +
       // ensure that interface is satisfied

     

       30
       30
       +
       func TestManagerInterface(t *testing.T) {

     

       31
       31
       +
       	var _ Manager = (*SqliteManager)(nil)

     

       32
       32
       +
       }

     

       33
       33
       +
       

     

       34
       34
       +
       func TestNewSQLiteManager(t *testing.T) {

     

       35
       35
       +
       	tests := []struct {

     

       36
       36
       +
       		name        string

     

       37
       37
       +
       		dbPath      string

     

       38
       38
       +
       		opts        []SqliteManagerOpt

     

       39
       39
       +
       		expectError bool

     

       40
       40
       +
       		expectTable string

     

       41
       41
       +
       	}{

     

       42
       42
       +
       		{

     

       43
       43
       +
       			name:        "default table name",

     

       44
       44
       +
       			dbPath:      ":memory:",

     

       45
       45
       +
       			opts:        nil,

     

       46
       46
       +
       			expectError: false,

     

       47
       47
       +
       			expectTable: "secrets",

     

       48
       48
       +
       		},

     

       49
       49
       +
       		{

     

       50
       50
       +
       			name:        "custom table name",

     

       51
       51
       +
       			dbPath:      ":memory:",

     

       52
       52
       +
       			opts:        []SqliteManagerOpt{WithTableName("custom_secrets")},

     

       53
       53
       +
       			expectError: false,

     

       54
       54
       +
       			expectTable: "custom_secrets",

     

       55
       55
       +
       		},

     

       56
       56
       +
       		{

     

       57
       57
       +
       			name:        "invalid database path",

     

       58
       58
       +
       			dbPath:      "/invalid/path/to/database.db",

     

       59
       59
       +
       			opts:        nil,

     

       60
       60
       +
       			expectError: true,

     

       61
       61
       +
       			expectTable: "",

     

       62
       62
       +
       		},

     

       63
       63
       +
       	}

     

       64
       64
       +
       

     

       65
       65
       +
       	for _, tt := range tests {

     

       66
       66
       +
       		t.Run(tt.name, func(t *testing.T) {

     

       67
       67
       +
       			manager, err := NewSQLiteManager(tt.dbPath, tt.opts...)

     

       68
       68
       +
       			if tt.expectError {

     

       69
       69
       +
       				if err == nil {

     

       70
       70
       +
       					t.Error("Expected error but got none")

     

       71
       71
       +
       				}

     

       72
       72
       +
       				return

     

       73
       73
       +
       			}

     

       74
       74
       +
       

     

       75
       75
       +
       			if err != nil {

     

       76
       76
       +
       				t.Fatalf("Unexpected error: %v", err)

     

       77
       77
       +
       			}

     

       78
       78
       +
       			defer manager.db.Close()

     

       79
       79
       +
       

     

       80
       80
       +
       			if manager.tableName != tt.expectTable {

     

       81
       81
       +
       				t.Errorf("Expected table name %s, got %s", tt.expectTable, manager.tableName)

     

       82
       82
       +
       			}

     

       83
       83
       +
       		})

     

       84
       84
       +
       	}

     

       85
       85
       +
       }

     

       86
       86
       +
       

     

       87
       87
       +
       func TestSqliteManager_AddSecret(t *testing.T) {

     

       88
       88
       +
       	tests := []struct {

     

       89
       89
       +
       		name        string

     

       90
       90
       +
       		secrets     []UnlockedSecret

     

       91
       91
       +
       		expectError []error

     

       92
       92
       +
       	}{

     

       93
       93
       +
       		{

     

       94
       94
       +
       			name: "add single secret",

     

       95
       95
       +
       			secrets: []UnlockedSecret{

     

       96
       96
       +
       				createTestSecret("at://did:plc:foo/repo", "api_key", "secret_value_123", "did:plc:example123"),

     

       97
       97
       +
       			},

     

       98
       98
       +
       			expectError: []error{nil},

     

       99
       99
       +
       		},

     

       100
       100
       +
       		{

     

       101
       101
       +
       			name: "add multiple unique secrets",

     

       102
       102
       +
       			secrets: []UnlockedSecret{

     

       103
       103
       +
       				createTestSecret("at://did:plc:foo/repo", "api_key", "secret_value_123", "did:plc:example123"),

     

       104
       104
       +
       				createTestSecret("at://did:plc:foo/repo", "db_password", "password_456", "did:plc:example123"),

     

       105
       105
       +
       				createTestSecret("at://other.com/repo", "api_key", "other_secret", "did:plc:other"),

     

       106
       106
       +
       			},

     

       107
       107
       +
       			expectError: []error{nil, nil, nil},

     

       108
       108
       +
       		},

     

       109
       109
       +
       		{

     

       110
       110
       +
       			name: "add duplicate secret",

     

       111
       111
       +
       			secrets: []UnlockedSecret{

     

       112
       112
       +
       				createTestSecret("at://did:plc:foo/repo", "api_key", "secret_value_123", "did:plc:example123"),

     

       113
       113
       +
       				createTestSecret("at://did:plc:foo/repo", "api_key", "different_value", "did:plc:example123"),

     

       114
       114
       +
       			},

     

       115
       115
       +
       			expectError: []error{nil, ErrKeyAlreadyPresent},

     

       116
       116
       +
       		},

     

       117
       117
       +
       	}

     

       118
       118
       +
       

     

       119
       119
       +
       	for _, tt := range tests {

     

       120
       120
       +
       		t.Run(tt.name, func(t *testing.T) {

     

       121
       121
       +
       			manager := createInMemoryDB(t)

     

       122
       122
       +
       			defer manager.db.Close()

     

       123
       123
       +
       

     

       124
       124
       +
       			for i, secret := range tt.secrets {

     

       125
       125
       +
       				err := manager.AddSecret(secret)

     

       126
       126
       +
       				if err != tt.expectError[i] {

     

       127
       127
       +
       					t.Errorf("Secret %d: expected error %v, got %v", i, tt.expectError[i], err)

     

       128
       128
       +
       				}

     

       129
       129
       +
       			}

     

       130
       130
       +
       		})

     

       131
       131
       +
       	}

     

       132
       132
       +
       }

     

       133
       133
       +
       

     

       134
       134
       +
       func TestSqliteManager_RemoveSecret(t *testing.T) {

     

       135
       135
       +
       	tests := []struct {

     

       136
       136
       +
       		name         string

     

       137
       137
       +
       		setupSecrets []UnlockedSecret

     

       138
       138
       +
       		removeSecret Secret[any]

     

       139
       139
       +
       		expectError  error

     

       140
       140
       +
       	}{

     

       141
       141
       +
       		{

     

       142
       142
       +
       			name: "remove existing secret",

     

       143
       143
       +
       			setupSecrets: []UnlockedSecret{

     

       144
       144
       +
       				createTestSecret("at://did:plc:foo/repo", "api_key", "secret_value_123", "did:plc:example123"),

     

       145
       145
       +
       			},

     

       146
       146
       +
       			removeSecret: Secret[any]{

     

       147
       147
       +
       				Key:  "api_key",

     

       148
       148
       +
       				Repo: syntax.ATURI("at://did:plc:foo/repo"),

     

       149
       149
       +
       			},

     

       150
       150
       +
       			expectError: nil,

     

       151
       151
       +
       		},

     

       152
       152
       +
       		{

     

       153
       153
       +
       			name: "remove non-existent secret",

     

       154
       154
       +
       			setupSecrets: []UnlockedSecret{

     

       155
       155
       +
       				createTestSecret("at://did:plc:foo/repo", "api_key", "secret_value_123", "did:plc:example123"),

     

       156
       156
       +
       			},

     

       157
       157
       +
       			removeSecret: Secret[any]{

     

       158
       158
       +
       				Key:  "non_existent_key",

     

       159
       159
       +
       				Repo: syntax.ATURI("at://did:plc:foo/repo"),

     

       160
       160
       +
       			},

     

       161
       161
       +
       			expectError: ErrKeyNotFound,

     

       162
       162
       +
       		},

     

       163
       163
       +
       		{

     

       164
       164
       +
       			name:         "remove from empty database",

     

       165
       165
       +
       			setupSecrets: []UnlockedSecret{},

     

       166
       166
       +
       			removeSecret: Secret[any]{

     

       167
       167
       +
       				Key:  "any_key",

     

       168
       168
       +
       				Repo: syntax.ATURI("at://did:plc:foo/repo"),

     

       169
       169
       +
       			},

     

       170
       170
       +
       			expectError: ErrKeyNotFound,

     

       171
       171
       +
       		},

     

       172
       172
       +
       		{

     

       173
       173
       +
       			name: "remove secret from wrong repo",

     

       174
       174
       +
       			setupSecrets: []UnlockedSecret{

     

       175
       175
       +
       				createTestSecret("at://did:plc:foo/repo", "api_key", "secret_value_123", "did:plc:example123"),

     

       176
       176
       +
       			},

     

       177
       177
       +
       			removeSecret: Secret[any]{

     

       178
       178
       +
       				Key:  "api_key",

     

       179
       179
       +
       				Repo: syntax.ATURI("at://other.com/repo"),

     

       180
       180
       +
       			},

     

       181
       181
       +
       			expectError: ErrKeyNotFound,

     

       182
       182
       +
       		},

     

       183
       183
       +
       	}

     

       184
       184
       +
       

     

       185
       185
       +
       	for _, tt := range tests {

     

       186
       186
       +
       		t.Run(tt.name, func(t *testing.T) {

     

       187
       187
       +
       			manager := createInMemoryDB(t)

     

       188
       188
       +
       			defer manager.db.Close()

     

       189
       189
       +
       

     

       190
       190
       +
       			// Setup secrets

     

       191
       191
       +
       			for _, secret := range tt.setupSecrets {

     

       192
       192
       +
       				if err := manager.AddSecret(secret); err != nil {

     

       193
       193
       +
       					t.Fatalf("Failed to setup secret: %v", err)

     

       194
       194
       +
       				}

     

       195
       195
       +
       			}

     

       196
       196
       +
       

     

       197
       197
       +
       			// Test removal

     

       198
       198
       +
       			err := manager.RemoveSecret(tt.removeSecret)

     

       199
       199
       +
       			if err != tt.expectError {

     

       200
       200
       +
       				t.Errorf("Expected error %v, got %v", tt.expectError, err)

     

       201
       201
       +
       			}

     

       202
       202
       +
       		})

     

       203
       203
       +
       	}

     

       204
       204
       +
       }

     

       205
       205
       +
       

     

       206
       206
       +
       func TestSqliteManager_GetSecretsLocked(t *testing.T) {

     

       207
       207
       +
       	tests := []struct {

     

       208
       208
       +
       		name          string

     

       209
       209
       +
       		setupSecrets  []UnlockedSecret

     

       210
       210
       +
       		queryRepo     syntax.ATURI

     

       211
       211
       +
       		expectedCount int

     

       212
       212
       +
       		expectedKeys  []string

     

       213
       213
       +
       		expectError   bool

     

       214
       214
       +
       	}{

     

       215
       215
       +
       		{

     

       216
       216
       +
       			name: "get secrets for repo with multiple secrets",

     

       217
       217
       +
       			setupSecrets: []UnlockedSecret{

     

       218
       218
       +
       				createTestSecret("at://did:plc:foo/repo", "key1", "value1", "did:plc:user1"),

     

       219
       219
       +
       				createTestSecret("at://did:plc:foo/repo", "key2", "value2", "did:plc:user2"),

     

       220
       220
       +
       				createTestSecret("at://other.com/repo", "key3", "value3", "did:plc:user3"),

     

       221
       221
       +
       			},

     

       222
       222
       +
       			queryRepo:     syntax.ATURI("at://did:plc:foo/repo"),

     

       223
       223
       +
       			expectedCount: 2,

     

       224
       224
       +
       			expectedKeys:  []string{"key1", "key2"},

     

       225
       225
       +
       			expectError:   false,

     

       226
       226
       +
       		},

     

       227
       227
       +
       		{

     

       228
       228
       +
       			name: "get secrets for repo with single secret",

     

       229
       229
       +
       			setupSecrets: []UnlockedSecret{

     

       230
       230
       +
       				createTestSecret("at://did:plc:foo/repo", "single_key", "single_value", "did:plc:user1"),

     

       231
       231
       +
       				createTestSecret("at://other.com/repo", "other_key", "other_value", "did:plc:user2"),

     

       232
       232
       +
       			},

     

       233
       233
       +
       			queryRepo:     syntax.ATURI("at://did:plc:foo/repo"),

     

       234
       234
       +
       			expectedCount: 1,

     

       235
       235
       +
       			expectedKeys:  []string{"single_key"},

     

       236
       236
       +
       			expectError:   false,

     

       237
       237
       +
       		},

     

       238
       238
       +
       		{

     

       239
       239
       +
       			name: "get secrets for non-existent repo",

     

       240
       240
       +
       			setupSecrets: []UnlockedSecret{

     

       241
       241
       +
       				createTestSecret("at://did:plc:foo/repo", "key1", "value1", "did:plc:user1"),

     

       242
       242
       +
       			},

     

       243
       243
       +
       			queryRepo:     syntax.ATURI("at://nonexistent.com/repo"),

     

       244
       244
       +
       			expectedCount: 0,

     

       245
       245
       +
       			expectedKeys:  []string{},

     

       246
       246
       +
       			expectError:   false,

     

       247
       247
       +
       		},

     

       248
       248
       +
       		{

     

       249
       249
       +
       			name:          "get secrets from empty database",

     

       250
       250
       +
       			setupSecrets:  []UnlockedSecret{},

     

       251
       251
       +
       			queryRepo:     syntax.ATURI("at://did:plc:foo/repo"),

     

       252
       252
       +
       			expectedCount: 0,

     

       253
       253
       +
       			expectedKeys:  []string{},

     

       254
       254
       +
       			expectError:   false,

     

       255
       255
       +
       		},

     

       256
       256
       +
       	}

     

       257
       257
       +
       

     

       258
       258
       +
       	for _, tt := range tests {

     

       259
       259
       +
       		t.Run(tt.name, func(t *testing.T) {

     

       260
       260
       +
       			manager := createInMemoryDB(t)

     

       261
       261
       +
       			defer manager.db.Close()

     

       262
       262
       +
       

     

       263
       263
       +
       			// Setup secrets

     

       264
       264
       +
       			for _, secret := range tt.setupSecrets {

     

       265
       265
       +
       				if err := manager.AddSecret(secret); err != nil {

     

       266
       266
       +
       					t.Fatalf("Failed to setup secret: %v", err)

     

       267
       267
       +
       				}

     

       268
       268
       +
       			}

     

       269
       269
       +
       

     

       270
       270
       +
       			// Test getting locked secrets

     

       271
       271
       +
       			lockedSecrets, err := manager.GetSecretsLocked(tt.queryRepo)

     

       272
       272
       +
       			if tt.expectError && err == nil {

     

       273
       273
       +
       				t.Error("Expected error but got none")

     

       274
       274
       +
       				return

     

       275
       275
       +
       			}

     

       276
       276
       +
       			if !tt.expectError && err != nil {

     

       277
       277
       +
       				t.Fatalf("Unexpected error: %v", err)

     

       278
       278
       +
       			}

     

       279
       279
       +
       

     

       280
       280
       +
       			if len(lockedSecrets) != tt.expectedCount {

     

       281
       281
       +
       				t.Errorf("Expected %d secrets, got %d", tt.expectedCount, len(lockedSecrets))

     

       282
       282
       +
       			}

     

       283
       283
       +
       

     

       284
       284
       +
       			// Verify keys and that values are not present (locked)

     

       285
       285
       +
       			foundKeys := make(map[string]bool)

     

       286
       286
       +
       			for _, ls := range lockedSecrets {

     

       287
       287
       +
       				foundKeys[ls.Key] = true

     

       288
       288
       +
       				if ls.Repo != tt.queryRepo {

     

       289
       289
       +
       					t.Errorf("Expected repo %s, got %s", tt.queryRepo, ls.Repo)

     

       290
       290
       +
       				}

     

       291
       291
       +
       				if ls.CreatedBy == "" {

     

       292
       292
       +
       					t.Error("Expected CreatedBy to be present")

     

       293
       293
       +
       				}

     

       294
       294
       +
       				if ls.CreatedAt.IsZero() {

     

       295
       295
       +
       					t.Error("Expected CreatedAt to be set")

     

       296
       296
       +
       				}

     

       297
       297
       +
       			}

     

       298
       298
       +
       

     

       299
       299
       +
       			for _, expectedKey := range tt.expectedKeys {

     

       300
       300
       +
       				if !foundKeys[expectedKey] {

     

       301
       301
       +
       					t.Errorf("Expected key %s not found", expectedKey)

     

       302
       302
       +
       				}

     

       303
       303
       +
       			}

     

       304
       304
       +
       		})

     

       305
       305
       +
       	}

     

       306
       306
       +
       }

     

       307
       307
       +
       

     

       308
       308
       +
       func TestSqliteManager_GetSecretsUnlocked(t *testing.T) {

     

       309
       309
       +
       	tests := []struct {

     

       310
       310
       +
       		name            string

     

       311
       311
       +
       		setupSecrets    []UnlockedSecret

     

       312
       312
       +
       		queryRepo       syntax.ATURI

     

       313
       313
       +
       		expectedCount   int

     

       314
       314
       +
       		expectedSecrets map[string]string // key -> value

     

       315
       315
       +
       		expectError     bool

     

       316
       316
       +
       	}{

     

       317
       317
       +
       		{

     

       318
       318
       +
       			name: "get unlocked secrets for repo with multiple secrets",

     

       319
       319
       +
       			setupSecrets: []UnlockedSecret{

     

       320
       320
       +
       				createTestSecret("at://did:plc:foo/repo", "key1", "value1", "did:plc:user1"),

     

       321
       321
       +
       				createTestSecret("at://did:plc:foo/repo", "key2", "value2", "did:plc:user2"),

     

       322
       322
       +
       				createTestSecret("at://other.com/repo", "key3", "value3", "did:plc:user3"),

     

       323
       323
       +
       			},

     

       324
       324
       +
       			queryRepo:     syntax.ATURI("at://did:plc:foo/repo"),

     

       325
       325
       +
       			expectedCount: 2,

     

       326
       326
       +
       			expectedSecrets: map[string]string{

     

       327
       327
       +
       				"key1": "value1",

     

       328
       328
       +
       				"key2": "value2",

     

       329
       329
       +
       			},

     

       330
       330
       +
       			expectError: false,

     

       331
       331
       +
       		},

     

       332
       332
       +
       		{

     

       333
       333
       +
       			name: "get unlocked secrets for repo with single secret",

     

       334
       334
       +
       			setupSecrets: []UnlockedSecret{

     

       335
       335
       +
       				createTestSecret("at://did:plc:foo/repo", "single_key", "single_value", "did:plc:user1"),

     

       336
       336
       +
       				createTestSecret("at://other.com/repo", "other_key", "other_value", "did:plc:user2"),

     

       337
       337
       +
       			},

     

       338
       338
       +
       			queryRepo:     syntax.ATURI("at://did:plc:foo/repo"),

     

       339
       339
       +
       			expectedCount: 1,

     

       340
       340
       +
       			expectedSecrets: map[string]string{

     

       341
       341
       +
       				"single_key": "single_value",

     

       342
       342
       +
       			},

     

       343
       343
       +
       			expectError: false,

     

       344
       344
       +
       		},

     

       345
       345
       +
       		{

     

       346
       346
       +
       			name: "get unlocked secrets for non-existent repo",

     

       347
       347
       +
       			setupSecrets: []UnlockedSecret{

     

       348
       348
       +
       				createTestSecret("at://did:plc:foo/repo", "key1", "value1", "did:plc:user1"),

     

       349
       349
       +
       			},

     

       350
       350
       +
       			queryRepo:       syntax.ATURI("at://nonexistent.com/repo"),

     

       351
       351
       +
       			expectedCount:   0,

     

       352
       352
       +
       			expectedSecrets: map[string]string{},

     

       353
       353
       +
       			expectError:     false,

     

       354
       354
       +
       		},

     

       355
       355
       +
       		{

     

       356
       356
       +
       			name:            "get unlocked secrets from empty database",

     

       357
       357
       +
       			setupSecrets:    []UnlockedSecret{},

     

       358
       358
       +
       			queryRepo:       syntax.ATURI("at://did:plc:foo/repo"),

     

       359
       359
       +
       			expectedCount:   0,

     

       360
       360
       +
       			expectedSecrets: map[string]string{},

     

       361
       361
       +
       			expectError:     false,

     

       362
       362
       +
       		},

     

       363
       363
       +
       	}

     

       364
       364
       +
       

     

       365
       365
       +
       	for _, tt := range tests {

     

       366
       366
       +
       		t.Run(tt.name, func(t *testing.T) {

     

       367
       367
       +
       			manager := createInMemoryDB(t)

     

       368
       368
       +
       			defer manager.db.Close()

     

       369
       369
       +
       

     

       370
       370
       +
       			// Setup secrets

     

       371
       371
       +
       			for _, secret := range tt.setupSecrets {

     

       372
       372
       +
       				if err := manager.AddSecret(secret); err != nil {

     

       373
       373
       +
       					t.Fatalf("Failed to setup secret: %v", err)

     

       374
       374
       +
       				}

     

       375
       375
       +
       			}

     

       376
       376
       +
       

     

       377
       377
       +
       			// Test getting unlocked secrets

     

       378
       378
       +
       			unlockedSecrets, err := manager.GetSecretsUnlocked(tt.queryRepo)

     

       379
       379
       +
       			if tt.expectError && err == nil {

     

       380
       380
       +
       				t.Error("Expected error but got none")

     

       381
       381
       +
       				return

     

       382
       382
       +
       			}

     

       383
       383
       +
       			if !tt.expectError && err != nil {

     

       384
       384
       +
       				t.Fatalf("Unexpected error: %v", err)

     

       385
       385
       +
       			}

     

       386
       386
       +
       

     

       387
       387
       +
       			if len(unlockedSecrets) != tt.expectedCount {

     

       388
       388
       +
       				t.Errorf("Expected %d secrets, got %d", tt.expectedCount, len(unlockedSecrets))

     

       389
       389
       +
       			}

     

       390
       390
       +
       

     

       391
       391
       +
       			// Verify keys, values, and metadata

     

       392
       392
       +
       			for _, us := range unlockedSecrets {

     

       393
       393
       +
       				expectedValue, exists := tt.expectedSecrets[us.Key]

     

       394
       394
       +
       				if !exists {

     

       395
       395
       +
       					t.Errorf("Unexpected key: %s", us.Key)

     

       396
       396
       +
       					continue

     

       397
       397
       +
       				}

     

       398
       398
       +
       				if us.Value != expectedValue {

     

       399
       399
       +
       					t.Errorf("Expected value %s for key %s, got %s", expectedValue, us.Key, us.Value)

     

       400
       400
       +
       				}

     

       401
       401
       +
       				if us.Repo != tt.queryRepo {

     

       402
       402
       +
       					t.Errorf("Expected repo %s, got %s", tt.queryRepo, us.Repo)

     

       403
       403
       +
       				}

     

       404
       404
       +
       				if us.CreatedBy == "" {

     

       405
       405
       +
       					t.Error("Expected CreatedBy to be present")

     

       406
       406
       +
       				}

     

       407
       407
       +
       				if us.CreatedAt.IsZero() {

     

       408
       408
       +
       					t.Error("Expected CreatedAt to be set")

     

       409
       409
       +
       				}

     

       410
       410
       +
       			}

     

       411
       411
       +
       		})

     

       412
       412
       +
       	}

     

       413
       413
       +
       }

     

       414
       414
       +
       

     

       415
       415
       +
       // Test that demonstrates interface usage with table-driven tests

     

       416
       416
       +
       func TestManagerInterface_Usage(t *testing.T) {

     

       417
       417
       +
       	tests := []struct {

     

       418
       418
       +
       		name        string

     

       419
       419
       +
       		operations  []func(Manager) error

     

       420
       420
       +
       		expectError bool

     

       421
       421
       +
       	}{

     

       422
       422
       +
       		{

     

       423
       423
       +
       			name: "successful workflow",

     

       424
       424
       +
       			operations: []func(Manager) error{

     

       425
       425
       +
       				func(m Manager) error {

     

       426
       426
       +
       					secret := createTestSecret("at://interface.test/repo", "test_key", "test_value", "did:plc:user")

     

       427
       427
       +
       					return m.AddSecret(secret)

     

       428
       428
       +
       				},

     

       429
       429
       +
       				func(m Manager) error {

     

       430
       430
       +
       					_, err := m.GetSecretsLocked(syntax.ATURI("at://interface.test/repo"))

     

       431
       431
       +
       					return err

     

       432
       432
       +
       				},

     

       433
       433
       +
       				func(m Manager) error {

     

       434
       434
       +
       					_, err := m.GetSecretsUnlocked(syntax.ATURI("at://interface.test/repo"))

     

       435
       435
       +
       					return err

     

       436
       436
       +
       				},

     

       437
       437
       +
       				func(m Manager) error {

     

       438
       438
       +
       					secret := Secret[any]{

     

       439
       439
       +
       						Key:  "test_key",

     

       440
       440
       +
       						Repo: syntax.ATURI("at://interface.test/repo"),

     

       441
       441
       +
       					}

     

       442
       442
       +
       					return m.RemoveSecret(secret)

     

       443
       443
       +
       				},

     

       444
       444
       +
       			},

     

       445
       445
       +
       			expectError: false,

     

       446
       446
       +
       		},

     

       447
       447
       +
       		{

     

       448
       448
       +
       			name: "error on duplicate key",

     

       449
       449
       +
       			operations: []func(Manager) error{

     

       450
       450
       +
       				func(m Manager) error {

     

       451
       451
       +
       					secret := createTestSecret("at://interface.test/repo", "dup_key", "value1", "did:plc:user")

     

       452
       452
       +
       					return m.AddSecret(secret)

     

       453
       453
       +
       				},

     

       454
       454
       +
       				func(m Manager) error {

     

       455
       455
       +
       					secret := createTestSecret("at://interface.test/repo", "dup_key", "value2", "did:plc:user")

     

       456
       456
       +
       					return m.AddSecret(secret) // Should return ErrKeyAlreadyPresent

     

       457
       457
       +
       				},

     

       458
       458
       +
       			},

     

       459
       459
       +
       			expectError: true,

     

       460
       460
       +
       		},

     

       461
       461
       +
       	}

     

       462
       462
       +
       

     

       463
       463
       +
       	for _, tt := range tests {

     

       464
       464
       +
       		t.Run(tt.name, func(t *testing.T) {

     

       465
       465
       +
       			var manager Manager = createInMemoryDB(t)

     

       466
       466
       +
       			defer func() {

     

       467
       467
       +
       				if sqliteManager, ok := manager.(*SqliteManager); ok {

     

       468
       468
       +
       					sqliteManager.db.Close()

     

       469
       469
       +
       				}

     

       470
       470
       +
       			}()

     

       471
       471
       +
       

     

       472
       472
       +
       			var finalErr error

     

       473
       473
       +
       			for i, operation := range tt.operations {

     

       474
       474
       +
       				if err := operation(manager); err != nil {

     

       475
       475
       +
       					finalErr = err

     

       476
       476
       +
       					t.Logf("Operation %d returned error: %v", i, err)

     

       477
       477
       +
       				}

     

       478
       478
       +
       			}

     

       479
       479
       +
       

     

       480
       480
       +
       			if tt.expectError && finalErr == nil {

     

       481
       481
       +
       				t.Error("Expected error but got none")

     

       482
       482
       +
       			}

     

       483
       483
       +
       			if !tt.expectError && finalErr != nil {

     

       484
       484
       +
       				t.Errorf("Unexpected error: %v", finalErr)

     

       485
       485
       +
       			}

     

       486
       486
       +
       		})

     

       487
       487
       +
       	}

     

       488
       488
       +
       }

     

       489
       489
       +
       

     

       490
       490
       +
       // Integration test with table-driven scenarios

     

       491
       491
       +
       func TestSqliteManager_Integration(t *testing.T) {

     

       492
       492
       +
       	tests := []struct {

     

       493
       493
       +
       		name     string

     

       494
       494
       +
       		scenario func(*testing.T, *SqliteManager)

     

       495
       495
       +
       	}{

     

       496
       496
       +
       		{

     

       497
       497
       +
       			name: "multi-repo secret management",

     

       498
       498
       +
       			scenario: func(t *testing.T, manager *SqliteManager) {

     

       499
       499
       +
       				repo1 := syntax.ATURI("at://example1.com/repo")

     

       500
       500
       +
       				repo2 := syntax.ATURI("at://example2.com/repo")

     

       501
       501
       +
       

     

       502
       502
       +
       				secrets := []UnlockedSecret{

     

       503
       503
       +
       					createTestSecret(string(repo1), "db_password", "super_secret_123", "did:plc:admin"),

     

       504
       504
       +
       					createTestSecret(string(repo1), "api_key", "api_key_456", "did:plc:user1"),

     

       505
       505
       +
       					createTestSecret(string(repo2), "token", "bearer_token_789", "did:plc:user2"),

     

       506
       506
       +
       				}

     

       507
       507
       +
       

     

       508
       508
       +
       				// Add all secrets

     

       509
       509
       +
       				for _, secret := range secrets {

     

       510
       510
       +
       					if err := manager.AddSecret(secret); err != nil {

     

       511
       511
       +
       						t.Fatalf("Failed to add secret %s: %v", secret.Key, err)

     

       512
       512
       +
       					}

     

       513
       513
       +
       				}

     

       514
       514
       +
       

     

       515
       515
       +
       				// Verify counts

     

       516
       516
       +
       				locked1, _ := manager.GetSecretsLocked(repo1)

     

       517
       517
       +
       				locked2, _ := manager.GetSecretsLocked(repo2)

     

       518
       518
       +
       

     

       519
       519
       +
       				if len(locked1) != 2 {

     

       520
       520
       +
       					t.Errorf("Expected 2 secrets for repo1, got %d", len(locked1))

     

       521
       521
       +
       				}

     

       522
       522
       +
       				if len(locked2) != 1 {

     

       523
       523
       +
       					t.Errorf("Expected 1 secret for repo2, got %d", len(locked2))

     

       524
       524
       +
       				}

     

       525
       525
       +
       

     

       526
       526
       +
       				// Remove and verify

     

       527
       527
       +
       				secretToRemove := Secret[any]{Key: "db_password", Repo: repo1}

     

       528
       528
       +
       				if err := manager.RemoveSecret(secretToRemove); err != nil {

     

       529
       529
       +
       					t.Fatalf("Failed to remove secret: %v", err)

     

       530
       530
       +
       				}

     

       531
       531
       +
       

     

       532
       532
       +
       				locked1After, _ := manager.GetSecretsLocked(repo1)

     

       533
       533
       +
       				if len(locked1After) != 1 {

     

       534
       534
       +
       					t.Errorf("Expected 1 secret for repo1 after removal, got %d", len(locked1After))

     

       535
       535
       +
       				}

     

       536
       536
       +
       				if locked1After[0].Key != "api_key" {

     

       537
       537
       +
       					t.Errorf("Expected remaining secret to be 'api_key', got %s", locked1After[0].Key)

     

       538
       538
       +
       				}

     

       539
       539
       +
       			},

     

       540
       540
       +
       		},

     

       541
       541
       +
       		{

     

       542
       542
       +
       			name: "empty database operations",

     

       543
       543
       +
       			scenario: func(t *testing.T, manager *SqliteManager) {

     

       544
       544
       +
       				repo := syntax.ATURI("at://empty.test/repo")

     

       545
       545
       +
       

     

       546
       546
       +
       				// Operations on empty database should not error

     

       547
       547
       +
       				locked, err := manager.GetSecretsLocked(repo)

     

       548
       548
       +
       				if err != nil {

     

       549
       549
       +
       					t.Errorf("GetSecretsLocked on empty DB failed: %v", err)

     

       550
       550
       +
       				}

     

       551
       551
       +
       				if len(locked) != 0 {

     

       552
       552
       +
       					t.Errorf("Expected 0 secrets, got %d", len(locked))

     

       553
       553
       +
       				}

     

       554
       554
       +
       

     

       555
       555
       +
       				unlocked, err := manager.GetSecretsUnlocked(repo)

     

       556
       556
       +
       				if err != nil {

     

       557
       557
       +
       					t.Errorf("GetSecretsUnlocked on empty DB failed: %v", err)

     

       558
       558
       +
       				}

     

       559
       559
       +
       				if len(unlocked) != 0 {

     

       560
       560
       +
       					t.Errorf("Expected 0 secrets, got %d", len(unlocked))

     

       561
       561
       +
       				}

     

       562
       562
       +
       

     

       563
       563
       +
       				// Remove from empty should return ErrKeyNotFound

     

       564
       564
       +
       				nonExistent := Secret[any]{Key: "none", Repo: repo}

     

       565
       565
       +
       				err = manager.RemoveSecret(nonExistent)

     

       566
       566
       +
       				if err != ErrKeyNotFound {

     

       567
       567
       +
       					t.Errorf("Expected ErrKeyNotFound, got %v", err)

     

       568
       568
       +
       				}

     

       569
       569
       +
       			},

     

       570
       570
       +
       		},

     

       571
       571
       +
       	}

     

       572
       572
       +
       

     

       573
       573
       +
       	for _, tt := range tests {

     

       574
       574
       +
       		t.Run(tt.name, func(t *testing.T) {

     

       575
       575
       +
       			manager := createInMemoryDB(t)

     

       576
       576
       +
       			defer manager.db.Close()

     

       577
       577
       +
       			tt.scenario(t, manager)

     

       578
       578
       +
       		})

     

       579
       579
       +
       	}

     

       580
       580
       +
       }