back round 0 view raw

appview: repo: trim leading @ from collaborator's handle #417

merged
opened by bad-example.com targeting master from bad-example.com/core: fix/contributor-handle

The "add collaborator" form currently fails if you submit a handle like @example.com, since the identity gets forwarded eventually directly to Bluesky's identity parse, which does not accept the @ prefix for handles.

This change is targetted to only fix that one form.

I do think it would be nice to put it in idresolver's ResolveIdent instead, but a change there seems like it could have wide effect across the app that i'm not equipped to test. Searching for strings.TrimPrefix shows manual stripping of @-prefixes in middleware, oauth, avatars, and keys, so I figure this direct change is consistent?

(I did not do a thorough survey of other handle handling that might also be missing @-stripping.)

options
unified split
Changed files
+3
appview
repo
repo.go
+3
appview/repo/repo.go 
···

       
742

       
742

       
 

       
		return


     

       
743

       
743

       
 

       
	}


     

       
744

       
744

       
 

       



     

       

       
745

       
+

       
	// remove a single leading `@`, to make @handle work with ResolveIdent


     

       

       
746

       
+

       
	collaborator = strings.TrimPrefix(collaborator, "@")


     

       

       
747

       
+

       



     

       
745

       
748

       
 

       
	collaboratorIdent, err := rp.idResolver.ResolveIdent(r.Context(), collaborator)


     

       
746

       
749

       
 

       
	if err != nil {


     

       
747

       
750

       
 

       
		fail(fmt.Sprintf("'%s' is not a valid DID/handle.", collaborator), err)