knotserver: always show pipeline errors #432

merged

opened by

winter.bsky.social 4 months ago targeting master from winter.bsky.social/core: push-luoyqwkpromz

IMO, we shouldn't make errors opt-in to actually show upon push, at least not if/until we have a UI to show them to the user.

Signed-off-by: Winter winter@winter.cafe

options

unified split

Changed files

+4 -4

knotserver

internal.go

+4 -4

knotserver/internal.go

···

       242
       242
        
       		return err

     

       243
       243
        
       	}

     

       244
       244
        
       

     

       245
       245
       +
       	for _, e := range compiler.Diagnostics.Errors {

     

       246
       246
       +
       		*clientMsgs = append(*clientMsgs, e.String())

     

       247
       247
       +
       	}

     

       248
       248
       +
       

     

       245
       249
        
       	if pushOptions.verboseCi {

     

       246
       250
        
       		if compiler.Diagnostics.IsEmpty() {

     

       247
       251
        
       			*clientMsgs = append(*clientMsgs, "success: pipeline compiled with no diagnostics")

     

       248
       252
        
       		}

     

       249
       253
        
       

     

       250
       250
       -
       		for _, e := range compiler.Diagnostics.Errors {

     

       251
       251
       -
       			*clientMsgs = append(*clientMsgs, e.String())

     

       252
       252
       -
       		}

     

       253
       253
       -
       

     

       254
       254
        
       		for _, w := range compiler.Diagnostics.Warnings {

     

       255
       255
        
       			*clientMsgs = append(*clientMsgs, w.String())

     

       256
       256
        
       		}