Monorepo for Tangled β€” https://tangled.org

appview/db: fix comparing against []byte #440

merged
opened by winter.bsky.social targeting master from winter.bsky.social/core: push-xqqzsrpkuoqz

SQLite stores byte sequences as blobs, which we were not handling properly, causing (at least) actions relating to artifacts to break. (Not sure when they broke, sorry!)

Signed-off-by: Winter winter@winter.cafe

0
by winter.bsky.social 2 comments
expand 1 commit
appview/db: fix comparing against []byte

The (only?) issue with this fix is that if we are indeed relying on this functionality to match on non-byte slices that are uint8s β€” it’s also entirely possible database/sql is storing these as blobs already, then it’ll be fine.

non-byte slices that are uint8s

afaik, we don't do this in the codebase presently, something to keep in mind down the line however.

pull request successfully merged
sign up or login to add to the discussion
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:pdrr2fgsfkvfbznqucjmyeee/sh.tangled.repo.pull/3lvzdxsfy5i22