tangled.org / core

Monorepo for Tangled — https://tangled.org

fork atom

ci: enforce prettier formatting #488

merged

opened by

winter.bsky.social 4 months ago targeting master from push-pzwzzlwkkpnw

submitted by

winter.bsky.social 4mo 0 comments

diff

expand 1 commit

0a359b75

ci: add prettier check (hopefully it works)

resubmitted by

winter.bsky.social 4mo 0 comments

diff interdiff

expand 1 commit

44ad1251

ci: add prettier check (hopefully it works)

resubmitted by

winter.bsky.social 4mo 0 comments

diff interdiff

expand 1 commit

b61a8bfb

ci: add prettier check (hopefully it works)

resubmitted by

winter.bsky.social 4mo 4 comments

diff interdiff

expand 1 commit

4084dcfe

ci: add prettier check (hopefully it works)

winter.bsky.social 4 months ago

Failed to update pull request on the PDS. Try again later.

Oh okay.

isabelroses.com 4 months ago

imo pkgs.runCommand should be pkgs.runCommandLocal I don't think your caching the package anywhere. will also make running the command slightly faster

isabelroses.com 4 months ago

to add a bit to my point. some people may have a number of caches, for example i have 15... i've also seen people with 8 here. this makes this pkgs.runCommand quite slow as oppose to pkgs.runCommandLocal since it doesn't have to contact the caches to see if they have the derivation. since it should build relatively quickly so it shouldn't be too detrimental to remove the cache query from it.

winter.bsky.social 4 months ago

Picked the change Isabel suggested into master.

resubmitted by

winter.bsky.social 4mo 0 comments

diff interdiff

expand 1 commit

69adbcc5

ci: check formatting with treefmt

resubmitted by

winter.bsky.social 4mo 0 comments

diff interdiff

expand 1 commit

9482a0b9

ci: check formatting with treefmt

pull request successfully merged

Labels

None yet.

assignee

None yet.

Participants 2

AT URI

at://did:plc:pdrr2fgsfkvfbznqucjmyeee/sh.tangled.repo.pull/3lwcfu7gtho22