Monorepo for Tangled โ€” https://tangled.org

appview/strings: allow extensionless filenames #516

merged
opened by harperandrews.org targeting master from [deleted fork]: allow-extensionless-strings
0
by harperandrews.org 5 comments
expand 1 commit
7ff76d89
appview/strings: allow extensionless filenames

My editor auto-deleted a trailing space from a line in appview/db/strings.go. Do I need to replace it?

I wrote up a whole description which got swallowed up by https://tangled.sh/@tangled.sh/core/issues/188. Here's a slightly shortened version:

This fixes https://tangled.sh/@tangled.sh/core/issues/187

I don't have nix set up (and I'm on a niche distribution where that might not be the most straightforward thing to change), so I did not test this or run the formatter.

However, I did my best to find and understand all related code. The only code I found that did anything special with the filename was markup.getFormat(), which I confirmed should handle extensionless filenames correctly.

can confirm this works, and formatting looks to be fine

pull request successfully merged
sign up or login to add to the discussion
Labels

None yet.

assignee

None yet.

Participants 3
AT URI
at://did:plc:wbw4fmixz66ydzygugtfhgdz/sh.tangled.repo.pull/3lwu2h5ppnn22