From 7ff76d89b65328bac12651f62cad55c1bdfe5cf0 Mon Sep 17 00:00:00 2001 From: ItsHarper Date: Wed, 20 Aug 2025 10:50:20 -0500 Subject: [PATCH] appview/strings: allow extensionless filenames Signed-off-by: ItsHarper --- appview/db/strings.go | 10 +--------- appview/pages/templates/strings/fragments/form.html | 2 +- appview/strings/strings.go | 11 ----------- 3 files changed, 2 insertions(+), 21 deletions(-) diff --git a/appview/db/strings.go b/appview/db/strings.go index 1830421..b87271c 100644 --- a/appview/db/strings.go +++ b/appview/db/strings.go @@ -50,14 +50,6 @@ func (s String) Stats() StringStats { func (s String) Validate() error { var err error - if !strings.Contains(s.Filename, ".") { - err = errors.Join(err, fmt.Errorf("missing filename extension")) - } - - if strings.HasSuffix(s.Filename, ".") { - err = errors.Join(err, fmt.Errorf("filename ends with `.`")) - } - if utf8.RuneCountInString(s.Filename) > 140 { err = errors.Join(err, fmt.Errorf("filename too long")) } @@ -113,7 +105,7 @@ func AddString(e Execer, s String) error { filename = excluded.filename, description = excluded.description, content = excluded.content, - edited = case + edited = case when strings.content != excluded.content or strings.filename != excluded.filename diff --git a/appview/pages/templates/strings/fragments/form.html b/appview/pages/templates/strings/fragments/form.html index 8c2dd61..30d547d 100644 --- a/appview/pages/templates/strings/fragments/form.html +++ b/appview/pages/templates/strings/fragments/form.html @@ -13,7 +13,7 @@ type="text" id="filename" name="filename" - placeholder="Filename with extension" + placeholder="Filename" required value="{{ .String.Filename }}" class="md:max-w-64 dark:bg-gray-700 dark:text-white dark:border-gray-600 dark:placeholder-gray-400 px-3 py-2 border rounded" diff --git a/appview/strings/strings.go b/appview/strings/strings.go index a51f348..461a0ea 100644 --- a/appview/strings/strings.go +++ b/appview/strings/strings.go @@ -7,7 +7,6 @@ import ( "path" "slices" "strconv" - "strings" "time" "tangled.sh/tangled.sh/core/api/tangled" @@ -288,11 +287,6 @@ func (s *Strings) edit(w http.ResponseWriter, r *http.Request) { fail("Empty filename.", nil) return } - if !strings.Contains(filename, ".") { - // TODO: make this a htmx form validation - fail("No extension provided for filename.", nil) - return - } content := r.FormValue("content") if content == "" { @@ -375,11 +369,6 @@ func (s *Strings) create(w http.ResponseWriter, r *http.Request) { fail("Empty filename.", nil) return } - if !strings.Contains(filename, ".") { - // TODO: make this a htmx form validation - fail("No extension provided for filename.", nil) - return - } content := r.FormValue("content") if content == "" { -- 2.43.0