appview/pages: minor template fixes #538

merged

opened by

oppi.li 3 months ago targeting master from push-mvmrzuxwmzvs

these only worked because of a bug in loadAllTemplates. execute and executeRepo always had access to the repoBase layout. this is no longer the case.

Signed-off-by: oppiliappan me@oppi.li

options

unified split

Changed files

+2 -6

appview

pages

pages.go

templates

layouts

repobase.html

+2 -2

appview/pages/pages.go

···

       618
       618
        
       

     

       619
       619
        
       func (p *Pages) RepoTree(w io.Writer, params RepoTreeParams) error {

     

       620
       620
        
       	params.Active = "overview"

     

       621
       621
       -
       	return p.execute("repo/tree", w, params)

     

       621
       621
       +
       	return p.executeRepo("repo/tree", w, params)

     

       622
       622
        
       }

     

       623
       623
        
       

     

       624
       624
        
       type RepoBranchesParams struct {

     
···

       832
       832
        
       	} else {

     

       833
       833
        
       		params.State = "closed"

     

       834
       834
        
       	}

     

       835
       835
       -
       	return p.execute("repo/issues/issue", w, params)

     

       835
       835
       +
       	return p.executeRepo("repo/issues/issue", w, params)

     

       836
       836
        
       }

     

       837
       837
        
       

     

       838
       838
        
       type RepoNewIssueParams struct {

-4

appview/pages/templates/layouts/repobase.html

···

       88
       88
        
               {{ block "repoAfter" . }}{{ end }}

     

       89
       89
        
           </section>

     

       90
       90
        
       {{ end }}

     

       91
       91
       -
       

     

       92
       92
       -
       {{ define "layouts/repobase" }}

     

       93
       93
       -
           {{ template "layouts/base" . }}

     

       94
       94
       -
       {{ end }}