back round 1 view raw

appview/notify: move posthog notifier as subpackage #590

merged

opened by

anirudh.fi 2 months ago targeting master from push-xwotmtuuvokm

Also add NewIssueComment to the interface.

Signed-off-by: Anirudh Oppiliappan anirudh@tangled.sh

options

unified split

Changed files

+78 -6

appview

notify

merged_notifier.go

notifier.go

posthog

notifier.go

state

router.go

state.go

+11

appview/notify/merged_notifier.go

···

       38
       38
        
       		notifier.NewIssue(ctx, issue)

     

       39
       39
        
       	}

     

       40
       40
        
       }

     

       41
       41
       +
       func (m *mergedNotifier) NewIssueComment(ctx context.Context, comment *models.IssueComment) {

     

       42
       42
       +
       	for _, notifier := range m.notifiers {

     

       43
       43
       +
       		notifier.NewIssueComment(ctx, comment)

     

       44
       44
       +
       	}

     

       45
       45
       +
       }

     

       46
       46
       +
       

     

       47
       47
       +
       func (m *mergedNotifier) NewIssueClosed(ctx context.Context, issue *models.Issue) {

     

       48
       48
       +
       	for _, notifier := range m.notifiers {

     

       49
       49
       +
       		notifier.NewIssueClosed(ctx, issue)

     

       50
       50
       +
       	}

     

       51
       51
       +
       }

     

       41
       52
        
       

     

       42
       53
        
       func (m *mergedNotifier) NewFollow(ctx context.Context, follow *models.Follow) {

     

       43
       54
        
       	for _, notifier := range m.notifiers {

+5 -1

appview/notify/notifier.go

···

       13
       13
        
       	DeleteStar(ctx context.Context, star *models.Star)

     

       14
       14
        
       

     

       15
       15
        
       	NewIssue(ctx context.Context, issue *models.Issue)

     

       16
       16
       +
       	NewIssueComment(ctx context.Context, comment *models.IssueComment)

     

       17
       17
       +
       	NewIssueClosed(ctx context.Context, issue *models.Issue)

     

       16
       18
        
       

     

       17
       19
        
       	NewFollow(ctx context.Context, follow *models.Follow)

     

       18
       20
        
       	DeleteFollow(ctx context.Context, follow *models.Follow)

     
···

       37
       39
        
       func (m *BaseNotifier) NewStar(ctx context.Context, star *models.Star)    {}

     

       38
       40
        
       func (m *BaseNotifier) DeleteStar(ctx context.Context, star *models.Star) {}

     

       39
       41
        
       

     

       40
       40
       -
       func (m *BaseNotifier) NewIssue(ctx context.Context, issue *models.Issue) {}

     

       42
       42
       +
       func (m *BaseNotifier) NewIssue(ctx context.Context, issue *models.Issue)                 {}

     

       43
       43
       +
       func (m *BaseNotifier) NewIssueComment(ctx context.Context, comment *models.IssueComment) {}

     

       44
       44
       +
       func (m *BaseNotifier) NewIssueClosed(ctx context.Context, issue *models.Issue)           {}

     

       41
       45
        
       

     

       42
       46
        
       func (m *BaseNotifier) NewFollow(ctx context.Context, follow *models.Follow)    {}

     

       43
       47
        
       func (m *BaseNotifier) DeleteFollow(ctx context.Context, follow *models.Follow) {}

+58 -3

appview/posthog/notifier.go appview/notify/posthog/notifier.go

···

       1
       1
       -
       package posthog_service

     

       1
       1
       +
       package posthog

     

       2
       2
        
       

     

       3
       3
        
       import (

     

       4
       4
        
       	"context"

     
···

       98
       98
        
       	}

     

       99
       99
        
       }

     

       100
       100
        
       

     

       101
       101
       +
       func (n *posthogNotifier) NewPullClosed(ctx context.Context, pull *models.Pull) {

     

       102
       102
       +
       	err := n.client.Enqueue(posthog.Capture{

     

       103
       103
       +
       		DistinctId: pull.OwnerDid,

     

       104
       104
       +
       		Event:      "pull_closed",

     

       105
       105
       +
       		Properties: posthog.Properties{

     

       106
       106
       +
       			"repo_at": pull.RepoAt,

     

       107
       107
       +
       			"pull_id": pull.PullId,

     

       108
       108
       +
       		},

     

       109
       109
       +
       	})

     

       110
       110
       +
       	if err != nil {

     

       111
       111
       +
       		log.Println("failed to enqueue posthog event:", err)

     

       112
       112
       +
       	}

     

       113
       113
       +
       }

     

       114
       114
       +
       

     

       101
       115
        
       func (n *posthogNotifier) NewFollow(ctx context.Context, follow *models.Follow) {

     

       102
       116
        
       	err := n.client.Enqueue(posthog.Capture{

     

       103
       117
        
       		DistinctId: follow.UserDid,

     
···

       152
       166
        
       	}

     

       153
       167
        
       }

     

       154
       168
        
       

     

       155
       155
       -
       func (n *posthogNotifier) CreateString(ctx context.Context, string models.String) {

     

       169
       169
       +
       func (n *posthogNotifier) NewString(ctx context.Context, string *models.String) {

     

       156
       170
        
       	err := n.client.Enqueue(posthog.Capture{

     

       157
       171
        
       		DistinctId: string.Did.String(),

     

       158
       158
       -
       		Event:      "create_string",

     

       172
       172
       +
       		Event:      "new_string",

     

       159
       173
        
       		Properties: posthog.Properties{"rkey": string.Rkey},

     

       160
       174
        
       	})

     

       161
       175
        
       	if err != nil {

     

       162
       176
        
       		log.Println("failed to enqueue posthog event:", err)

     

       163
       177
        
       	}

     

       164
       178
        
       }

     

       179
       179
       +
       

     

       180
       180
       +
       func (n *posthogNotifier) NewIssueComment(ctx context.Context, comment *models.IssueComment) {

     

       181
       181
       +
       	err := n.client.Enqueue(posthog.Capture{

     

       182
       182
       +
       		DistinctId: comment.Did,

     

       183
       183
       +
       		Event:      "new_issue_comment",

     

       184
       184
       +
       		Properties: posthog.Properties{

     

       185
       185
       +
       			"issue_at": comment.IssueAt,

     

       186
       186
       +
       		},

     

       187
       187
       +
       	})

     

       188
       188
       +
       	if err != nil {

     

       189
       189
       +
       		log.Println("failed to enqueue posthog event:", err)

     

       190
       190
       +
       	}

     

       191
       191
       +
       }

     

       192
       192
       +
       

     

       193
       193
       +
       func (n *posthogNotifier) NewIssueClosed(ctx context.Context, issue *models.Issue) {

     

       194
       194
       +
       	err := n.client.Enqueue(posthog.Capture{

     

       195
       195
       +
       		DistinctId: issue.Did,

     

       196
       196
       +
       		Event:      "issue_closed",

     

       197
       197
       +
       		Properties: posthog.Properties{

     

       198
       198
       +
       			"repo_at":  issue.RepoAt.String(),

     

       199
       199
       +
       			"issue_id": issue.IssueId,

     

       200
       200
       +
       		},

     

       201
       201
       +
       	})

     

       202
       202
       +
       	if err != nil {

     

       203
       203
       +
       		log.Println("failed to enqueue posthog event:", err)

     

       204
       204
       +
       	}

     

       205
       205
       +
       }

     

       206
       206
       +
       

     

       207
       207
       +
       func (n *posthogNotifier) NewPullMerged(ctx context.Context, pull *models.Pull) {

     

       208
       208
       +
       	err := n.client.Enqueue(posthog.Capture{

     

       209
       209
       +
       		DistinctId: pull.OwnerDid,

     

       210
       210
       +
       		Event:      "pull_merged",

     

       211
       211
       +
       		Properties: posthog.Properties{

     

       212
       212
       +
       			"repo_at": pull.RepoAt,

     

       213
       213
       +
       			"pull_id": pull.PullId,

     

       214
       214
       +
       		},

     

       215
       215
       +
       	})

     

       216
       216
       +
       	if err != nil {

     

       217
       217
       +
       		log.Println("failed to enqueue posthog event:", err)

     

       218
       218
       +
       	}

     

       219
       219
       +
       }

appview/state/router.go

···

       156
       156
        
       	r.Mount("/strings", s.StringsRouter(mw))

     

       157
       157
        
       	r.Mount("/knots", s.KnotsRouter())

     

       158
       158
        
       	r.Mount("/spindles", s.SpindlesRouter())

     

       159
       159
       +
       	r.Mount("/notifications", s.NotificationsRouter(mw))

     

       160
       160
       +
       

     

       159
       161
        
       	r.Mount("/signup", s.SignupRouter())

     

       160
       162
        
       	r.Mount("/", s.OAuthRouter())

     

       161
       163

+2 -2

appview/state/state.go

···

       25
       25
        
       	"tangled.org/core/appview/db"

     

       26
       26
        
       	"tangled.org/core/appview/models"

     

       27
       27
        
       	"tangled.org/core/appview/notify"

     

       28
       28
       +
       	phnotify "tangled.org/core/appview/notify/posthog"

     

       28
       29
        
       	"tangled.org/core/appview/oauth"

     

       29
       30
        
       	"tangled.org/core/appview/pages"

     

       30
       30
       -
       	posthogService "tangled.org/core/appview/posthog"

     

       31
       31
        
       	"tangled.org/core/appview/reporesolver"

     

       32
       32
        
       	"tangled.org/core/appview/validator"

     

       33
       33
        
       	xrpcclient "tangled.org/core/appview/xrpcclient"

     
···

       149
       149
        
       

     

       150
       150
        
       	var notifiers []notify.Notifier

     

       151
       151
        
       	if !config.Core.Dev {

     

       152
       152
       -
       		notifiers = append(notifiers, posthogService.NewPosthogNotifier(posthog))

     

       152
       152
       +
       		notifiers = append(notifiers, phnotify.NewPosthogNotifier(posthog))

     

       153
       153
        
       	}

     

       154
       154
        
       	notifier := notify.NewMergedNotifier(notifiers...)

     

       155
       155