patch of appview/{pulls,issues}: more notifications · round #0 · pull #593 · tangled.org/core

+8

appview/issues/issues.go

···

       301
       301
        
       			return

     

       302
       302
        
       		}

     

       303
       303
        
       

     

       304
       304
       +
       		// notify about the issue closure

     

       305
       305
       +
       		rp.notifier.NewIssueClosed(r.Context(), issue)

     

       306
       306
       +
       

     

       304
       307
        
       		rp.pages.HxLocation(w, fmt.Sprintf("/%s/issues/%d", f.OwnerSlashRepo(), issue.IssueId))

     

       305
       308
        
       		return

     

       306
       309
        
       	} else {

     
···

       434
       437
        
       

     

       435
       438
        
       	// reset atUri to make rollback a no-op

     

       436
       439
        
       	atUri = ""

     

       440
       440
       +
       

     

       441
       441
       +
       	// notify about the new comment

     

       442
       442
       +
       	comment.Id = commentId

     

       443
       443
       +
       	rp.notifier.NewIssueComment(r.Context(), &comment)

     

       444
       444
       +
       

     

       437
       445
        
       	rp.pages.HxLocation(w, fmt.Sprintf("/%s/issues/%d#comment-%d", f.OwnerSlashRepo(), issue.IssueId, commentId))

     

       438
       446
        
       }

     

       439
       447

+12

appview/notify/merged_notifier.go

···

       72
       72
        
       	}

     

       73
       73
        
       }

     

       74
       74
        
       

     

       75
       75
       +
       func (m *mergedNotifier) NewPullMerged(ctx context.Context, pull *models.Pull) {

     

       76
       76
       +
       	for _, notifier := range m.notifiers {

     

       77
       77
       +
       		notifier.NewPullMerged(ctx, pull)

     

       78
       78
       +
       	}

     

       79
       79
       +
       }

     

       80
       80
       +
       

     

       81
       81
       +
       func (m *mergedNotifier) NewPullClosed(ctx context.Context, pull *models.Pull) {

     

       82
       82
       +
       	for _, notifier := range m.notifiers {

     

       83
       83
       +
       		notifier.NewPullClosed(ctx, pull)

     

       84
       84
       +
       	}

     

       85
       85
       +
       }

     

       86
       86
       +
       

     

       75
       87
        
       func (m *mergedNotifier) UpdateProfile(ctx context.Context, profile *models.Profile) {

     

       76
       88
        
       	for _, notifier := range m.notifiers {

     

       77
       89
        
       		notifier.UpdateProfile(ctx, profile)

+4

appview/notify/notifier.go

···

       21
       21
        
       

     

       22
       22
        
       	NewPull(ctx context.Context, pull *models.Pull)

     

       23
       23
        
       	NewPullComment(ctx context.Context, comment *models.PullComment)

     

       24
       24
       +
       	NewPullMerged(ctx context.Context, pull *models.Pull)

     

       25
       25
       +
       	NewPullClosed(ctx context.Context, pull *models.Pull)

     

       24
       26
        
       

     

       25
       27
        
       	UpdateProfile(ctx context.Context, profile *models.Profile)

     

       26
       28
        
       

     
···

       48
       50
        
       

     

       49
       51
        
       func (m *BaseNotifier) NewPull(ctx context.Context, pull *models.Pull)                 {}

     

       50
       52
        
       func (m *BaseNotifier) NewPullComment(ctx context.Context, models *models.PullComment) {}

     

       53
       53
       +
       func (m *BaseNotifier) NewPullMerged(ctx context.Context, pull *models.Pull)           {}

     

       54
       54
       +
       func (m *BaseNotifier) NewPullClosed(ctx context.Context, pull *models.Pull)           {}

     

       51
       55
        
       

     

       52
       56
        
       func (m *BaseNotifier) UpdateProfile(ctx context.Context, profile *models.Profile) {}

     

       53
       57

+9

appview/pulls/pulls.go

···

       2147
       2147
        
       		return

     

       2148
       2148
        
       	}

     

       2149
       2149
        
       

     

       2150
       2150
       +
       	// notify about the pull merge

     

       2151
       2151
       +
       	for _, p := range pullsToMerge {

     

       2152
       2152
       +
       		s.notifier.NewPullMerged(r.Context(), p)

     

       2153
       2153
       +
       	}

     

       2154
       2154
       +
       

     

       2150
       2155
        
       	s.pages.HxLocation(w, fmt.Sprintf("/@%s/%s/pulls/%d", f.OwnerHandle(), f.Name, pull.PullId))

     

       2151
       2156
        
       }

     

       2152
       2157
        
       

     
···

       2214
       2219
        
       		return

     

       2215
       2220
        
       	}

     

       2216
       2221
        
       

     

       2222
       2222
       +
       	for _, p := range pullsToClose {

     

       2223
       2223
       +
       		s.notifier.NewPullClosed(r.Context(), p)

     

       2224
       2224
       +
       	}

     

       2225
       2225
       +
       

     

       2217
       2226
        
       	s.pages.HxLocation(w, fmt.Sprintf("/%s/pulls/%d", f.OwnerSlashRepo(), pull.PullId))

     

       2218
       2227
        
       }

     

       2219
       2228