appview: do not require auth for upgrade banner #599

merged

opened by

oppi.li 2 months ago targeting master from push-rurrtsvmnvku

the upgrade banner is left empty if the user's session is expired. this prevents them from randomly being booted to the login page.

Signed-off-by: oppiliappan me@oppi.li

options

unified split

Changed files

+5 -1

appview

state

router.go

state.go

+1 -1

appview/state/router.go

···

       116
       116
        
       

     

       117
       117
        
       	r.Get("/", s.HomeOrTimeline)

     

       118
       118
        
       	r.Get("/timeline", s.Timeline)

     

       119
       119
       -
       	r.With(middleware.AuthMiddleware(s.oauth)).Get("/upgradeBanner", s.UpgradeBanner)

     

       119
       119
       +
       	r.Get("/upgradeBanner", s.UpgradeBanner)

     

       120
       120
        
       

     

       121
       121
        
       	// special-case handler for serving tangled.org/core

     

       122
       122
        
       	r.Get("/core", s.Core())

appview/state/state.go

···

       249
       249
        
       

     

       250
       250
        
       func (s *State) UpgradeBanner(w http.ResponseWriter, r *http.Request) {

     

       251
       251
        
       	user := s.oauth.GetUser(r)

     

       252
       252
       +
       	if user == nil {

     

       253
       253
       +
       		return

     

       254
       254
       +
       	}

     

       255
       255
       +
       

     

       252
       256
        
       	l := s.logger.With("handler", "UpgradeBanner")

     

       253
       257
        
       	l = l.With("did", user.Did)

     

       254
       258
        
       	l = l.With("handle", user.Handle)