appview/middleware: indiscriminately try to refresh the session #600

merged

opened by

oppi.li 2 months ago targeting master from push-rurrtsvmnvku

previously, we would only refresh sessions when authenticated requests took place. the new middleware attempts a refresh for every request, if expiry is approaching (<5m). this way, user sessions remain refreshing by simply hanging out on tangled.

Signed-off-by: oppiliappan me@oppi.li

options

unified split

Changed files

+14

appview

middleware

middleware.go

state

router.go

+13

appview/middleware/middleware.go

···

       43
       43
        
       

     

       44
       44
        
       type middlewareFunc func(http.Handler) http.Handler

     

       45
       45
        
       

     

       46
       46
       +
       func (mw *Middleware) TryRefreshSession() middlewareFunc {

     

       47
       47
       +
       	return func(next http.Handler) http.Handler {

     

       48
       48
       +
       		return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {

     

       49
       49
       +
       			_, auth, err := mw.oauth.GetSession(r)

     

       50
       50
       +
       			if err != nil {

     

       51
       51
       +
       				log.Println("could not refresh session", "err", err, "auth", auth)

     

       52
       52
       +
       			}

     

       53
       53
       +
       

     

       54
       54
       +
       			next.ServeHTTP(w, r)

     

       55
       55
       +
       		})

     

       56
       56
       +
       	}

     

       57
       57
       +
       }

     

       58
       58
       +
       

     

       46
       59
        
       func AuthMiddleware(a *oauth.OAuth) middlewareFunc {

     

       47
       60
        
       	return func(next http.Handler) http.Handler {

     

       48
       61
        
       		return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {

appview/state/router.go

···

       34
       34
        
       		s.pages,

     

       35
       35
        
       	)

     

       36
       36
        
       

     

       37
       37
       +
       	router.Use(middleware.TryRefreshSession())

     

       37
       38
        
       	router.Get("/favicon.svg", s.Favicon)

     

       38
       39
        
       	router.Get("/favicon.ico", s.Favicon)

     

       39
       40