From e4807d280fa53e047a0d471b2816373aabb68af2 Mon Sep 17 00:00:00 2001 From: oppiliappan Date: Fri, 26 Sep 2025 12:04:42 +0100 Subject: [PATCH] appview/labels: reduce the opset after validation Change-Id: plpuqtyrprourryynxykvkrqyzzuvlvu validation also performs a transformation upon labels: it resolves handles to DIDs, it is important that this transform be present when determining redundant ops. Signed-off-by: oppiliappan --- appview/labels/labels.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/appview/labels/labels.go b/appview/labels/labels.go index ecd304b4..8d1a7ccb 100644 --- a/appview/labels/labels.go +++ b/appview/labels/labels.go @@ -152,9 +152,6 @@ func (l *Labels) PerformLabelOp(w http.ResponseWriter, r *http.Request) { } } - // reduce the opset - labelOps = models.ReduceLabelOps(labelOps) - for i := range labelOps { def := actx.Defs[labelOps[i].OperandKey] if err := l.validator.ValidateLabelOp(def, &labelOps[i]); err != nil { @@ -163,6 +160,9 @@ func (l *Labels) PerformLabelOp(w http.ResponseWriter, r *http.Request) { } } + // reduce the opset + labelOps = models.ReduceLabelOps(labelOps) + // next, apply all ops introduced in this request and filter out ones that are no-ops validLabelOps := labelOps[:0] for _, op := range labelOps { -- 2.43.0