Monorepo for Tangled — https://tangled.org

appview/pages: header and footer occupy full page width #622

As discussed on Discord, the header and footer now take up full width. I went with the version where the content is still capped at 1024px, like the main content.

The changes are purely CSS, except for an extra div around the main content. This is needed because the grid no longer adds a minimum height to the main content, which means the footer will not be pushed to the bottom on pages with little main content. So now instead the header, content and footer are in a flex column, and the content flex-grow’s to make sure it’s at least taking up the remaining viewport space.

A few redundant classes have been removed, e.g. grid properties on elements that were not grid-items. I also removed (unused/invisible) border radius and drop-shadow from the header and footer.

I tried best possible to check the layout across the different views. There does not currently seem to be any specific UI test suite or similar - let me know if I missed it.

Normally I would add screenshots to a PR like this, but this does not seem supported currently. I can share over Discord if you’re interested.

0
by jensroemer.com 2 comments
expand 2 commits
Remove redundant grid item properties in layouts/base
Header and footer background is full page width

I signed off on the commits, but I see other PR's also are signed-off in the description. I would've wanted to edit the description, but doesn't look like I can :-) Let me know if/how I should change, it it's needed.

the sign-off in commit messages is what is necessary, that looks alright!

sign up or login to add to the discussion
expand 19 commits
appview/signup: set up cf turnstile
appview/pages: center captcha in signup page
appview: associate users to commits by did
appview/repo: add an option to choose the name of the forked repo
appview/db: refactor GetPulls
appview/pages: add labels to pulls
appview/notifications: code cleanup for notifier
appview/pages: improve notification styles
appview/notifications: fix pagination
appview/notifications: add link element to each notification
appview/db: populate pull-source in GetPulls
knotserver: bump version to 1.9.1-alpha
appview/pages: fix brand link
appview/db: handle nils
appview/pages: Update .sh to .org in ssh clone dropdown
docs/spindle: fix grammar
knotserver/config: fix default appview endpoint
Remove redundant grid item properties in layouts/base
Header and footer background is full page width
sign up or login to add to the discussion
expand 20 commits
appview/signup: set up cf turnstile
appview/pages: center captcha in signup page
appview: associate users to commits by did
appview/repo: add an option to choose the name of the forked repo
appview/db: refactor GetPulls
appview/pages: add labels to pulls
appview/notifications: code cleanup for notifier
appview/pages: improve notification styles
appview/notifications: fix pagination
appview/notifications: add link element to each notification
appview/db: populate pull-source in GetPulls
knotserver: bump version to 1.9.1-alpha
appview/pages: fix brand link
appview/db: handle nils
appview/pages: Update .sh to .org in ssh clone dropdown
docs/spindle: fix grammar
knotserver/config: fix default appview endpoint
appview/state,appview/pages/templates: add installable pwa support for tangled
Remove redundant grid item properties in layouts/base
Header and footer background is full page width
closed without merging
sign up or login to add to the discussion
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:laqygfbyvnkyuhsuaxmp6ez3/sh.tangled.repo.pull/3m23esdehyg22