As discussed on Discord, the header and footer now take up full width. I went with the version where the content is still capped at 1024px, like the main content. The changes are purely CSS, except for an extra div around the main content. This is needed because the grid no longer adds a minimum height to the main content, which means the footer will not be pushed to the bottom on pages with little main content. So now instead the header, content and footer are in a flex column, and the content flex-grow’s to make sure it’s at least taking up the remaining viewport space. A few redundant classes have been removed, e.g. grid properties on elements that were not grid-items. I also removed (unused/invisible) border radius and drop-shadow from the header and footer. I tried best possible to check the layout across the different views. There does not currently seem to be any specific UI test suite or similar - let me know if I missed it. Normally I would add screenshots to a PR like this, but this does not seem supported currently. I can share over Discord if you’re interested.
appview/pages: header and footer occupy full page width #632
expand 2 commits
hide 2 commits
Signed-off-by: Jens Rømer Hesselbjerg <jh.roemer@gmail.com>
Signed-off-by: Jens Rømer Hesselbjerg <jh.roemer@gmail.com>
Yes! I just did. How is it again, I need to resubmit, right?
expand 19 commits
hide 19 commits
Sets up Cloudflare Turnstile for fairly non-intrusive captcha. The
client token is verified with CF when the user hits 'join now' (POST
/signup), so this should prevent bot signups.
Signed-off-by: Anirudh Oppiliappan <anirudh@tangled.org>
Signed-off-by: oppiliappan <me@oppi.li>
Enables commit verification for users using a DID in place of an email
address.
<https://tangled.org/@tangled.org/core/issues/218>
Signed-off-by: tjh <did:plc:65gha4t3avpfpzmvpbwovss7>
Given that repo names cannot be changed later, this gives the
freedom to choose the name and still stay in the fork network.
Signed-off-by: Vidya Sagar VOBBILISETTI <mail@vidyasagarv.com>
instead of using a massive left join, it now uses a few FilterIns. we
can also get rid of the GetPull helper, it is a specialization of
GetPulls that returns a single pull request.
Signed-off-by: oppiliappan <me@oppi.li>
Signed-off-by: oppiliappan <me@oppi.li>
GetRepo is a specialization for GetRepos which is to be used when the
filters are primary keys.
Signed-off-by: oppiliappan <me@oppi.li>
Signed-off-by: oppiliappan <me@oppi.li>
Signed-off-by: oppiliappan <me@oppi.li>
Signed-off-by: oppiliappan <me@oppi.li>
Signed-off-by: oppiliappan <me@oppi.li>
Signed-off-by: Anirudh Oppiliappan <anirudh@tangled.org>
Signed-off-by: oppiliappan <me@oppi.li>
Signed-off-by: Vidya Sagar VOBBILISETTI <mail@vidyasagarv.com>
Signed-off-by: Tangled <noreply@tangled.sh>
tangled.sh has been moved to tangled.org
Signed-off-by: Samuel Shuert <me@thecoded.prof>
Signed-off-by: afterlifepro <vielle.dev@proton.me>
Signed-off-by: Jens Rømer Hesselbjerg <jh.roemer@gmail.com>
One last thing! Can the commits here be squashed + reauthored with the message "appview/pages: header and footer occupy full page width"? Should be good to go otherwise!