back round 1 view raw

appview/timeline: backend only changes that allows filtereing the timeline based on who the user is following #639

merged

opened by

willdot.net 2 months ago targeting master from willdot.net/tangled-core: feat/be-timeline-filter

This adds in just the backend changes required for filtering a users timeline based on the users that they follow.

options

unified split

Changed files

+46 -12

appview

timeline.go

state

state.go

+38 -10

appview/db/timeline.go

···

       9
       9
        
       

     

       10
       10
        
       // TODO: this gathers heterogenous events from different sources and aggregates

     

       11
       11
        
       // them in code; if we did this entirely in sql, we could order and limit and paginate easily

     

       12
       12
       -
       func MakeTimeline(e Execer, limit int, loggedInUserDid string) ([]models.TimelineEvent, error) {

     

       12
       12
       +
       func MakeTimeline(e Execer, limit int, loggedInUserDid string, limitToUsersIsFollowing bool) ([]models.TimelineEvent, error) {

     

       13
       13
        
       	var events []models.TimelineEvent

     

       14
       14
        
       

     

       15
       15
       -
       	repos, err := getTimelineRepos(e, limit, loggedInUserDid)

     

       15
       15
       +
       	var userIsFollowing []string

     

       16
       16
       +
       	if limitToUsersIsFollowing {

     

       17
       17
       +
       		following, err := GetFollowing(e, loggedInUserDid)

     

       18
       18
       +
       		if err != nil {

     

       19
       19
       +
       			return nil, err

     

       20
       20
       +
       		}

     

       21
       21
       +
       

     

       22
       22
       +
       		userIsFollowing = make([]string, 0, len(following))

     

       23
       23
       +
       		for _, follow := range following {

     

       24
       24
       +
       			userIsFollowing = append(userIsFollowing, follow.SubjectDid)

     

       25
       25
       +
       		}

     

       26
       26
       +
       	}

     

       27
       27
       +
       

     

       28
       28
       +
       	repos, err := getTimelineRepos(e, limit, loggedInUserDid, userIsFollowing)

     

       16
       29
        
       	if err != nil {

     

       17
       30
        
       		return nil, err

     

       18
       31
        
       	}

     

       19
       32
        
       

     

       20
       20
       -
       	stars, err := getTimelineStars(e, limit, loggedInUserDid)

     

       33
       33
       +
       	stars, err := getTimelineStars(e, limit, loggedInUserDid, userIsFollowing)

     

       21
       34
        
       	if err != nil {

     

       22
       35
        
       		return nil, err

     

       23
       36
        
       	}

     

       24
       37
        
       

     

       25
       25
       -
       	follows, err := getTimelineFollows(e, limit, loggedInUserDid)

     

       38
       38
       +
       	follows, err := getTimelineFollows(e, limit, loggedInUserDid, userIsFollowing)

     

       26
       39
        
       	if err != nil {

     

       27
       40
        
       		return nil, err

     

       28
       41
        
       	}

     
···

       70
       83
        
       	return isStarred, starCount

     

       71
       84
        
       }

     

       72
       85
        
       

     

       73
       73
       -
       func getTimelineRepos(e Execer, limit int, loggedInUserDid string) ([]models.TimelineEvent, error) {

     

       74
       74
       -
       	repos, err := GetRepos(e, limit)

     

       86
       86
       +
       func getTimelineRepos(e Execer, limit int, loggedInUserDid string, userIsFollowing []string) ([]models.TimelineEvent, error) {

     

       87
       87
       +
       	filters := make([]filter, 0)

     

       88
       88
       +
       	if userIsFollowing != nil {

     

       89
       89
       +
       		filters = append(filters, FilterIn("did", userIsFollowing))

     

       90
       90
       +
       	}

     

       91
       91
       +
       

     

       92
       92
       +
       	repos, err := GetRepos(e, limit, filters...)

     

       75
       93
        
       	if err != nil {

     

       76
       94
        
       		return nil, err

     

       77
       95
        
       	}

     
···

       125
       143
        
       	return events, nil

     

       126
       144
        
       }

     

       127
       145
        
       

     

       128
       128
       -
       func getTimelineStars(e Execer, limit int, loggedInUserDid string) ([]models.TimelineEvent, error) {

     

       129
       129
       -
       	stars, err := GetStars(e, limit)

     

       146
       146
       +
       func getTimelineStars(e Execer, limit int, loggedInUserDid string, userIsFollowing []string) ([]models.TimelineEvent, error) {

     

       147
       147
       +
       	filters := make([]filter, 0)

     

       148
       148
       +
       	if userIsFollowing != nil {

     

       149
       149
       +
       		filters = append(filters, FilterIn("starred_by_did", userIsFollowing))

     

       150
       150
       +
       	}

     

       151
       151
       +
       

     

       152
       152
       +
       	stars, err := GetStars(e, limit, filters...)

     

       130
       153
        
       	if err != nil {

     

       131
       154
        
       		return nil, err

     

       132
       155
        
       	}

     
···

       166
       189
        
       	return events, nil

     

       167
       190
        
       }

     

       168
       191
        
       

     

       169
       169
       -
       func getTimelineFollows(e Execer, limit int, loggedInUserDid string) ([]models.TimelineEvent, error) {

     

       170
       170
       -
       	follows, err := GetFollows(e, limit)

     

       192
       192
       +
       func getTimelineFollows(e Execer, limit int, loggedInUserDid string, userIsFollowing []string) ([]models.TimelineEvent, error) {

     

       193
       193
       +
       	filters := make([]filter, 0)

     

       194
       194
       +
       	if userIsFollowing != nil {

     

       195
       195
       +
       		filters = append(filters, FilterIn("user_did", userIsFollowing))

     

       196
       196
       +
       	}

     

       197
       197
       +
       

     

       198
       198
       +
       	follows, err := GetFollows(e, limit, filters...)

     

       171
       199
        
       	if err != nil {

     

       172
       200
        
       		return nil, err

     

       173
       201
        
       	}

+8 -2

appview/state/state.go

···

       258
       258
        
       func (s *State) Timeline(w http.ResponseWriter, r *http.Request) {

     

       259
       259
        
       	user := s.oauth.GetUser(r)

     

       260
       260
        
       

     

       261
       261
       +
       	// TODO: set this flag based on the UI

     

       262
       262
       +
       	filtered := false

     

       263
       263
       +
       

     

       261
       264
        
       	var userDid string

     

       262
       265
        
       	if user != nil {

     

       263
       266
        
       		userDid = user.Did

     

       264
       267
        
       	}

     

       265
       265
       -
       	timeline, err := db.MakeTimeline(s.db, 50, userDid)

     

       268
       268
       +
       	timeline, err := db.MakeTimeline(s.db, 50, userDid, filtered)

     

       266
       269
        
       	if err != nil {

     

       267
       270
        
       		log.Println(err)

     

       268
       271
        
       		s.pages.Notice(w, "timeline", "Uh oh! Failed to load timeline.")

     
···

       326
       329
        
       }

     

       327
       330
        
       

     

       328
       331
        
       func (s *State) Home(w http.ResponseWriter, r *http.Request) {

     

       329
       329
       -
       	timeline, err := db.MakeTimeline(s.db, 5, "")

     

       332
       332
       +
       	// TODO: set this flag based on the UI

     

       333
       333
       +
       	filtered := false

     

       334
       334
       +
       

     

       335
       335
       +
       	timeline, err := db.MakeTimeline(s.db, 5, "", filtered)

     

       330
       336
        
       	if err != nil {

     

       331
       337
        
       		log.Println(err)

     

       332
       338
        
       		s.pages.Notice(w, "timeline", "Uh oh! Failed to load timeline.")