From 4dba1f131623dd2909ad2abaa73ec30fcad26da2 Mon Sep 17 00:00:00 2001
From: oppiliappan <me@oppi.li>
Date: Tue, 14 Oct 2025 14:46:13 +0100
Subject: [PATCH] appview: remove `@` from URLs and interface
Change-Id: ytvszwnnmymowwszkklxxxvnzqsykowk

old URLs that refer to users with the `@` are redirected to the version
without `@`. the leading motivation for this change is that valid
atproto handles do not contain the prefix. it is purely stylistic.

Signed-off-by: oppiliappan <me@oppi.li>
---
 appview/middleware/middleware.go              |  4 +-
 appview/pages/funcmap.go                      |  7 +--
 appview/pages/repoinfo/repoinfo.go            | 12 ++---
 appview/pages/templates/layouts/repobase.html |  4 +-
 .../repo/fragments/cloneDropdown.html         |  4 +-
 appview/state/router.go                       | 50 ++++++++++---------
 appview/state/state.go                        |  5 +-
 appview/state/userutil/userutil.go            | 12 ++---
 8 files changed, 50 insertions(+), 48 deletions(-)

diff --git a/appview/middleware/middleware.go b/appview/middleware/middleware.go
index 2d7366ab..0393a8c4 100644
--- a/appview/middleware/middleware.go
+++ b/appview/middleware/middleware.go
@@ -180,13 +180,13 @@ func (mw Middleware) ResolveIdent() middlewareFunc {
 	return func(next http.Handler) http.Handler {
 		return http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) {
 			didOrHandle := chi.URLParam(req, "user")
+			didOrHandle = strings.TrimPrefix(didOrHandle, "@")
+
 			if slices.Contains(excluded, didOrHandle) {
 				next.ServeHTTP(w, req)
 				return
 			}
 
-			didOrHandle = strings.TrimPrefix(didOrHandle, "@")
-
 			id, err := mw.idResolver.ResolveIdent(req.Context(), didOrHandle)
 			if err != nil {
 				// invalid did or handle
diff --git a/appview/pages/funcmap.go b/appview/pages/funcmap.go
index 0ccb070f..5929a56f 100644
--- a/appview/pages/funcmap.go
+++ b/appview/pages/funcmap.go
@@ -17,6 +17,7 @@ import (
 	"strings"
 	"time"
 
+	"github.com/bluesky-social/indigo/atproto/syntax"
 	"github.com/dustin/go-humanize"
 	"github.com/go-enry/go-enry/v2"
 	"tangled.org/core/appview/filetree"
@@ -57,7 +58,7 @@ func (p *Pages) funcMap() template.FuncMap {
 				return "handle.invalid"
 			}
 
-			return "@" + identity.Handle.String()
+			return identity.Handle.String()
 		},
 		"truncateAt30": func(s string) string {
 			if len(s) <= 30 {
@@ -117,8 +118,8 @@ func (p *Pages) funcMap() template.FuncMap {
 			return b
 		},
 		"didOrHandle": func(did, handle string) string {
-			if handle != "" {
-				return fmt.Sprintf("@%s", handle)
+			if handle != "" && handle != syntax.HandleInvalid.String() {
+				return handle
 			} else {
 				return did
 			}
diff --git a/appview/pages/repoinfo/repoinfo.go b/appview/pages/repoinfo/repoinfo.go
index eeb99b6b..2d4550ec 100644
--- a/appview/pages/repoinfo/repoinfo.go
+++ b/appview/pages/repoinfo/repoinfo.go
@@ -1,31 +1,29 @@
 package repoinfo
 
 import (
-	"fmt"
 	"path"
 	"slices"
-	"strings"
 
 	"github.com/bluesky-social/indigo/atproto/syntax"
 	"tangled.org/core/appview/models"
 	"tangled.org/core/appview/state/userutil"
 )
 
-func (r RepoInfo) OwnerWithAt() string {
+func (r RepoInfo) Owner() string {
 	if r.OwnerHandle != "" {
-		return fmt.Sprintf("@%s", r.OwnerHandle)
+		return r.OwnerHandle
 	} else {
 		return r.OwnerDid
 	}
 }
 
 func (r RepoInfo) FullName() string {
-	return path.Join(r.OwnerWithAt(), r.Name)
+	return path.Join(r.Owner(), r.Name)
 }
 
 func (r RepoInfo) OwnerWithoutAt() string {
-	if after, ok := strings.CutPrefix(r.OwnerWithAt(), "@"); ok {
-		return after
+	if r.OwnerHandle != "" {
+		return r.OwnerHandle
 	} else {
 		return userutil.FlattenDid(r.OwnerDid)
 	}
diff --git a/appview/pages/templates/layouts/repobase.html b/appview/pages/templates/layouts/repobase.html
index 056c64a6..3299d60c 100644
--- a/appview/pages/templates/layouts/repobase.html
+++ b/appview/pages/templates/layouts/repobase.html
@@ -13,8 +13,8 @@
       </p>
       {{ end }}
       <div class="text-lg flex items-center justify-between">
-        <div>
-          <a href="/{{ .RepoInfo.OwnerWithAt }}">{{ .RepoInfo.OwnerWithAt }}</a>
+        <div class="flex items-center gap-2 flex-wrap">
+          {{ template "user/fragments/picHandleLink" .RepoInfo.OwnerDid }}
           <span class="select-none">/</span>
           <a href="/{{ .RepoInfo.FullName }}" class="font-bold">{{ .RepoInfo.Name }}</a>
         </div>
diff --git a/appview/pages/templates/repo/fragments/cloneDropdown.html b/appview/pages/templates/repo/fragments/cloneDropdown.html
index 708f12af..24e1ab31 100644
--- a/appview/pages/templates/repo/fragments/cloneDropdown.html
+++ b/appview/pages/templates/repo/fragments/cloneDropdown.html
@@ -29,8 +29,8 @@
                         <code
                             class="flex-1 px-3 py-2 text-sm bg-gray-50 dark:bg-gray-700 text-gray-900 dark:text-gray-100 rounded-l select-all cursor-pointer whitespace-nowrap overflow-x-auto"
                             onclick="window.getSelection().selectAllChildren(this)"
-                            data-url="https://tangled.org/{{ .RepoInfo.OwnerWithAt }}/{{ .RepoInfo.Name }}"
-                        >https://tangled.org/{{ .RepoInfo.OwnerWithAt }}/{{ .RepoInfo.Name }}</code>
+                            data-url="https://tangled.org/{{ resolve .RepoInfo.OwnerDid }}/{{ .RepoInfo.Name }}"
+                        >https://tangled.org/{{ resolve .RepoInfo.OwnerDid }}/{{ .RepoInfo.Name }}</code>
                         <button
                             onclick="copyToClipboard(this, this.previousElementSibling.getAttribute('data-url'))"
                             class="px-3 py-2 text-gray-500 hover:text-gray-700 dark:text-gray-400 dark:hover:text-gray-200 border-l border-gray-300 dark:border-gray-600"
diff --git a/appview/state/router.go b/appview/state/router.go
index ef44896d..667ce3e6 100644
--- a/appview/state/router.go
+++ b/appview/state/router.go
@@ -42,32 +42,34 @@ func (s *State) Router() http.Handler {
 
 	router.HandleFunc("/*", func(w http.ResponseWriter, r *http.Request) {
 		pat := chi.URLParam(r, "*")
-		if strings.HasPrefix(pat, "did:") || strings.HasPrefix(pat, "@") {
-			userRouter.ServeHTTP(w, r)
-		} else {
-			// Check if the first path element is a valid handle without '@' or a flattened DID
-			pathParts := strings.SplitN(pat, "/", 2)
-			if len(pathParts) > 0 {
-				if userutil.IsHandleNoAt(pathParts[0]) {
-					// Redirect to the same path but with '@' prefixed to the handle
-					redirectPath := "@" + pat
-					http.Redirect(w, r, "/"+redirectPath, http.StatusFound)
-					return
-				} else if userutil.IsFlattenedDid(pathParts[0]) {
-					// Redirect to the unflattened DID version
-					unflattenedDid := userutil.UnflattenDid(pathParts[0])
-					var redirectPath string
-					if len(pathParts) > 1 {
-						redirectPath = unflattenedDid + "/" + pathParts[1]
-					} else {
-						redirectPath = unflattenedDid
-					}
-					http.Redirect(w, r, "/"+redirectPath, http.StatusFound)
-					return
-				}
+		pathParts := strings.SplitN(pat, "/", 2)
+
+		if len(pathParts) > 0 {
+			firstPart := pathParts[0]
+
+			// if using a DID or handle, just continue as per usual
+			if userutil.IsDid(firstPart) || userutil.IsHandle(firstPart) {
+				userRouter.ServeHTTP(w, r)
+				return
+			}
+
+			// if using a flattened DID (like you would in go modules), unflatten
+			if userutil.IsFlattenedDid(firstPart) {
+				unflattenedDid := userutil.UnflattenDid(firstPart)
+				redirectPath := strings.Join(append([]string{unflattenedDid}, pathParts[1:]...), "/")
+				http.Redirect(w, r, "/"+redirectPath, http.StatusFound)
+				return
+			}
+
+			// if using a handle with @, rewrite to work without @
+			if normalized := strings.TrimPrefix(firstPart, "@"); userutil.IsHandle(normalized) {
+				redirectPath := strings.Join(append([]string{normalized}, pathParts[1:]...), "/")
+				http.Redirect(w, r, "/"+redirectPath, http.StatusFound)
+				return
 			}
-			standardRouter.ServeHTTP(w, r)
 		}
+
+		standardRouter.ServeHTTP(w, r)
 	})
 
 	return router
diff --git a/appview/state/state.go b/appview/state/state.go
index 78c4fbbd..3120de22 100644
--- a/appview/state/state.go
+++ b/appview/state/state.go
@@ -376,12 +376,13 @@ func (s *State) Keys(w http.ResponseWriter, r *http.Request) {
 
 	pubKeys, err := db.GetPublicKeysForDid(s.db, id.DID.String())
 	if err != nil {
-		w.WriteHeader(http.StatusNotFound)
+		s.logger.Error("failed to get public keys", "err", err)
+		http.Error(w, "failed to get public keys", http.StatusInternalServerError)
 		return
 	}
 
 	if len(pubKeys) == 0 {
-		w.WriteHeader(http.StatusNotFound)
+		w.WriteHeader(http.StatusNoContent)
 		return
 	}
 
diff --git a/appview/state/userutil/userutil.go b/appview/state/userutil/userutil.go
index 9097309a..dfc69dcc 100644
--- a/appview/state/userutil/userutil.go
+++ b/appview/state/userutil/userutil.go
@@ -10,11 +10,16 @@ var (
 	didRegex    = regexp.MustCompile(`^did:[a-z]+:[a-zA-Z0-9._:%-]*[a-zA-Z0-9._-]$`)
 )
 
-func IsHandleNoAt(s string) bool {
+func IsHandle(s string) bool {
 	// ref: https://atproto.com/specs/handle
 	return handleRegex.MatchString(s)
 }
 
+// IsDid checks if the given string is a standard DID.
+func IsDid(s string) bool {
+	return didRegex.MatchString(s)
+}
+
 func UnflattenDid(s string) string {
 	if !IsFlattenedDid(s) {
 		return s
@@ -47,11 +52,6 @@ func FlattenDid(s string) string {
 	return s
 }
 
-// IsDid checks if the given string is a standard DID.
-func IsDid(s string) bool {
-	return didRegex.MatchString(s)
-}
-
 var subdomainRegex = regexp.MustCompile(`^[a-z0-9]([a-z0-9-]{2,61}[a-z0-9])?$`)
 
 func IsValidSubdomain(name string) bool {
-- 
2.43.0