The knotserver can now use alternative PLCs for DID resolution by setting the env var KNOT_SERVER_PLC_URL. The default identity directory was copied out of the at proto lib and updated to take in a target url for the PLC being used to do this.
knotserver/config: add PLC URL config option #682
expand 1 commit
hide 1 commit
The knotserver can now use alternative PLCs for DID resolution
by setting the env var KNOT_SERVER_PLC_URL. The default identity
directory was copied out of the at proto lib and updated to take
in a target url for the PLC being used to do this.
expand 1 commit
hide 1 commit
The knotserver can now use alternative PLCs for DID resolution
by setting the env var KNOT_SERVER_PLC_URL. The default identity
directory was copied out of the at proto lib and updated to take
in a target url for the PLC being used to do this.
Signed-off-by: Shail Patel <shailpatel67@gmail.com>
thanks for the PR! if i am understanding correctly:
- this PR introduces a new idresolver.DefaultDirectory
- this is subsequently used in idresolver.DefaultResolver
the issue here is that users of the redis based resolver will be unable to overload their PLC URL (it uses idresolver.BaseDirectory internally). i would suggest that:
- we remove idresolver.DefaultDirectory
- add the PLC URL overload to idresolver.BaseDirectory
- permit PLC URL overload on users of idresolver.RedisDirectory
@oppi.li I've been working on same feature but for appview side, I'll open a new PR merging both with your review applied.
closing in flavor of #683
Yeah exactly, I pulled the defaultDirectory out of the library https://github.com/bluesky-social/indigo/blob/main/atproto/identity/directory.go#L65 and added the url parameter.
Thanks for the other PR @boltless.me!
The original issue was related to DID resolution with ipv6 only https://tangled.org/@tangled.org/core/issues/268,
I setup my knot with the env
KNOT_SERVER_PLC_URL=https://plc.wtfand got a little farther but looks like the PDS also doesn't support IPV6 ;-;