tangled.org / core
Monorepo for Tangled — https://tangled.org
fork atom

appview: add personal pronouns to profile #688

merged
opened by serendipty01.dev targeting master from serendipty01.dev/tangled-core: pronouns
0
by serendipty01.dev 3 comments
expand 1 commit
77301f1a
appview: add personal pronouns to profile
oppi.li

thanks for the PR! couple of things:

  • the timeline fails to load, GetProfiles does not handle null pronouns gracefully
  • can we use text-gray-500 dark:text-gray-400 on the rendered field?

otherwise, quite happy with this changeset!

serendipty01.dev

thanks, let me do those changes

sign up or login to add to the discussion
1
by serendipty01.dev 0 comments
expand 1 commit
81169be6
appview: add personal pronouns to profile
sign up or login to add to the discussion
2
by serendipty01.dev 1 comment
expand 1 commit
11044fd9
appview: add personal pronouns to profile
oppi.li

this is looking pretty neat! i'd like the pronouns column to still be nullable however. we can use pronouns sql.Null[String] in the scanner instead, and do a pronouns.Valid check before assigning to the profile.

sign up or login to add to the discussion
3
by serendipty01.dev 1 comment
expand 1 commit
e3f27a5b
appview: add personal pronouns to profile
pull request successfully merged
sign up or login to add to the discussion
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:pzcr34e3e2emtcnyzrpmilht/sh.tangled.repo.pull/3m3pooe7qj322