From c3c678b69cc5b6b468705dacbfdd6ca1df4ef11c Mon Sep 17 00:00:00 2001 From: Seongmin Lee Date: Mon, 20 Oct 2025 20:26:52 +0900 Subject: [PATCH] appview/gfi: render gfi label when there isn't any matching issues Change-Id: muowzxnsoxuvvsykvynzywnpnwksxxwk although it might not happen, the appview should be able to handle when there is no single issue with good-first-issue label Signed-off-by: Seongmin Lee --- appview/state/gfi.go | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/appview/state/gfi.go b/appview/state/gfi.go index b0106813..28217757 100644 --- a/appview/state/gfi.go +++ b/appview/state/gfi.go @@ -25,6 +25,13 @@ func (s *State) GoodFirstIssues(w http.ResponseWriter, r *http.Request) { goodFirstIssueLabel := fmt.Sprintf("at://%s/%s/%s", consts.TangledDid, tangled.LabelDefinitionNSID, "good-first-issue") + gfiLabelDef, err := db.GetLabelDefinition(s.db, db.FilterEq("at_uri", goodFirstIssueLabel)) + if err != nil { + log.Println("failed to get gfi label def", err) + s.pages.Error503(w) + return + } + repoLabels, err := db.GetRepoLabels(s.db, db.FilterEq("label_at", goodFirstIssueLabel)) if err != nil { log.Println("failed to get repo labels", err) @@ -38,6 +45,7 @@ func (s *State) GoodFirstIssues(w http.ResponseWriter, r *http.Request) { RepoGroups: []*models.RepoGroup{}, LabelDefs: make(map[string]*models.LabelDefinition), Page: page, + GfiLabel: gfiLabelDef, }) return } @@ -146,6 +154,6 @@ func (s *State) GoodFirstIssues(w http.ResponseWriter, r *http.Request) { RepoGroups: paginatedGroups, LabelDefs: labelDefsMap, Page: page, - GfiLabel: labelDefsMap[goodFirstIssueLabel], + GfiLabel: gfiLabelDef, }) } -- 2.43.0