appview/gfi: render gfi label when there isn't any matching issues #702

merged

opened by

boltless.me 1 month ago targeting master from sandboxed-atmosphere

although it might not happen, the appview should be able to handle when there is no single issue with good-first-issue label

Signed-off-by: Seongmin Lee git@boltless.me

options

unified split

Changed files

+9 -1

appview

state

gfi.go

+9 -1

appview/state/gfi.go

···

       22
       22
        
       

     

       23
       23
        
       	goodFirstIssueLabel := fmt.Sprintf("at://%s/%s/%s", consts.TangledDid, tangled.LabelDefinitionNSID, "good-first-issue")

     

       24
       24
        
       

     

       25
       25
       +
       	gfiLabelDef, err := db.GetLabelDefinition(s.db, db.FilterEq("at_uri", goodFirstIssueLabel))

     

       26
       26
       +
       	if err != nil {

     

       27
       27
       +
       		log.Println("failed to get gfi label def", err)

     

       28
       28
       +
       		s.pages.Error500(w)

     

       29
       29
       +
       		return

     

       30
       30
       +
       	}

     

       31
       31
       +
       

     

       25
       32
        
       	repoLabels, err := db.GetRepoLabels(s.db, db.FilterEq("label_at", goodFirstIssueLabel))

     

       26
       33
        
       	if err != nil {

     

       27
       34
        
       		log.Println("failed to get repo labels", err)

     
···

       35
       42
        
       			RepoGroups:   []*models.RepoGroup{},

     

       36
       43
        
       			LabelDefs:    make(map[string]*models.LabelDefinition),

     

       37
       44
        
       			Page:         page,

     

       45
       45
       +
       			GfiLabel:     gfiLabelDef,

     

       38
       46
        
       		})

     

       39
       47
        
       		return

     

       40
       48
        
       	}

     
···

       143
       151
        
       		RepoGroups:   paginatedGroups,

     

       144
       152
        
       		LabelDefs:    labelDefsMap,

     

       145
       153
        
       		Page:         page,

     

       146
       146
       -
       		GfiLabel:     labelDefsMap[goodFirstIssueLabel],

     

       154
       154
       +
       		GfiLabel:     gfiLabelDef,

     

       147
       155
        
       	})

     

       148
       156
        
       }