knotserver: redirect handle-path to did-path #705

open

opened by

boltless.me 1 month ago targeting master from push-xpolynpvotzt

fixing issue reported on discord: https://discord.com/channels/1361963801993285692/1361966362653757450/1430609124114301060

knotserver: redirect handle-path to did-path

this will allow handle based url when cloning from knot over https
usually appview will resolve this before redirecting to the knot

this implementation just redirects to resolved path instead of passing
the entire identity for performance. As we won't want to resolve same
identity twice when proxied by appview.

Signed-off-by: Seongmin Lee <git@boltless.me>

options

unified split

Changed files

+24

knotserver

router.go

+24

knotserver/router.go

···

       5
       5
        
       	"fmt"

     

       6
       6
        
       	"log/slog"

     

       7
       7
        
       	"net/http"

     

       8
       8
       +
       	"strings"

     

       8
       9
        
       

     

       9
       10
        
       	"github.com/go-chi/chi/v5"

     

       10
       11
        
       	"tangled.org/core/idresolver"

     
···

       78
       79
        
       	})

     

       79
       80
        
       

     

       80
       81
        
       	r.Route("/{did}", func(r chi.Router) {

     

       82
       82
       +
       		r.Use(h.resolveDidRedirect)

     

       81
       83
        
       		r.Route("/{name}", func(r chi.Router) {

     

       82
       84
        
       			// routes for git operations

     

       83
       85
        
       			r.Get("/info/refs", h.InfoRefs)

     
···

       114
       116
        
       	return xrpc.Router()

     

       115
       117
        
       }

     

       116
       118
        
       

     

       119
       119
       +
       func (h *Knot) resolveDidRedirect(next http.Handler) http.Handler {

     

       120
       120
       +
       	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {

     

       121
       121
       +
       		didOrHandle := chi.URLParam(r, "did")

     

       122
       122
       +
       		if strings.HasPrefix(didOrHandle, "did:") {

     

       123
       123
       +
       			next.ServeHTTP(w, r)

     

       124
       124
       +
       			return

     

       125
       125
       +
       		}

     

       126
       126
       +
       

     

       127
       127
       +
       		trimmed := strings.TrimPrefix(didOrHandle, "@")

     

       128
       128
       +
       		id, err := h.resolver.ResolveIdent(r.Context(), trimmed)

     

       129
       129
       +
       		if err != nil {

     

       130
       130
       +
       			// invalid did or handle

     

       131
       131
       +
       			h.l.Error("failed to resolve did/handle", "handle", trimmed, "err", err)

     

       132
       132
       +
       			http.Error(w, fmt.Sprintf("failed to resolve did/handle: %s", trimmed), http.StatusInternalServerError)

     

       133
       133
       +
       			return

     

       134
       134
       +
       		}

     

       135
       135
       +
       

     

       136
       136
       +
       		newPath := strings.Replace(r.URL.Path, "/"+didOrHandle, "/"+id.DID.String(), 1)

     

       137
       137
       +
       		http.Redirect(w, r, newPath, http.StatusTemporaryRedirect)

     

       138
       138
       +
       	})

     

       139
       139
       +
       }

     

       140
       140
       +
       

     

       117
       141
        
       func (h *Knot) configureOwner() error {

     

       118
       142
        
       	cfgOwner := h.c.Server.Owner

     

       119
       143