knotserver: redirect handle-path to did-path #705

open

opened by

boltless.me 1 month ago targeting master from push-xpolynpvotzt

fixing issue reported on discord: https://discord.com/channels/1361963801993285692/1361966362653757450/1430609124114301060

knotserver: redirect handle-path to did-path

this will allow handle based url when cloning from knot over https
usually appview will resolve this before redirecting to the knot

this implementation just redirects to resolved path instead of passing
the entire identity for performance. As we won't want to resolve same
identity twice when proxied by appview.

Signed-off-by: Seongmin Lee <git@boltless.me>

options

unified split

Changed files

+25

knotserver

router.go

+25

knotserver/router.go

···

       5
       5
        
       	"fmt"

     

       6
       6
        
       	"log/slog"

     

       7
       7
        
       	"net/http"

     

       8
       8
       +
       	"strings"

     

       8
       9
        
       

     

       9
       10
        
       	"github.com/go-chi/chi/v5"

     

       10
       11
        
       	"tangled.org/core/idresolver"

     
···

       79
       80
        
       	})

     

       80
       81
        
       

     

       81
       82
        
       	r.Route("/{did}", func(r chi.Router) {

     

       83
       83
       +
       		r.Use(h.resolveDidRedirect)

     

       82
       84
        
       		r.Route("/{name}", func(r chi.Router) {

     

       83
       85
        
       			// routes for git operations

     

       84
       86
        
       			r.Get("/info/refs", h.InfoRefs)

     
···

       115
       117
        
       	return xrpc.Router()

     

       116
       118
        
       }

     

       117
       119
        
       

     

       120
       120
       +
       func (h *Knot) resolveDidRedirect(next http.Handler) http.Handler {

     

       121
       121
       +
       	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {

     

       122
       122
       +
       		didOrHandle := chi.URLParam(r, "did")

     

       123
       123
       +
       		if strings.HasPrefix(didOrHandle, "did:") {

     

       124
       124
       +
       			next.ServeHTTP(w, r)

     

       125
       125
       +
       			return

     

       126
       126
       +
       		}

     

       127
       127
       +
       

     

       128
       128
       +
       		trimmed := strings.TrimPrefix(didOrHandle, "@")

     

       129
       129
       +
       		id, err := h.resolver.ResolveIdent(r.Context(), trimmed)

     

       130
       130
       +
       		if err != nil {

     

       131
       131
       +
       			// invalid did or handle

     

       132
       132
       +
       			h.l.Error("failed to resolve did/handle", "handle", trimmed, "err", err)

     

       133
       133
       +
       			http.Error(w, fmt.Sprintf("failed to resolve did/handle: %s", trimmed), http.StatusInternalServerError)

     

       134
       134
       +
       			return

     

       135
       135
       +
       		}

     

       136
       136
       +
       

     

       137
       137
       +
       		suffix := strings.TrimPrefix(r.URL.Path, "/"+didOrHandle)

     

       138
       138
       +
       		newPath := fmt.Sprintf("/%s/%s?%s", id.DID.String(), suffix, r.URL.RawQuery)

     

       139
       139
       +
       		http.Redirect(w, r, newPath, http.StatusTemporaryRedirect)

     

       140
       140
       +
       	})

     

       141
       141
       +
       }

     

       142
       142
       +
       

     

       118
       143
        
       func (h *Knot) configureOwner() error {

     

       119
       144
        
       	cfgOwner := h.c.Server.Owner

     

       120
       145