From 494d833273db453d46850a8a3966598bdc4912be Mon Sep 17 00:00:00 2001
From: Seongmin Lee <git@boltless.me>
Date: Thu, 23 Oct 2025 22:29:21 +0900
Subject: [PATCH] appview/pulls: add search endpoint
Change-Id: vsqwxpkpopsnurrqxnuykssylyxkvmzx

Signed-off-by: Seongmin Lee <git@boltless.me>
---
 appview/db/pulls.go                           | 61 +++++++++++++++++++
 appview/pages/pages.go                        |  1 +
 appview/pages/templates/repo/pulls/pulls.html |  7 +++
 appview/pulls/pulls.go                        | 37 ++++++++++-
 appview/state/router.go                       |  1 +
 5 files changed, 105 insertions(+), 2 deletions(-)

diff --git a/appview/db/pulls.go b/appview/db/pulls.go
index 0d0007f7..99b0a7c0 100644
--- a/appview/db/pulls.go
+++ b/appview/db/pulls.go
@@ -281,6 +281,67 @@ func GetPulls(e Execer, filters ...filter) ([]*models.Pull, error) {
 	return GetPullsWithLimit(e, 0, filters...)
 }
 
+func GetPullIDs(e Execer, opts models.PullSearchOptions) ([]int64, error) {
+	var ids []int64
+
+	var filters []filter
+	filters = append(filters, FilterEq("state", opts.State))
+	if opts.RepoAt != "" {
+		filters = append(filters, FilterEq("repo_at", opts.RepoAt))
+	}
+
+	var conditions []string
+	var args []any
+
+	for _, filter := range filters {
+		conditions = append(conditions, filter.Condition())
+		args = append(args, filter.Arg()...)
+	}
+
+	whereClause := ""
+	if conditions != nil {
+		whereClause = " where " + strings.Join(conditions, " and ")
+	}
+	pageClause := ""
+	if opts.Page.Limit != 0 {
+		pageClause = fmt.Sprintf(
+			" limit %d offset %d ",
+			opts.Page.Limit,
+			opts.Page.Offset,
+		)
+	}
+
+	query := fmt.Sprintf(
+		`
+		select
+			id
+		from
+			pulls
+		%s
+		%s`,
+		whereClause,
+		pageClause,
+	)
+	args = append(args, opts.Page.Limit, opts.Page.Offset)
+	rows, err := e.Query(query, args...)
+	if err != nil {
+		return nil, err
+	}
+	defer rows.Close()
+
+	for rows.Next() {
+		var id int64
+		err := rows.Scan(&id)
+		if err != nil {
+			return nil, err
+		}
+
+		ids = append(ids, id)
+	}
+
+	return ids, nil
+}
+
 func GetPull(e Execer, repoAt syntax.ATURI, pullId int) (*models.Pull, error) {
 	pulls, err := GetPullsWithLimit(e, 1, FilterEq("repo_at", repoAt), FilterEq("pull_id", pullId))
 	if err != nil {
diff --git a/appview/pages/pages.go b/appview/pages/pages.go
index 9e2e2a56..9608ff2e 100644
--- a/appview/pages/pages.go
+++ b/appview/pages/pages.go
@@ -1102,6 +1102,7 @@ type RepoPullsParams struct {
 	Pulls        []*models.Pull
 	Active       string
 	FilteringBy  models.PullState
+	FilterQuery  string
 	Stacks       map[string]models.Stack
 	Pipelines    map[string]models.Pipeline
 	LabelDefs    map[string]*models.LabelDefinition
diff --git a/appview/pages/templates/repo/pulls/pulls.html b/appview/pages/templates/repo/pulls/pulls.html
index 6541a54c..f2c557d3 100644
--- a/appview/pages/templates/repo/pulls/pulls.html
+++ b/appview/pages/templates/repo/pulls/pulls.html
@@ -31,6 +31,13 @@
                 {{ i "ban" "w-4 h-4" }}
                 <span>{{ .RepoInfo.Stats.PullCount.Closed }} closed</span>
             </a>
+            <form class="flex gap-4" method="GET">
+                <input type="hidden" name="state" value="{{ .FilteringBy.String }}">
+                <input class="" type="text" name="q" value="{{ .FilterQuery }}">
+                <button class="btn" type="submit">
+                    search
+                </button>
+            </form>
         </div>
         <a
             href="/{{ .RepoInfo.FullName }}/pulls/new"
diff --git a/appview/pulls/pulls.go b/appview/pulls/pulls.go
index 35be06c8..214f421f 100644
--- a/appview/pulls/pulls.go
+++ b/appview/pulls/pulls.go
@@ -17,6 +17,7 @@ import (
 	"tangled.org/core/api/tangled"
 	"tangled.org/core/appview/config"
 	"tangled.org/core/appview/db"
+	pulls_indexer "tangled.org/core/appview/indexer/pulls"
 	"tangled.org/core/appview/models"
 	"tangled.org/core/appview/notify"
 	"tangled.org/core/appview/oauth"
@@ -49,6 +50,7 @@ type Pulls struct {
 	enforcer     *rbac.Enforcer
 	logger       *slog.Logger
 	validator    *validator.Validator
+	indexer      *pulls_indexer.Indexer
 }
 
 func New(
@@ -61,6 +63,7 @@ func New(
 	notifier notify.Notifier,
 	enforcer *rbac.Enforcer,
 	validator *validator.Validator,
+	indexer *pulls_indexer.Indexer,
 	logger *slog.Logger,
 ) *Pulls {
 	return &Pulls{
@@ -74,6 +77,7 @@ func New(
 		enforcer:     enforcer,
 		logger:       logger,
 		validator:    validator,
+		indexer:      indexer,
 	}
 }
 
@@ -544,6 +548,8 @@ func (s *Pulls) RepoPullPatchRaw(w http.ResponseWriter, r *http.Request) {
 }
 
 func (s *Pulls) RepoPulls(w http.ResponseWriter, r *http.Request) {
+	l := s.logger.With("handler", "RepoPulls")
+
 	user := s.oauth.GetUser(r)
 	params := r.URL.Query()
 
@@ -561,10 +567,36 @@ func (s *Pulls) RepoPulls(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
+	keyword := params.Get("q")
+
+	var ids []int64
+	searchOpts := models.PullSearchOptions{
+		Keyword: keyword,
+		RepoAt:  f.RepoAt().String(),
+		State:   state,
+		// Page: page,
+	}
+	l.Debug("searching with", "searchOpts", searchOpts)
+	if keyword != "" {
+		res, err := s.indexer.Search(r.Context(), searchOpts)
+		if err != nil {
+			l.Error("failed to search for pulls", "err", err)
+			return
+		}
+		l.Debug("searched pulls with indexer", "res.Hits", res.Hits)
+		ids = res.Hits
+	} else {
+		ids, err = db.GetPullIDs(s.db, searchOpts)
+		if err != nil {
+			l.Error("failed to get all pull ids", "err", err)
+			return
+		}
+		l.Debug("indexed all pulls from the db", "ids", ids)
+	}
+
 	pulls, err := db.GetPulls(
 		s.db,
-		db.FilterEq("repo_at", f.RepoAt()),
-		db.FilterEq("state", state),
+		db.FilterIn("id", ids),
 	)
 	if err != nil {
 		log.Println("failed to get pulls", err)
@@ -651,6 +683,7 @@ func (s *Pulls) RepoPulls(w http.ResponseWriter, r *http.Request) {
 		Pulls:        pulls,
 		LabelDefs:    defs,
 		FilteringBy:  state,
+		FilterQuery:  keyword,
 		Stacks:       stacks,
 		Pipelines:    m,
 	})
diff --git a/appview/state/router.go b/appview/state/router.go
index 9cd8a91f..ca5f9bd7 100644
--- a/appview/state/router.go
+++ b/appview/state/router.go
@@ -279,6 +279,7 @@ func (s *State) PullsRouter(mw *middleware.Middleware) http.Handler {
 		s.notifier,
 		s.enforcer,
 		s.validator,
+		s.indexer.Pulls,
 		log.SubLogger(s.logger, "pulls"),
 	)
 	return pulls.Router(mw)
-- 
2.43.0