tangled.org / core
Monorepo for Tangled — https://tangled.org
fork atom

Add CORS top level middleware router to knotserver/ #735

merged
opened by nekomimi.pet targeting master from [deleted fork]: master

To make it easier to get information about tangled repos, CORS need to be enabled on repo knots otherwise browsers will throw a fit. This change adds those headers. I think maybe the auth routes could do without them as right now it just gives it to all the routes.

0
by nekomimi.pet 0 comments
expand 2 commits
88684a67
knotserver/middleware.go: add cors headers as a middleware function
396baab5
knotserver/router.go: have top level router use cors header function
sign up or login to add to the discussion
1
by nekomimi.pet 2 comments
expand 2 commits
83963a3d
knotserver/middleware.go: add cors headers as a middleware function
729f7fce
knotserver/router.go: have top level router use cors header function
nekomimi.pet

resubmitted to sign off on commits

anirudh.fi

Awesome, this looks great! Tiny nit about the commits: they can simply be knotserver: … (exclude the filename, we only specify nested directories).

sign up or login to add to the discussion
2
by nekomimi.pet 2 comments
expand 2 commits
59a1308e
knotserver: add cors headers as a middleware function
b19de89d
knotserver: have top level router use cors header function
anirudh.fi

Amazing, merging!

pull request successfully merged
sign up or login to add to the discussion
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:ttdrpj45ibqunmfhdsb4zdwq/sh.tangled.repo.pull/3m4ivlx63dd22