tangled.org / core
Monorepo for Tangled — https://tangled.org
fork atom

appview/notify: notify users mentioned in issues #738

merged
opened by boltless.me targeting master from feat/mentions
STACK 4
#765 draft: render backlinks
3/3
1
#11
#764 appview/pages: fix broken issue-comment links
0/3
0
#11
#761 appview,lexicons: atprotate the mentions & references
0/3
0
#12
#760 appview: parse reference links from markdown body
0/3
0
#12
0
by boltless.me 0 comments
expand 1 commit
93cc31e3
appview/notify: notify users mentioned in issues
build.yml
fmt.yml
test.yml
sign up or login to add to the discussion
1
by boltless.me 2 comments
expand 1 commit
93cc31e3
appview/notify: notify users mentioned in issues
oppi.li

the way i'd want to see this implemented is like so:

  • the handle mentions are rewritten by the appview to point to a DID (this way mentions continue to work across handle changes). this can happen when creating a new issue or a new comment. note that when editing a text field, this needs to be retranslated from DID back to handle. we do something similar in labels that accept DIDs for example
  • next, we can introduce models.IssueComment.Mentions to get a list of DIDs mentioned in the text of a comment, and notify them accordingly, upon creation.
boltless.me

I've considered it, but decided to go without did transitions for now. We can merge this as a temporary solution and introduce did-hardening later.

Also not sure, how would that look like in markdown. you mean like this: @did:plc:someone?

build.yml
fmt.yml
test.yml
sign up or login to add to the discussion
2
by boltless.me 0 comments
expand 1 commit
2eedcf5d
appview/notify: notify users mentioned in issues
build.yml
fmt.yml
test.yml
sign up or login to add to the discussion
3
by boltless.me 0 comments
expand 1 commit
f01363d5
appview/notify: notify users mentioned in issues
build.yml
fmt.yml
test.yml
sign up or login to add to the discussion
4
by boltless.me 0 comments
expand 1 commit
f34a53e7
appview/notify: notify users mentioned in issues
build.yml
fmt.yml
test.yml
sign up or login to add to the discussion
5
by boltless.me 0 comments
expand 1 commit
2c5719ae
appview/notify: notify users mentioned in issues
build.yml
fmt.yml
test.yml
sign up or login to add to the discussion
6
by boltless.me 0 comments
expand 1 commit
66964960
appview/notify: notify users mentioned in issues
build.yml
fmt.yml
test.yml
sign up or login to add to the discussion
7
by boltless.me 0 comments
expand 1 commit
66964960
appview/notify: notify users mentioned in issues
build.yml
fmt.yml
test.yml
sign up or login to add to the discussion
8
by boltless.me 0 comments
expand 1 commit
024f313d
appview/notify: notify users mentioned in issues
build.yml
fmt.yml
test.yml
sign up or login to add to the discussion
9
by boltless.me 0 comments
expand 1 commit
137cc1d5
appview/notify: notify users mentioned in issues
build.yml
fmt.yml
test.yml
sign up or login to add to the discussion
10
by boltless.me 0 comments
expand 1 commit
37b7f8eb
appview/notify: notify users mentioned in issues
build.yml
fmt.yml
test.yml
sign up or login to add to the discussion
11
by boltless.me 0 comments
expand 1 commit
87e40fd1
appview/notify: notify users mentioned in issues
build.yml
fmt.yml
test.yml
sign up or login to add to the discussion
12
by boltless.me 0 comments
expand 1 commit
87e40fd1
appview/notify: notify users mentioned in issues
build.yml
fmt.yml
test.yml
sign up or login to add to the discussion
13
by boltless.me 0 comments
expand 1 commit
bc693fa8
appview/notify: notify users mentioned in issues
build.yml
fmt.yml
test.yml
pull request successfully merged
sign up or login to add to the discussion
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:xasnlahkri4ewmbuzly2rlc5/sh.tangled.repo.pull/3m4jbido5pi22