Monorepo for Tangled โ€” https://tangled.org

appview/pages: include LoggedInUser on error pages #845

closed
opened by octet-stream.net targeting master from octet-stream.net/core: thombles/error-logged-in

Closes https://tangled.org/tangled.org/core/issues/272

Call sites are updated to provide user, which was usually present anyway. There were a couple of exceptions where I passed nil in functions that were creating an atom feed, since it seemed unlikely to be authenticated.

0
by octet-stream.net 2 comments
expand 1 commit
appview/pages: include LoggedInUser on error pages

I fill guilty about this... There was PR #692 with same change which I didn't merge because I thought using ctx.Value would be more ideal approach. I still think so, but now I think it's fine to accept as a temporary solution as I'm rewriting all existing handlers anyway (PR #800).

Aye you're right, Context would be cleaner. It's only a cosmetic improvement so I'd suggest we just close and try again later when the refactoring is done. :) I'll leave a note on the issue.

closed without merging
sign up or login to add to the discussion
Labels

None yet.

assignee

None yet.

Participants 2
AT URI
at://did:plc:txurc6ueald5d7462bpvzdby/sh.tangled.repo.pull/3m7533vmw7v22