appview/pages: fix checkbox name for notifications when mentioned #847

merged

opened by

octet-stream.net 1 week ago targeting master from octet-stream.net/core: thombles/save-mentions-notification

Before: when you save notifications preferences, "when someone mentions you" always gets deselected as the HTML checkbox is named mentioned but the form processing logic checks for user_mentioned

          <input type="checkbox" name="mentioned" {{if .Preferences.UserMentioned}}checked{{end}}>

UserMentioned:      r.FormValue("user_mentioned") == "on",

After: HTML checkbox is renamed to user_mentioned so preference is saved correctly

options

unified split

Changed files

+1 -1

appview

pages

templates

user

settings

notifications.html

+1 -1

appview/pages/templates/user/settings/notifications.html

···

       151
       151
        
                 </div>

     

       152
       152
        
               </div>

     

       153
       153
        
               <label class="flex items-center gap-2">

     

       154
       154
       -
                 <input type="checkbox" name="mentioned" {{if .Preferences.UserMentioned}}checked{{end}}>

     

       154
       154
       +
                 <input type="checkbox" name="user_mentioned" {{if .Preferences.UserMentioned}}checked{{end}}>

     

       155
       155
        
               </label>

     

       156
       156
        
             </div>

     

       157
       157