this repo has no description

Make runc the main process engine

+1 -1
src/lib/engine.ml
···
val run :
config ->
-
_ Eio.Path.t ->
+
Eio.Fs.dir_ty Eio.Path.t ->
_ Eio.Time.clock ->
Eio_unix.Process.mgr_ty Eio_unix.Process.mgr ->
entry History.t * ctx ->
+22 -3
src/lib/shelter/config.ml
···
-
type t = { no_diffing : bool; no_ebpf : bool }
+
type t = {
+
no_diffing : bool;
+
no_ebpf : bool;
+
no_runc : bool;
+
image : string;
+
shell : string;
+
}
let cmdliner =
let open Cmdliner in
···
let doc = "Disable eBPF." in
Arg.(value & flag & info [ "no-ebpf" ] ~doc)
in
+
let image =
+
let doc = "Base image to start Shelter with." in
+
Arg.(value & opt string "alpine" & info [ "image" ] ~doc)
+
in
+
let shell =
+
let doc = "Path to the shell (e.g. /bin/ash)" in
+
Arg.(value & opt string "/bin/ash" & info [ "shell" ] ~doc)
+
in
+
let no_runc =
+
let doc = "Disable RUNC and use Void processes." in
+
Arg.(value & flag & info [ "no-runc" ] ~doc)
+
in
Term.(
-
const (fun no_diffing no_ebpf -> { no_diffing; no_ebpf })
-
$ no_diffing $ no_ebpf)
+
const (fun no_diffing no_ebpf no_runc image shell ->
+
{ no_diffing; no_ebpf; no_runc; image; shell })
+
$ no_diffing $ no_ebpf $ no_runc $ image $ shell)
+29 -2
src/lib/shelter/fetch.ml
···
let ( / ) = Eio.Path.( / )
+
let replace_slash s = String.split_on_char '/' s |> String.concat "-"
+
+
let get_user proc image =
+
Eio.Process.parse_out proc Eio.Buf_read.take_all
+
[
+
"docker";
+
"image";
+
"inspect";
+
"--format";
+
{|{{.Config.User}}|};
+
"--";
+
image;
+
]
+
|> String.trim
+
+
let get_env proc image =
+
Eio.Process.parse_out proc Eio.Buf_read.take_all
+
[
+
"docker";
+
"image";
+
"inspect";
+
"--format";
+
{|{{range .Config.Env}}{{print . "\x00"}}{{end}}|};
+
"--";
+
image;
+
]
+
|> String.split_on_char '\x00'
let get_image ~dir ~proc image =
let container_id =
···
[ "docker"; "run"; "-d"; image ]
|> String.trim
in
-
let tar = image ^ ".tar.gz" in
+
let tar = replace_slash image ^ ".tar.gz" in
let dir_s = Eio.Path.native_exn dir in
let () =
Eio.Process.run proc
···
[
"tar";
"-xf";
-
Filename.concat dir_s "alpine.tar.gz";
+
Filename.concat dir_s tar;
"-C";
Filename.concat dir_s "rootfs";
]
+454
src/lib/shelter/runc.ml
···
+
(* From Obuilder see License file at end of document *)
+
let ( / ) = Eio.Path.( / )
+
let ( // ) = Filename.concat
+
+
type config = { fast_sync : bool }
+
+
let get_machine () =
+
let ch = Unix.open_process_in "uname -m" in
+
let arch = input_line ch in
+
match Unix.close_process_in ch with
+
| Unix.WEXITED 0 -> String.trim arch
+
| _ -> failwith "Failed to get arch with 'uname -m'"
+
+
let get_arches () =
+
if Sys.unix then
+
match get_machine () with
+
| "x86_64" -> [ "SCMP_ARCH_X86_64"; "SCMP_ARCH_X86"; "SCMP_ARCH_X32" ]
+
| "aarch64" -> [ "SCMP_ARCH_AARCH64"; "SCMP_ARCH_ARM" ]
+
| _ -> []
+
else []
+
+
let secret_file id = "secret-" ^ string_of_int id
+
+
module Json_config = struct
+
let mount ?(options = []) ~ty ~src dst =
+
`Assoc
+
[
+
("destination", `String dst);
+
("type", `String ty);
+
("source", `String src);
+
("options", `List (List.map (fun x -> `String x) options));
+
]
+
+
let strings xs = `List (List.map (fun x -> `String x) xs)
+
let namespace x = `Assoc [ ("type", `String x) ]
+
+
(* This is a subset of the capabilities that Docker uses by default.
+
These control what root can do in the container.
+
If the init process is non-root, permitted, effective and ambient sets are cleared.
+
See capabilities(7) for full details. *)
+
let default_linux_caps =
+
[
+
"CAP_CHOWN";
+
(* Make arbitrary changes to file UIDs and GIDs *)
+
"CAP_DAC_OVERRIDE";
+
(* Bypass file read, write, and execute permission checks. *)
+
"CAP_FSETID";
+
(* Set SUID/SGID bits. *)
+
"CAP_FOWNER";
+
(* Bypass permission checks. *)
+
"CAP_MKNOD";
+
(* Create special files using mknod. *)
+
"CAP_SETGID";
+
(* Make arbitrary manipulations of process GIDs. *)
+
"CAP_SETUID";
+
(* Make arbitrary manipulations of process UIDs. *)
+
"CAP_SETFCAP";
+
(* Set arbitrary capabilities on a file. *)
+
"CAP_SETPCAP";
+
(* Add any capability from bounding set to inheritable set. *)
+
"CAP_SYS_CHROOT";
+
(* Use chroot. *)
+
"CAP_KILL";
+
(* Bypass permission checks for sending signals. *)
+
"CAP_AUDIT_WRITE"
+
(* Write records to kernel auditing log. *)
+
(* Allowed by Docker, but disabled here (because we use host networking):
+
"CAP_NET_RAW"; (* Use RAW and PACKET sockets / bind to any address *)
+
"CAP_NET_BIND_SERVICE"; (* Bind a socket to Internet domain privileged ports. *)
+
*);
+
]
+
+
let seccomp_syscalls ~fast_sync =
+
if fast_sync then
+
[
+
`Assoc
+
[
+
(* Sync calls are pointless for the builder, because if the computer crashes then we'll
+
just throw the build dir away and start again. And btrfs sync is really slow.
+
Based on https://bblank.thinkmo.de/using-seccomp-to-filter-sync-operations.html
+
Note: requires runc >= v1.0.0-rc92. *)
+
( "names",
+
strings
+
[
+
"fsync";
+
"fdatasync";
+
"msync";
+
"sync";
+
"syncfs";
+
"sync_file_range";
+
] );
+
("action", `String "SCMP_ACT_ERRNO");
+
("errnoRet", `Int 0);
+
(* Return error "success" *)
+
];
+
]
+
else []
+
+
let seccomp_policy =
+
let fields =
+
[
+
("defaultAction", `String "SCMP_ACT_ALLOW");
+
("syscalls", `List (seccomp_syscalls ~fast_sync:true));
+
]
+
in
+
`Assoc fields
+
+
type config = {
+
cwd : string;
+
argv : string list;
+
hostname : string;
+
network : string list;
+
user : int * int;
+
env : string list;
+
entrypoint : string option;
+
}
+
+
let make { cwd; argv; hostname; network; user; env; entrypoint } ~config_dir
+
~results_dir : Yojson.Safe.t =
+
assert (entrypoint = None);
+
let user =
+
let uid, gid = user in
+
`Assoc [ ("uid", `Int uid); ("gid", `Int gid) ]
+
in
+
let network_ns =
+
match network with
+
| [ "host" ] -> []
+
| [] -> [ "network" ]
+
| xs ->
+
Fmt.failwith "Unsupported network configuration %a"
+
Fmt.Dump.(list string)
+
xs
+
in
+
let namespaces = network_ns @ [ "pid"; "ipc"; "uts"; "mount" ] in
+
`Assoc
+
[
+
("ociVersion", `String "1.0.1-dev");
+
( "process",
+
`Assoc
+
[
+
("terminal", `Bool false);
+
("user", user);
+
("args", strings argv);
+
("env", strings env);
+
("cwd", `String cwd);
+
( "capabilities",
+
`Assoc
+
[
+
("bounding", strings default_linux_caps);
+
(* Limits capabilities gained on execve. *)
+
("effective", strings default_linux_caps);
+
(* Checked by kernel to decide access *)
+
("inheritable", strings default_linux_caps);
+
(* Preserved across an execve (if root, or cap in ambient set) *)
+
("permitted", strings default_linux_caps);
+
(* Limiting superset for the effective capabilities *)
+
] );
+
( "rlimits",
+
`List
+
[
+
`Assoc
+
[
+
("type", `String "RLIMIT_NOFILE");
+
("hard", `Int 1024);
+
("soft", `Int 1024);
+
];
+
] );
+
("noNewPrivileges", `Bool false);
+
] );
+
( "root",
+
`Assoc
+
[
+
("path", `String (results_dir // "rootfs"));
+
("readonly", `Bool false);
+
] );
+
("hostname", `String hostname);
+
( "mounts",
+
`List
+
(mount "/proc"
+
~options:
+
[ (* TODO: copy to others? *) "nosuid"; "noexec"; "nodev" ]
+
~ty:"proc" ~src:"proc"
+
:: mount "/dev" ~ty:"tmpfs" ~src:"tmpfs"
+
~options:[ "nosuid"; "strictatime"; "mode=755"; "size=65536k" ]
+
:: mount "/dev/pts" ~ty:"devpts" ~src:"devpts"
+
~options:
+
[
+
"nosuid";
+
"noexec";
+
"newinstance";
+
"ptmxmode=0666";
+
"mode=0620";
+
"gid=5";
+
(* tty *)
+
]
+
:: mount
+
"/sys"
+
(* This is how Docker does it. runc's default is a bit different. *)
+
~ty:"sysfs" ~src:"sysfs"
+
~options:[ "nosuid"; "noexec"; "nodev"; "ro" ]
+
:: mount "/sys/fs/cgroup" ~ty:"cgroup" ~src:"cgroup"
+
~options:[ "ro"; "nosuid"; "noexec"; "nodev" ]
+
:: mount "/dev/shm" ~ty:"tmpfs" ~src:"shm"
+
~options:
+
[ "nosuid"; "noexec"; "nodev"; "mode=1777"; "size=65536k" ]
+
:: mount "/dev/mqueue" ~ty:"mqueue" ~src:"mqueue"
+
~options:[ "nosuid"; "noexec"; "nodev" ]
+
:: mount "/etc/hosts" ~ty:"bind" ~src:(config_dir // "hosts")
+
~options:[ "ro"; "rbind"; "rprivate" ]
+
::
+
(if network = [ "host" ] then
+
[
+
mount "/etc/resolv.conf" ~ty:"bind" ~src:"/etc/resolv.conf"
+
~options:[ "ro"; "rbind"; "rprivate" ];
+
]
+
else [])) );
+
( "linux",
+
`Assoc
+
[
+
("namespaces", `List (List.map namespace namespaces));
+
( "maskedPaths",
+
strings
+
[
+
"/proc/acpi";
+
"/proc/asound";
+
"/proc/kcore";
+
"/proc/keys";
+
"/proc/latency_stats";
+
"/proc/timer_list";
+
"/proc/timer_stats";
+
"/proc/sched_debug";
+
"/sys/firmware";
+
"/proc/scsi";
+
] );
+
( "readonlyPaths",
+
strings
+
[
+
"/proc/bus";
+
"/proc/fs";
+
"/proc/irq";
+
"/proc/sys";
+
"/proc/sysrq-trigger";
+
] );
+
("seccomp", seccomp_policy);
+
] );
+
]
+
end
+
+
let next_id = ref 0
+
+
let spawn ~sw fs proc config dir =
+
let tmp = Filename.temp_dir ~perms:0o700 "shelter-run-" "" in
+
let eio_tmp = Eio.Path.(fs / tmp) in
+
let json_config = Json_config.make config ~config_dir:tmp ~results_dir:dir in
+
Eio.Path.save ~create:(`If_missing 0o644) (eio_tmp / "config.json")
+
(Yojson.Safe.pretty_to_string json_config ^ "\n");
+
Eio.Path.save ~create:(`If_missing 0o644) (eio_tmp / "hosts")
+
"127.0.0.1 localhost builder";
+
let id = string_of_int !next_id in
+
incr next_id;
+
let cmd = [ "runc"; "--root"; "runc"; "run"; id ] in
+
Eio.Process.spawn ~sw proc ~cwd:eio_tmp cmd
+
+
(*
+
Apache License
+
Version 2.0, January 2004
+
https://www.apache.org/licenses/
+
+
TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+
1. Definitions.
+
+
"License" shall mean the terms and conditions for use, reproduction,
+
and distribution as defined by Sections 1 through 9 of this document.
+
+
"Licensor" shall mean the copyright owner or entity authorized by
+
the copyright owner that is granting the License.
+
+
"Legal Entity" shall mean the union of the acting entity and all
+
other entities that control, are controlled by, or are under common
+
control with that entity. For the purposes of this definition,
+
"control" means (i) the power, direct or indirect, to cause the
+
direction or management of such entity, whether by contract or
+
otherwise, or (ii) ownership of fifty percent (50%) or more of the
+
outstanding shares, or (iii) beneficial ownership of such entity.
+
+
"You" (or "Your") shall mean an individual or Legal Entity
+
exercising permissions granted by this License.
+
+
"Source" form shall mean the preferred form for making modifications,
+
including but not limited to software source code, documentation
+
source, and configuration files.
+
+
"Object" form shall mean any form resulting from mechanical
+
transformation or translation of a Source form, including but
+
not limited to compiled object code, generated documentation,
+
and conversions to other media types.
+
+
"Work" shall mean the work of authorship, whether in Source or
+
Object form, made available under the License, as indicated by a
+
copyright notice that is included in or attached to the work
+
(an example is provided in the Appendix below).
+
+
"Derivative Works" shall mean any work, whether in Source or Object
+
form, that is based on (or derived from) the Work and for which the
+
editorial revisions, annotations, elaborations, or other modifications
+
represent, as a whole, an original work of authorship. For the purposes
+
of this License, Derivative Works shall not include works that remain
+
separable from, or merely link (or bind by name) to the interfaces of,
+
the Work and Derivative Works thereof.
+
+
"Contribution" shall mean any work of authorship, including
+
the original version of the Work and any modifications or additions
+
to that Work or Derivative Works thereof, that is intentionally
+
submitted to Licensor for inclusion in the Work by the copyright owner
+
or by an individual or Legal Entity authorized to submit on behalf of
+
the copyright owner. For the purposes of this definition, "submitted"
+
means any form of electronic, verbal, or written communication sent
+
to the Licensor or its representatives, including but not limited to
+
communication on electronic mailing lists, source code control systems,
+
and issue tracking systems that are managed by, or on behalf of, the
+
Licensor for the purpose of discussing and improving the Work, but
+
excluding communication that is conspicuously marked or otherwise
+
designated in writing by the copyright owner as "Not a Contribution."
+
+
"Contributor" shall mean Licensor and any individual or Legal Entity
+
on behalf of whom a Contribution has been received by Licensor and
+
subsequently incorporated within the Work.
+
+
2. Grant of Copyright License. Subject to the terms and conditions of
+
this License, each Contributor hereby grants to You a perpetual,
+
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+
copyright license to reproduce, prepare Derivative Works of,
+
publicly display, publicly perform, sublicense, and distribute the
+
Work and such Derivative Works in Source or Object form.
+
+
3. Grant of Patent License. Subject to the terms and conditions of
+
this License, each Contributor hereby grants to You a perpetual,
+
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+
(except as stated in this section) patent license to make, have made,
+
use, offer to sell, sell, import, and otherwise transfer the Work,
+
where such license applies only to those patent claims licensable
+
by such Contributor that are necessarily infringed by their
+
Contribution(s) alone or by combination of their Contribution(s)
+
with the Work to which such Contribution(s) was submitted. If You
+
institute patent litigation against any entity (including a
+
cross-claim or counterclaim in a lawsuit) alleging that the Work
+
or a Contribution incorporated within the Work constitutes direct
+
or contributory patent infringement, then any patent licenses
+
granted to You under this License for that Work shall terminate
+
as of the date such litigation is filed.
+
+
4. Redistribution. You may reproduce and distribute copies of the
+
Work or Derivative Works thereof in any medium, with or without
+
modifications, and in Source or Object form, provided that You
+
meet the following conditions:
+
+
(a) You must give any other recipients of the Work or
+
Derivative Works a copy of this License; and
+
+
(b) You must cause any modified files to carry prominent notices
+
stating that You changed the files; and
+
+
(c) You must retain, in the Source form of any Derivative Works
+
that You distribute, all copyright, patent, trademark, and
+
attribution notices from the Source form of the Work,
+
excluding those notices that do not pertain to any part of
+
the Derivative Works; and
+
+
(d) If the Work includes a "NOTICE" text file as part of its
+
distribution, then any Derivative Works that You distribute must
+
include a readable copy of the attribution notices contained
+
within such NOTICE file, excluding those notices that do not
+
pertain to any part of the Derivative Works, in at least one
+
of the following places: within a NOTICE text file distributed
+
as part of the Derivative Works; within the Source form or
+
documentation, if provided along with the Derivative Works; or,
+
within a display generated by the Derivative Works, if and
+
wherever such third-party notices normally appear. The contents
+
of the NOTICE file are for informational purposes only and
+
do not modify the License. You may add Your own attribution
+
notices within Derivative Works that You distribute, alongside
+
or as an addendum to the NOTICE text from the Work, provided
+
that such additional attribution notices cannot be construed
+
as modifying the License.
+
+
You may add Your own copyright statement to Your modifications and
+
may provide additional or different license terms and conditions
+
for use, reproduction, or distribution of Your modifications, or
+
for any such Derivative Works as a whole, provided Your use,
+
reproduction, and distribution of the Work otherwise complies with
+
the conditions stated in this License.
+
+
5. Submission of Contributions. Unless You explicitly state otherwise,
+
any Contribution intentionally submitted for inclusion in the Work
+
by You to the Licensor shall be under the terms and conditions of
+
this License, without any additional terms or conditions.
+
Notwithstanding the above, nothing herein shall supersede or modify
+
the terms of any separate license agreement you may have executed
+
with Licensor regarding such Contributions.
+
+
6. Trademarks. This License does not grant permission to use the trade
+
names, trademarks, service marks, or product names of the Licensor,
+
except as required for reasonable and customary use in describing the
+
origin of the Work and reproducing the content of the NOTICE file.
+
+
7. Disclaimer of Warranty. Unless required by applicable law or
+
agreed to in writing, Licensor provides the Work (and each
+
Contributor provides its Contributions) on an "AS IS" BASIS,
+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+
implied, including, without limitation, any warranties or conditions
+
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
+
PARTICULAR PURPOSE. You are solely responsible for determining the
+
appropriateness of using or redistributing the Work and assume any
+
risks associated with Your exercise of permissions under this License.
+
+
8. Limitation of Liability. In no event and under no legal theory,
+
whether in tort (including negligence), contract, or otherwise,
+
unless required by applicable law (such as deliberate and grossly
+
negligent acts) or agreed to in writing, shall any Contributor be
+
liable to You for damages, including any direct, indirect, special,
+
incidental, or consequential damages of any character arising as a
+
result of this License or out of the use or inability to use the
+
Work (including but not limited to damages for loss of goodwill,
+
work stoppage, computer failure or malfunction, or any and all
+
other commercial damages or losses), even if such Contributor
+
has been advised of the possibility of such damages.
+
+
9. Accepting Warranty or Additional Liability. While redistributing
+
the Work or Derivative Works thereof, You may choose to offer,
+
and charge a fee for, acceptance of support, warranty, indemnity,
+
or other liability obligations and/or rights consistent with this
+
License. However, in accepting such obligations, You may act only
+
on Your own behalf and on Your sole responsibility, not on behalf
+
of any other Contributor, and only if You agree to indemnify,
+
defend, and hold each Contributor harmless for any liability
+
incurred by, or claims asserted against, such Contributor by reason
+
of your accepting any such warranty or additional liability.
+
+
END OF TERMS AND CONDITIONS
+
+
Copyright 2020 Thomas Leonard
+
+
Licensed under the Apache License, Version 2.0 (the "License");
+
you may not use this file except in compliance with the License.
+
You may obtain a copy of the License at
+
+
https://www.apache.org/licenses/LICENSE-2.0
+
+
Unless required by applicable law or agreed to in writing, software
+
distributed under the License is distributed on an "AS IS" BASIS,
+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+
See the License for the specific language governing permissions and
+
limitations under the License. *)
+78 -33
src/lib/shelter/shelter_main.ml
···
time : int64;
env : string list;
cwd : string;
+
user : int * int;
diff : Diff.t;
}
[@@deriving repr]
···
(list s);
store
-
let run (_config : config) fs clock _proc
+
let run (config : config) fs clock proc
(((H.Store ((module S), store) : entry H.t) as s), ctx) = function
| Set_mode mode ->
with_latest ~default:(fun _ -> Ok (s, ctx)) s @@ fun (_, entry) ->
···
History.
{
mode = Void.RW;
-
build = Store.Build.Image "alpine";
+
build = Store.Build.Image config.image;
args = command;
time = 0L;
diff = [];
(* TODO: extract with fetch *)
env = [];
cwd = "/";
+
user = (0, 0);
})
s
@@ fun (_, e) -> e
in
-
let build =
+
let build, env, (uid, gid) =
match entry.build with
-
| Store.Build.Image img -> Store.fetch ctx img
-
| Store.Build.Build cid -> cid
+
| Store.Build.Image img ->
+
let build, env, user = Store.fetch ctx img in
+
(build, env, Option.value ~default:(0, 0) user)
+
| Store.Build.Build cid -> (cid, entry.env, entry.user)
in
let hash_entry = { entry with build = Build build; args = command } in
let new_cid = Store.cid (Repr.to_string History.t hash_entry) in
···
try
let new_entry, diff =
with_rootfs @@ fun rootfs ->
-
let void =
-
Void.empty
-
|> Void.rootfs ~mode:entry.mode rootfs
-
|> Void.cwd entry.cwd
-
|> Void.exec ~env:entry.env
-
[
-
"/bin/ash";
-
"-c";
-
String.concat " " command ^ " && env > /shelter-env";
-
]
+
let spawn sw =
+
if config.no_runc then
+
let rootfs = Filename.concat rootfs "rootfs" in
+
let void =
+
Void.empty
+
|> Void.rootfs ~mode:entry.mode rootfs
+
|> Void.cwd entry.cwd
+
(* TODO: Support UIDs |> Void.uid 1000 *)
+
|> Void.exec ~env
+
[
+
config.shell;
+
"-c";
+
String.concat " " command ^ " && env > /tmp/shelter-env";
+
]
+
in
+
`Void (Void.spawn ~sw void |> Void.exit_status)
+
else
+
let config =
+
Runc.Json_config.
+
{
+
cwd = entry.cwd;
+
argv =
+
[
+
config.shell;
+
"-c";
+
String.concat " " command ^ " && env > /tmp/shelter-env";
+
];
+
hostname = "";
+
network = [];
+
user = (uid, gid);
+
env = entry.env;
+
entrypoint = None;
+
}
+
in
+
`Runc (Runc.spawn ~sw fs proc config rootfs)
in
Switch.run @@ fun sw ->
+
let res = spawn sw in
let start = Mtime_clock.now () in
-
let proc = Void.spawn ~sw void in
let res =
-
Void.exit_status proc |> Eio.Promise.await |> Void.to_eio_status
+
match res with
+
| `Runc r -> Eio.Process.await r
+
| `Void v -> Void.to_eio_status (Eio.Promise.await v)
in
let stop = Mtime_clock.now () in
-
(* Extract env *)
-
let env_path = Eio.Path.(fs / rootfs / "shelter-env") in
-
let env = Eio.Path.(load env_path) |> String.split_on_char '\n' in
-
Eio.Path.unlink env_path;
-
let cwd =
-
List.find_map
-
(fun v ->
-
match Astring.String.cut ~sep:"=" v with
-
| Some ("PWD", dir) -> Some dir
-
| _ -> None)
-
env
-
|> Option.value ~default:hash_entry.cwd
-
in
let span = Mtime.span start stop in
let time = Mtime.Span.to_uint64_ns span in
(* Add command to history regardless of exit status *)
let _ : (unit, string) result =
LNoise.history_add (String.concat " " command)
in
-
if res = `Exited 0 then
+
if res = `Exited 0 then (
+
(* Extract env *)
+
let env_path =
+
Eio.Path.(fs / rootfs / "rootfs" / "tmp" / "shelter-env")
+
in
+
let env =
+
Eio.Path.(load env_path)
+
|> String.split_on_char '\n'
+
|> List.filter (fun s -> not (String.equal "" s))
+
in
+
Eio.Path.unlink env_path;
+
let cwd =
+
List.find_map
+
(fun v ->
+
match Astring.String.cut ~sep:"=" v with
+
| Some ("PWD", dir) -> Some dir
+
| _ -> None)
+
env
+
|> Option.value ~default:hash_entry.cwd
+
in
if entry.mode = RW then
-
Ok { hash_entry with build = Build new_cid; time; env; cwd }
-
else Ok { hash_entry with cwd; env }
+
Ok
+
{
+
hash_entry with
+
build = Build new_cid;
+
time;
+
env;
+
cwd;
+
user = (uid, gid);
+
}
+
else Ok { hash_entry with time; cwd; env; user = (uid, gid) })
else Error (Eio.Process.Child_error res)
in
match new_entry with
+1
src/lib/shelter/shelter_main.mli
···
time : int64;
env : string list;
cwd : string;
+
user : int * int;
diff : Diff.t;
}
[@@deriving repr]
+24 -7
src/lib/shelter/store.ml
···
in
Cid.v ~version:`Cidv1 ~base:`Base32 ~codec:`Raw ~hash
+
let not_empty s = not String.(equal empty s)
+
+
let get_uid_gid ~username rootfs =
+
let passwd =
+
Eio.Path.load Eio.Path.(rootfs / "etc" / "passwd")
+
|> String.split_on_char '\n'
+
|> List.map (String.split_on_char ':')
+
|> List.map (List.filter not_empty)
+
in
+
List.find_map
+
(function
+
| user :: _ :: uid :: gid :: _ when String.equal user username ->
+
Some (int_of_string uid, int_of_string gid)
+
| _ -> None)
+
passwd
+
let fetch t image =
let cid = cid image in
let cids = cid |> Cid.to_string in
let dataset = Datasets.build t.pool cids in
let dir = Eio.Path.(t.fs / ("/" ^ (Datasets.build t.pool cids :> string))) in
-
if Zfs.exists t.zfs (dataset :> string) Zfs.Types.filesystem then cid
-
else (
-
create_and_mount t dataset;
-
let _dir : string = Fetch.get_image ~dir ~proc:t.proc image in
-
snapshot t (Datasets.snapshot dataset);
-
cid)
+
create_and_mount t dataset;
+
let _dir : string = Fetch.get_image ~dir ~proc:t.proc image in
+
snapshot t (Datasets.snapshot dataset);
+
let username = Fetch.get_user t.proc image in
+
( cid,
+
Fetch.get_env t.proc image,
+
get_uid_gid ~username Eio.Path.(dir / "rootfs") )
module Run = struct
let with_build t cid fn =
let ds = Datasets.build t.pool (Cid.to_string cid) in
Fun.protect ~finally:(fun () -> unmount_dataset t ds) @@ fun () ->
mount_dataset t ds;
-
fn ("/" ^ (ds :> string) ^ "/rootfs")
+
fn ("/" ^ (ds :> string))
let with_clone t ~src new_cid fn =
let ds = Datasets.build t.pool (Cid.to_string src) in
+19 -2
vendor/void/src/void.ml
···
args : string list;
env : string list;
cwd : string;
+
uid : int;
+
(* TODO: gid *)
rootfs : (string * mode) option;
mounts : mount list;
}
···
(action_pivot_root, new_root, new_root_flags, tmpfs, mounts)));
}
+
external action_setuid : unit -> Fork_action.fork_fn
+
= "void_fork_setuid"
+
+
let action_setuid = action_setuid ()
+
+
let setuid (uid : int) = Fork_action.
+
{
+
run =
+
(fun k ->
+
k
+
(Obj.repr
+
(action_setuid, uid)));
+
}
+
external action_map_uid_gid : unit -> Fork_action.fork_fn
= "void_fork_map_uid_gid"
···
type path = string
-
let empty = { args = []; env = []; rootfs = None; mounts = []; cwd = "/" }
+
let empty = { args = []; env = []; rootfs = None; mounts = []; cwd = "/"; uid = 0 }
let actions v : Fork_action.t list =
let root, tmpfs, root_mode =
···
let mounts = pivot_root root root_flags tmpfs mounts in
let uid, gid = Unix.(getuid (), getgid ()) in
let user_namespace = map_uid_gid ~uid ~gid in
-
[ user_namespace; mounts; Process.Fork_action.chdir v.cwd; e ]
+
[ user_namespace; mounts; setuid v.uid; Process.Fork_action.chdir v.cwd; e ]
let rootfs ~mode path v = { v with rootfs = Some (path, mode) }
let cwd cwd v = { v with cwd }
+
let uid uid v = { v with uid }
let exec ?(env=[]) args v = { v with args; env }
let mount ~mode ~src ~tgt v =
+3
vendor/void/src/void.mli
···
val cwd : string -> void -> void
(** Set the current working directory *)
+
val uid : int -> void -> void
+
(** Set the UID *)
+
val exec : ?env:string list -> string list -> void -> void
(** Make a void configuration ready to be spawned *)
+22 -4
vendor/void/src/void_action.c
···
return Val_fork_fn (action_map_uid_gid);
}
+
static void
+
action_setuid (int errors, value v_config)
+
{
+
value v_uid = Field(v_config, 1);
+
+
// if (setuid(1000)) {
+
// eio_unix_fork_error (errors, "setuid", strerror (errno));
+
// _exit (1);
+
// }
+
}
+
+
// SETUID
+
CAMLprim value
+
void_fork_setuid (value v_unit)
+
{
+
return Val_fork_fn (action_setuid);
+
}
+
// PIVOT ROOT
//
static int
···
//}
if (mount ("tmpfs", new_root, "tmpfs", 0, NULL) <= -1)
-
{
-
eio_unix_fork_error (errors, "pivot_root-tmpfs", strerror (errno));
-
_exit (1);
-
}
+
{
+
eio_unix_fork_error (errors, "pivot_root-tmpfs", strerror (errno));
+
_exit (1);
+
}
}
else
{