commit 0e5e4f32be2f11245205845aef1f686abb2ddef3 · bretton.dev/coves-mobile

+7 -2

lib/providers/comments_provider.dart

···

       24
       24
        
         }) : _voteProvider = voteProvider,

     

       25
       25
        
              _voteService = voteService {

     

       26
       26
        
           // Use injected service (for testing) or create new one (for production)

     

       27
       27
       -
           // Pass token getter to API service for automatic fresh token retrieval

     

       27
       27
       +
           // Pass token getter, refresh handler, and sign out handler to API service

     

       28
       28
       +
           // for automatic fresh token retrieval and automatic token refresh on 401

     

       28
       29
        
           _apiService =

     

       29
       30
        
               apiService ??

     

       30
       30
       -
               CovesApiService(tokenGetter: _authProvider.getAccessToken);

     

       31
       31
       +
               CovesApiService(

     

       32
       32
       +
                 tokenGetter: _authProvider.getAccessToken,

     

       33
       33
       +
                 tokenRefresher: _authProvider.refreshToken,

     

       34
       34
       +
                 signOutHandler: _authProvider.signOut,

     

       35
       35
       +
               );

     

       31
       36
        
       

     

       32
       37
        
           // Track initial auth state

     

       33
       38
        
           _wasAuthenticated = _authProvider.isAuthenticated;

+7 -2

lib/providers/feed_provider.dart

···

       24
       24
        
         }) : _voteProvider = voteProvider,

     

       25
       25
        
              _voteService = voteService {

     

       26
       26
        
           // Use injected service (for testing) or create new one (for production)

     

       27
       27
       -
           // Pass token getter to API service for automatic fresh token retrieval

     

       27
       27
       +
           // Pass token getter, refresh handler, and sign out handler to API service

     

       28
       28
       +
           // for automatic fresh token retrieval and automatic token refresh on 401

     

       28
       29
        
           _apiService =

     

       29
       30
        
               apiService ??

     

       30
       30
       -
               CovesApiService(tokenGetter: _authProvider.getAccessToken);

     

       31
       31
       +
               CovesApiService(

     

       32
       32
       +
                 tokenGetter: _authProvider.getAccessToken,

     

       33
       33
       +
                 tokenRefresher: _authProvider.refreshToken,

     

       34
       34
       +
                 signOutHandler: _authProvider.signOut,

     

       35
       35
       +
               );

     

       31
       36
        
       

     

       32
       37
        
           // Track initial auth state

     

       33
       38
        
           _wasAuthenticated = _authProvider.isAuthenticated;

+5 -3

test/providers/comments_provider_test.dart

···

       399
       399
        
                 refresh: true,

     

       400
       400
        
               );

     

       401
       401
        
       

     

       402
       402
       -
               // Try to load again while still loading

     

       402
       402
       +
               // Try to load again while still loading - should schedule a refresh

     

       403
       403
        
               await commentsProvider.loadComments(

     

       404
       404
        
                 postUri: testPostUri,

     

       405
       405
        
                 refresh: true,

     

       406
       406
        
               );

     

       407
       407
        
       

     

       408
       408
        
               await firstFuture;

     

       409
       409
       +
               // Wait a bit for the pending refresh to execute

     

       410
       410
       +
               await Future.delayed(const Duration(milliseconds: 200));

     

       409
       411
        
       

     

       410
       410
       -
               // Should only have called API once

     

       412
       412
       +
               // Should have called API twice - once for initial load, once for pending refresh

     

       411
       413
        
               verify(

     

       412
       414
        
                 mockApiService.getComments(

     

       413
       415
        
                   postUri: anyNamed('postUri'),

     
···

       417
       419
        
                   limit: anyNamed('limit'),

     

       418
       420
        
                   cursor: anyNamed('cursor'),

     

       419
       421
        
                 ),

     

       420
       420
       -
               ).called(1);

     

       422
       422
       +
               ).called(2);

     

       421
       423
        
             });

     

       422
       424
        
       

     

       423
       425
        
             test('should load vote state when authenticated', () async {

+14 -6

test/providers/comments_provider_test.mocks.dart

···

       108
       108
        
                 as _i6.Future<void>);

     

       109
       109
        
       

     

       110
       110
        
         @override

     

       111
       111
       -
         void clearError() => super.noSuchMethod(

     

       112
       112
       -
           Invocation.method(#clearError, []),

     

       113
       113
       -
           returnValueForMissingStub: null,

     

       114
       114
       -
         );

     

       111
       111
       +
         _i6.Future<bool> refreshToken() =>

     

       112
       112
       +
             (super.noSuchMethod(

     

       113
       113
       +
                   Invocation.method(#refreshToken, []),

     

       114
       114
       +
                   returnValue: _i6.Future<bool>.value(false),

     

       115
       115
       +
                 )

     

       116
       116
       +
                 as _i6.Future<bool>);

     

       115
       117
        
       

     

       116
       118
        
         @override

     

       117
       117
       -
         void dispose() => super.noSuchMethod(

     

       118
       118
       -
           Invocation.method(#dispose, []),

     

       119
       119
       +
         void clearError() => super.noSuchMethod(

     

       120
       120
       +
           Invocation.method(#clearError, []),

     

       119
       121
        
           returnValueForMissingStub: null,

     

       120
       122
        
         );

     

       121
       123
        
       

     
···

       128
       130
        
         @override

     

       129
       131
        
         void removeListener(_i7.VoidCallback? listener) => super.noSuchMethod(

     

       130
       132
        
           Invocation.method(#removeListener, [listener]),

     

       133
       133
       +
           returnValueForMissingStub: null,

     

       134
       134
       +
         );

     

       135
       135
       +
       

     

       136
       136
       +
         @override

     

       137
       137
       +
         void dispose() => super.noSuchMethod(

     

       138
       138
       +
           Invocation.method(#dispose, []),

     

       131
       139
        
           returnValueForMissingStub: null,

     

       132
       140
        
         );

     

       133
       141

+14 -6

test/providers/feed_provider_test.mocks.dart

···

       101
       101
        
                 as _i5.Future<void>);

     

       102
       102
        
       

     

       103
       103
        
         @override

     

       104
       104
       -
         void clearError() => super.noSuchMethod(

     

       105
       105
       -
           Invocation.method(#clearError, []),

     

       106
       106
       -
           returnValueForMissingStub: null,

     

       107
       107
       -
         );

     

       104
       104
       +
         _i5.Future<bool> refreshToken() =>

     

       105
       105
       +
             (super.noSuchMethod(

     

       106
       106
       +
                   Invocation.method(#refreshToken, []),

     

       107
       107
       +
                   returnValue: _i5.Future<bool>.value(false),

     

       108
       108
       +
                 )

     

       109
       109
       +
                 as _i5.Future<bool>);

     

       108
       110
        
       

     

       109
       111
        
         @override

     

       110
       110
       -
         void dispose() => super.noSuchMethod(

     

       111
       111
       -
           Invocation.method(#dispose, []),

     

       112
       112
       +
         void clearError() => super.noSuchMethod(

     

       113
       113
       +
           Invocation.method(#clearError, []),

     

       112
       114
        
           returnValueForMissingStub: null,

     

       113
       115
        
         );

     

       114
       116
        
       

     
···

       121
       123
        
         @override

     

       122
       124
        
         void removeListener(_i6.VoidCallback? listener) => super.noSuchMethod(

     

       123
       125
        
           Invocation.method(#removeListener, [listener]),

     

       126
       126
       +
           returnValueForMissingStub: null,

     

       127
       127
       +
         );

     

       128
       128
       +
       

     

       129
       129
       +
         @override

     

       130
       130
       +
         void dispose() => super.noSuchMethod(

     

       131
       131
       +
           Invocation.method(#dispose, []),

     

       124
       132
        
           returnValueForMissingStub: null,

     

       125
       133
        
         );

     

       126
       134

+14 -6

test/providers/vote_provider_test.mocks.dart

···

       142
       142
        
                 as _i3.Future<void>);

     

       143
       143
        
       

     

       144
       144
        
         @override

     

       145
       145
       -
         void clearError() => super.noSuchMethod(

     

       146
       146
       -
           Invocation.method(#clearError, []),

     

       147
       147
       -
           returnValueForMissingStub: null,

     

       148
       148
       -
         );

     

       145
       145
       +
         _i3.Future<bool> refreshToken() =>

     

       146
       146
       +
             (super.noSuchMethod(

     

       147
       147
       +
                   Invocation.method(#refreshToken, []),

     

       148
       148
       +
                   returnValue: _i3.Future<bool>.value(false),

     

       149
       149
       +
                 )

     

       150
       150
       +
                 as _i3.Future<bool>);

     

       149
       151
        
       

     

       150
       152
        
         @override

     

       151
       151
       -
         void dispose() => super.noSuchMethod(

     

       152
       152
       -
           Invocation.method(#dispose, []),

     

       153
       153
       +
         void clearError() => super.noSuchMethod(

     

       154
       154
       +
           Invocation.method(#clearError, []),

     

       153
       155
        
           returnValueForMissingStub: null,

     

       154
       156
        
         );

     

       155
       157
        
       

     
···

       162
       164
        
         @override

     

       163
       165
        
         void removeListener(_i5.VoidCallback? listener) => super.noSuchMethod(

     

       164
       166
        
           Invocation.method(#removeListener, [listener]),

     

       167
       167
       +
           returnValueForMissingStub: null,

     

       168
       168
       +
         );

     

       169
       169
       +
       

     

       170
       170
       +
         @override

     

       171
       171
       +
         void dispose() => super.noSuchMethod(

     

       172
       172
       +
           Invocation.method(#dispose, []),

     

       165
       173
        
           returnValueForMissingStub: null,

     

       166
       174
        
         );

     

       167
       175

+3 -7

test/test_helpers/mock_providers.dart

···

       1
       1
       -
       import 'package:atproto_oauth_flutter/atproto_oauth_flutter.dart';

     

       1
       1
       +
       import 'package:coves_flutter/models/coves_session.dart';

     

       2
       2
        
       import 'package:coves_flutter/providers/vote_provider.dart';

     

       3
       3
        
       import 'package:coves_flutter/services/vote_service.dart';

     

       4
       4
        
       import 'package:flutter/foundation.dart';

     
···

       10
       10
        
         String? _error;

     

       11
       11
        
         String? _did;

     

       12
       12
        
         String? _handle;

     

       13
       13
       -
         OAuthSession? _session;

     

       13
       13
       +
         CovesSession? _session;

     

       14
       14
        
       

     

       15
       15
        
         bool get isAuthenticated => _isAuthenticated;

     

       16
       16
        
         bool get isLoading => _isLoading;

     

       17
       17
        
         String? get error => _error;

     

       18
       18
        
         String? get did => _did;

     

       19
       19
        
         String? get handle => _handle;

     

       20
       20
       -
         OAuthSession? get session => _session;

     

       20
       20
       +
         CovesSession? get session => _session;

     

       21
       21
        
       

     

       22
       22
        
         void setAuthenticated({required bool value, String? did}) {

     

       23
       23
        
           _isAuthenticated = value;

     
···

       46
       46
        
       

     

       47
       47
        
         Future<String?> getAccessToken() async {

     

       48
       48
        
           return _isAuthenticated ? 'mock_access_token' : null;

     

       49
       49
       -
         }

     

       50
       50
       -
       

     

       51
       51
       -
         String? getPdsUrl() {

     

       52
       52
       -
           return _isAuthenticated ? 'https://mock.pds.host' : null;

     

       53
       49
        
         }

     

       54
       50
        
       

     

       55
       51
        
         void clearError() {