commit dab2e0cef5083904f77dcddcb2fe8b2eb890bd5c · bretton.dev/coves-mobile

+16 -19

lib/main.dart

···

       8
       8
        
       import 'constants/app_colors.dart';

     

       9
       9
        
       import 'models/post.dart';

     

       10
       10
        
       import 'providers/auth_provider.dart';

     

       11
       11
       -
       import 'providers/comments_provider.dart';

     

       12
       11
        
       import 'providers/feed_provider.dart';

     

       13
       12
        
       import 'providers/vote_provider.dart';

     

       14
       13
        
       import 'screens/auth/login_screen.dart';

     
···

       16
       15
        
       import 'screens/home/post_detail_screen.dart';

     

       17
       16
        
       import 'screens/landing_screen.dart';

     

       18
       17
        
       import 'services/comment_service.dart';

     

       18
       18
       +
       import 'services/comments_provider_cache.dart';

     

       19
       19
        
       import 'services/streamable_service.dart';

     

       20
       20
        
       import 'services/vote_service.dart';

     

       21
       21
        
       import 'widgets/loading_error_states.dart';

     
···

       75
       75
        
                   return previous ?? FeedProvider(auth, voteProvider: vote);

     

       76
       76
        
                 },

     

       77
       77
        
               ),

     

       78
       78
       -
               ChangeNotifierProxyProvider2<

     

       79
       79
       -
                 AuthProvider,

     

       80
       80
       -
                 VoteProvider,

     

       81
       81
       -
                 CommentsProvider

     

       82
       82
       -
               >(

     

       83
       83
       -
                 create:

     

       84
       84
       -
                     (context) => CommentsProvider(

     

       85
       85
       -
                       authProvider,

     

       86
       86
       -
                       voteProvider: context.read<VoteProvider>(),

     

       87
       87
       -
                       commentService: commentService,

     

       88
       88
       -
                     ),

     

       78
       78
       +
               // CommentsProviderCache manages per-post CommentsProvider instances

     

       79
       79
       +
               // with LRU eviction and sign-out cleanup

     

       80
       80
       +
               ProxyProvider2<AuthProvider, VoteProvider, CommentsProviderCache>(

     

       81
       81
       +
                 create: (context) => CommentsProviderCache(

     

       82
       82
       +
                   authProvider: authProvider,

     

       83
       83
       +
                   voteProvider: context.read<VoteProvider>(),

     

       84
       84
       +
                   commentService: commentService,

     

       85
       85
       +
                 ),

     

       89
       86
        
                 update: (context, auth, vote, previous) {

     

       90
       90
       -
                   // Reuse existing provider to maintain state across rebuilds

     

       91
       91
       -
                   return previous ??

     

       92
       92
       -
                       CommentsProvider(

     

       93
       93
       -
                         auth,

     

       94
       94
       -
                         voteProvider: vote,

     

       95
       95
       -
                         commentService: commentService,

     

       96
       96
       -
                       );

     

       87
       87
       +
                   // Reuse existing cache

     

       88
       88
       +
                   return previous ?? CommentsProviderCache(

     

       89
       89
       +
                     authProvider: auth,

     

       90
       90
       +
                     voteProvider: vote,

     

       91
       91
       +
                     commentService: commentService,

     

       92
       92
       +
                   );

     

       97
       93
        
                 },

     

       94
       94
       +
                 dispose: (_, cache) => cache.dispose(),

     

       98
       95
        
               ),

     

       99
       96
        
               // StreamableService for video embeds

     

       100
       97
        
               Provider<StreamableService>(create: (_) => StreamableService()),

+122 -111

lib/providers/comments_provider.dart

···

       12
       12
        
       /// Comments Provider

     

       13
       13
        
       ///

     

       14
       14
        
       /// Manages comment state and fetching logic for a specific post.

     

       15
       15
       -
       /// Supports sorting (hot/top/new), pagination, and vote integration.

     

       15
       15
       +
       /// Each provider instance is bound to a single post (immutable postUri/postCid).

     

       16
       16
       +
       /// Supports sorting (hot/top/new), pagination, vote integration, scroll position,

     

       17
       17
       +
       /// and draft text preservation.

     

       18
       18
       +
       ///

     

       19
       19
       +
       /// IMPORTANT: Provider instances are managed by CommentsProviderCache which

     

       20
       20
       +
       /// handles LRU eviction and sign-out cleanup. Do not create directly in widgets.

     

       16
       21
        
       ///

     

       17
       22
        
       /// IMPORTANT: Accepts AuthProvider reference to fetch fresh access

     

       18
       23
        
       /// tokens before each authenticated request (critical for atProto OAuth

     
···

       20
       25
        
       class CommentsProvider with ChangeNotifier {

     

       21
       26
        
         CommentsProvider(

     

       22
       27
        
           this._authProvider, {

     

       28
       28
       +
           required String postUri,

     

       29
       29
       +
           required String postCid,

     

       23
       30
        
           CovesApiService? apiService,

     

       24
       31
        
           VoteProvider? voteProvider,

     

       25
       32
        
           CommentService? commentService,

     

       26
       26
       -
         }) : _voteProvider = voteProvider,

     

       33
       33
       +
         }) : _postUri = postUri,

     

       34
       34
       +
              _postCid = postCid,

     

       35
       35
       +
              _voteProvider = voteProvider,

     

       27
       36
        
              _commentService = commentService {

     

       28
       37
        
           // Use injected service (for testing) or create new one (for production)

     

       29
       38
        
           // Pass token getter, refresh handler, and sign out handler to API service

     
···

       35
       44
        
                 tokenRefresher: _authProvider.refreshToken,

     

       36
       45
        
                 signOutHandler: _authProvider.signOut,

     

       37
       46
        
               );

     

       38
       38
       -
       

     

       39
       39
       -
           // Track initial auth state

     

       40
       40
       -
           _wasAuthenticated = _authProvider.isAuthenticated;

     

       41
       41
       -
       

     

       42
       42
       -
           // Listen to auth state changes and clear comments on sign-out

     

       43
       43
       -
           _authProvider.addListener(_onAuthChanged);

     

       44
       47
        
         }

     

       45
       48
        
       

     

       46
       49
        
         /// Maximum comment length in characters (matches backend limit)

     

       47
       50
        
         /// Note: This counts Unicode grapheme clusters, so emojis count correctly

     

       48
       51
        
         static const int maxCommentLength = 10000;

     

       49
       52
        
       

     

       50
       50
       -
         /// Handle authentication state changes

     

       51
       51
       -
         ///

     

       52
       52
       -
         /// Clears comment state when user signs out to prevent privacy issues.

     

       53
       53
       -
         void _onAuthChanged() {

     

       54
       54
       -
           final isAuthenticated = _authProvider.isAuthenticated;

     

       55
       55
       -
       

     

       56
       56
       -
           // Only clear if transitioning from authenticated → unauthenticated

     

       57
       57
       -
           if (_wasAuthenticated && !isAuthenticated && _comments.isNotEmpty) {

     

       58
       58
       -
             if (kDebugMode) {

     

       59
       59
       -
               debugPrint('🔒 User signed out - clearing comments');

     

       60
       60
       -
             }

     

       61
       61
       -
             reset();

     

       62
       62
       -
           }

     

       63
       63
       -
       

     

       64
       64
       -
           // Update tracked state

     

       65
       65
       -
           _wasAuthenticated = isAuthenticated;

     

       66
       66
       -
         }

     

       53
       53
       +
         /// Default staleness threshold for background refresh

     

       54
       54
       +
         static const Duration stalenessThreshold = Duration(minutes: 5);

     

       67
       55
        
       

     

       68
       56
        
         final AuthProvider _authProvider;

     

       69
       57
        
         late final CovesApiService _apiService;

     

       70
       58
        
         final VoteProvider? _voteProvider;

     

       71
       59
        
         final CommentService? _commentService;

     

       72
       60
        
       

     

       73
       73
       -
         // Track previous auth state to detect transitions

     

       74
       74
       -
         bool _wasAuthenticated = false;

     

       61
       61
       +
         // Post context - immutable per provider instance

     

       62
       62
       +
         final String _postUri;

     

       63
       63
       +
         final String _postCid;

     

       75
       64
        
       

     

       76
       65
        
         // Comment state

     

       77
       66
        
         List<ThreadViewComment> _comments = [];

     
···

       84
       73
        
         // Collapsed thread state - stores URIs of collapsed comments

     

       85
       74
        
         final Set<String> _collapsedComments = {};

     

       86
       75
        
       

     

       87
       87
       -
         // Current post being viewed

     

       88
       88
       -
         String? _postUri;

     

       89
       89
       -
         String? _postCid;

     

       76
       76
       +
         // Scroll position state (replaces ScrollStateService for this post)

     

       77
       77
       +
         double _scrollPosition = 0;

     

       78
       78
       +
       

     

       79
       79
       +
         // Draft reply text - stored per-parent-URI (null key = top-level reply to post)

     

       80
       80
       +
         // This allows users to have separate drafts for different comments within the same post

     

       81
       81
       +
         final Map<String?, String> _drafts = {};

     

       82
       82
       +
       

     

       83
       83
       +
         // Staleness tracking for background refresh

     

       84
       84
       +
         DateTime? _lastRefreshTime;

     

       90
       85
        
       

     

       91
       86
        
         // Comment configuration

     

       92
       87
        
         String _sort = 'hot';

     
···

       99
       94
        
         Timer? _timeUpdateTimer;

     

       100
       95
        
         final ValueNotifier<DateTime?> _currentTimeNotifier = ValueNotifier(null);

     

       101
       96
        
       

     

       97
       97
       +
         bool _isDisposed = false;

     

       98
       98
       +
       

     

       99
       99
       +
         void _safeNotifyListeners() {

     

       100
       100
       +
           if (_isDisposed) return;

     

       101
       101
       +
           notifyListeners();

     

       102
       102
       +
         }

     

       103
       103
       +
       

     

       102
       104
        
         // Getters

     

       105
       105
       +
         String get postUri => _postUri;

     

       106
       106
       +
         String get postCid => _postCid;

     

       103
       107
        
         List<ThreadViewComment> get comments => _comments;

     

       104
       108
        
         bool get isLoading => _isLoading;

     

       105
       109
        
         bool get isLoadingMore => _isLoadingMore;

     
···

       109
       113
        
         String? get timeframe => _timeframe;

     

       110
       114
        
         ValueNotifier<DateTime?> get currentTimeNotifier => _currentTimeNotifier;

     

       111
       115
        
         Set<String> get collapsedComments => Set.unmodifiable(_collapsedComments);

     

       116
       116
       +
         double get scrollPosition => _scrollPosition;

     

       117
       117
       +
         DateTime? get lastRefreshTime => _lastRefreshTime;

     

       118
       118
       +
       

     

       119
       119
       +
         /// Get draft text for a specific parent URI

     

       120
       120
       +
         ///

     

       121
       121
       +
         /// [parentUri] - URI of parent comment (null for top-level post reply)

     

       122
       122
       +
         /// Returns the draft text, or empty string if no draft exists

     

       123
       123
       +
         String getDraft({String? parentUri}) => _drafts[parentUri] ?? '';

     

       124
       124
       +
       

     

       125
       125
       +
         /// Legacy getters for backward compatibility

     

       126
       126
       +
         /// @deprecated Use getDraft(parentUri: ...) instead

     

       127
       127
       +
         String get draftText => _drafts.values.firstOrNull ?? '';

     

       128
       128
       +
         String? get draftParentUri => _drafts.keys.firstOrNull;

     

       129
       129
       +
       

     

       130
       130
       +
         /// Check if cached data is stale and should be refreshed in background

     

       131
       131
       +
         bool get isStale {

     

       132
       132
       +
           if (_lastRefreshTime == null) {

     

       133
       133
       +
             return true;

     

       134
       134
       +
           }

     

       135
       135
       +
           return DateTime.now().difference(_lastRefreshTime!) > stalenessThreshold;

     

       136
       136
       +
         }

     

       137
       137
       +
       

     

       138
       138
       +
         /// Save scroll position (called on every scroll event)

     

       139
       139
       +
         void saveScrollPosition(double position) {

     

       140
       140
       +
           _scrollPosition = position;

     

       141
       141
       +
           // No notifyListeners - this is passive state save

     

       142
       142
       +
         }

     

       143
       143
       +
       

     

       144
       144
       +
         /// Save draft reply text

     

       145
       145
       +
         ///

     

       146
       146
       +
         /// [text] - The draft text content

     

       147
       147
       +
         /// [parentUri] - URI of parent comment (null for top-level post reply)

     

       148
       148
       +
         ///

     

       149
       149
       +
         /// Each parent URI gets its own draft, so switching between replies

     

       150
       150
       +
         /// preserves drafts for each context.

     

       151
       151
       +
         void saveDraft(String text, {String? parentUri}) {

     

       152
       152
       +
           if (text.trim().isEmpty) {

     

       153
       153
       +
             // Remove empty drafts to avoid clutter

     

       154
       154
       +
             _drafts.remove(parentUri);

     

       155
       155
       +
           } else {

     

       156
       156
       +
             _drafts[parentUri] = text;

     

       157
       157
       +
           }

     

       158
       158
       +
           // No notifyListeners - this is passive state save

     

       159
       159
       +
         }

     

       160
       160
       +
       

     

       161
       161
       +
         /// Clear draft text for a specific parent (call after successful submission)

     

       162
       162
       +
         ///

     

       163
       163
       +
         /// [parentUri] - URI of parent comment (null for top-level post reply)

     

       164
       164
       +
         void clearDraft({String? parentUri}) {

     

       165
       165
       +
           _drafts.remove(parentUri);

     

       166
       166
       +
         }

     

       112
       167
        
       

     

       113
       168
        
         /// Toggle collapsed state for a comment thread

     

       114
       169
        
         ///

     
···

       120
       175
        
           } else {

     

       121
       176
        
             _collapsedComments.add(uri);

     

       122
       177
        
           }

     

       123
       123
       -
           notifyListeners();

     

       178
       178
       +
           _safeNotifyListeners();

     

       124
       179
        
         }

     

       125
       180
        
       

     

       126
       181
        
         /// Check if a specific comment is collapsed

     
···

       161
       216
        
           }

     

       162
       217
        
         }

     

       163
       218
        
       

     

       164
       164
       -
         /// Load comments for a specific post

     

       219
       219
       +
         /// Load comments for this provider's post

     

       165
       220
        
         ///

     

       166
       221
        
         /// Parameters:

     

       167
       167
       -
         /// - [postUri]: AT-URI of the post

     

       168
       168
       -
         /// - [postCid]: CID of the post (needed for creating comments)

     

       169
       169
       -
         /// - [refresh]: Whether to refresh from the beginning

     

       170
       170
       -
         Future<void> loadComments({

     

       171
       171
       -
           required String postUri,

     

       172
       172
       -
           required String postCid,

     

       173
       173
       -
           bool refresh = false,

     

       174
       174
       -
         }) async {

     

       175
       175
       -
           // If loading for a different post, reset state

     

       176
       176
       -
           if (postUri != _postUri) {

     

       177
       177
       -
             reset();

     

       178
       178
       -
             _postUri = postUri;

     

       179
       179
       -
             _postCid = postCid;

     

       180
       180
       -
           }

     

       181
       181
       -
       

     

       222
       222
       +
         /// - [refresh]: Whether to refresh from the beginning (true) or paginate (false)

     

       223
       223
       +
         Future<void> loadComments({bool refresh = false}) async {

     

       182
       224
        
           // If already loading, schedule a refresh to happen after current load

     

       183
       225
        
           if (_isLoading || _isLoadingMore) {

     

       184
       226
        
             if (refresh) {

     
···

       200
       242
        
             } else {

     

       201
       243
        
               _isLoadingMore = true;

     

       202
       244
        
             }

     

       203
       203
       -
             notifyListeners();

     

       245
       245
       +
             _safeNotifyListeners();

     

       204
       246
        
       

     

       205
       247
        
             if (kDebugMode) {

     

       206
       206
       -
               debugPrint('📡 Fetching comments: sort=$_sort, postUri=$postUri');

     

       248
       248
       +
               debugPrint('📡 Fetching comments: sort=$_sort, postUri=$_postUri');

     

       207
       249
        
             }

     

       208
       250
        
       

     

       209
       251
        
             final response = await _apiService.getComments(

     

       210
       210
       -
               postUri: postUri,

     

       252
       252
       +
               postUri: _postUri,

     

       211
       253
        
               sort: _sort,

     

       212
       254
        
               timeframe: _timeframe,

     

       213
       255
        
               cursor: refresh ? null : _cursor,

     

       214
       256
        
             );

     

       215
       257
        
       

     

       258
       258
       +
             if (_isDisposed) return;

     

       259
       259
       +
       

     

       216
       260
        
             // Only update state after successful fetch

     

       217
       261
        
             if (refresh) {

     

       218
       262
        
               _comments = response.comments;

     

       263
       263
       +
               _lastRefreshTime = DateTime.now();

     

       219
       264
        
             } else {

     

       220
       265
        
               // Create new list instance to trigger rebuilds

     

       221
       266
        
               _comments = [..._comments, ...response.comments];

     
···

       246
       291
        
               startTimeUpdates();

     

       247
       292
        
             }

     

       248
       293
        
           } on Exception catch (e) {

     

       294
       294
       +
             if (_isDisposed) return;

     

       249
       295
        
             _error = e.toString();

     

       250
       296
        
             if (kDebugMode) {

     

       251
       297
        
               debugPrint('❌ Failed to fetch comments: $e');

     

       252
       298
        
             }

     

       253
       299
        
           } finally {

     

       300
       300
       +
             if (_isDisposed) return;

     

       254
       301
        
             _isLoading = false;

     

       255
       302
        
             _isLoadingMore = false;

     

       256
       256
       -
             notifyListeners();

     

       303
       303
       +
             _safeNotifyListeners();

     

       257
       304
        
       

     

       258
       305
        
             // If a refresh was scheduled during this load, execute it now

     

       259
       259
       -
             if (_pendingRefresh && _postUri != null) {

     

       306
       306
       +
             if (_pendingRefresh) {

     

       260
       307
        
               if (kDebugMode) {

     

       261
       308
        
                 debugPrint('🔄 Executing pending refresh');

     

       262
       309
        
               }

     

       263
       310
        
               _pendingRefresh = false;

     

       264
       311
        
               // Schedule refresh without awaiting to avoid blocking

     

       265
       312
        
               // This is intentional - we want the refresh to happen asynchronously

     

       266
       266
       -
               unawaited(

     

       267
       267
       -
                 loadComments(postUri: _postUri!, postCid: _postCid!, refresh: true),

     

       268
       268
       -
               );

     

       313
       313
       +
               unawaited(loadComments(refresh: true));

     

       269
       314
        
             }

     

       270
       315
        
           }

     

       271
       316
        
         }

     
···

       274
       319
        
         ///

     

       275
       320
        
         /// Reloads comments from the beginning for the current post.

     

       276
       321
        
         Future<void> refreshComments() async {

     

       277
       277
       -
           if (_postUri == null || _postCid == null) {

     

       278
       278
       -
             if (kDebugMode) {

     

       279
       279
       -
               debugPrint('⚠️ Cannot refresh - no post loaded');

     

       280
       280
       -
             }

     

       281
       281
       -
             return;

     

       282
       282
       -
           }

     

       283
       283
       -
           await loadComments(postUri: _postUri!, postCid: _postCid!, refresh: true);

     

       322
       322
       +
           await loadComments(refresh: true);

     

       284
       323
        
         }

     

       285
       324
        
       

     

       286
       325
        
         /// Load more comments (pagination)

     

       287
       326
        
         Future<void> loadMoreComments() async {

     

       288
       288
       -
           if (!_hasMore || _isLoadingMore || _postUri == null || _postCid == null) {

     

       327
       327
       +
           if (!_hasMore || _isLoadingMore) {

     

       289
       328
        
             return;

     

       290
       329
        
           }

     

       291
       291
       -
           await loadComments(postUri: _postUri!, postCid: _postCid!);

     

       330
       330
       +
           await loadComments();

     

       292
       331
        
         }

     

       293
       332
        
       

     

       294
       333
        
         /// Change sort order

     
···

       305
       344
        
       

     

       306
       345
        
           final previousSort = _sort;

     

       307
       346
        
           _sort = newSort;

     

       308
       308
       -
           notifyListeners();

     

       347
       347
       +
           _safeNotifyListeners();

     

       309
       348
        
       

     

       310
       349
        
           // Reload comments with new sort

     

       311
       311
       -
           if (_postUri != null && _postCid != null) {

     

       312
       312
       -
             try {

     

       313
       313
       -
               await loadComments(

     

       314
       314
       -
                 postUri: _postUri!,

     

       315
       315
       -
                 postCid: _postCid!,

     

       316
       316
       -
                 refresh: true,

     

       317
       317
       -
               );

     

       318
       318
       -
               return true;

     

       319
       319
       -
             } on Exception catch (e) {

     

       320
       320
       -
               // Revert to previous sort option on failure

     

       321
       321
       -
               _sort = previousSort;

     

       322
       322
       -
               notifyListeners();

     

       350
       350
       +
           try {

     

       351
       351
       +
             await loadComments(refresh: true);

     

       352
       352
       +
             return true;

     

       353
       353
       +
           } on Exception catch (e) {

     

       354
       354
       +
             if (_isDisposed) return false;

     

       355
       355
       +
             // Revert to previous sort option on failure

     

       356
       356
       +
             _sort = previousSort;

     

       357
       357
       +
             _safeNotifyListeners();

     

       323
       358
        
       

     

       324
       324
       -
               if (kDebugMode) {

     

       325
       325
       -
                 debugPrint('Failed to apply sort option: $e');

     

       326
       326
       -
               }

     

       327
       327
       -
       

     

       328
       328
       -
               return false;

     

       359
       359
       +
             if (kDebugMode) {

     

       360
       360
       +
               debugPrint('Failed to apply sort option: $e');

     

       329
       361
        
             }

     

       330
       330
       -
           }

     

       331
       362
        
       

     

       332
       332
       -
           return true;

     

       363
       363
       +
             return false;

     

       364
       364
       +
           }

     

       333
       365
        
         }

     

       334
       366
        
       

     

       335
       367
        
         /// Vote on a comment

     
···

       415
       447
        
       

     

       416
       448
        
           if (_commentService == null) {

     

       417
       449
        
             throw ApiException('CommentService not available');

     

       418
       418
       -
           }

     

       419
       419
       -
       

     

       420
       420
       -
           if (_postUri == null || _postCid == null) {

     

       421
       421
       -
             throw ApiException('No post loaded - cannot create comment');

     

       422
       450
        
           }

     

       423
       451
        
       

     

       424
       452
        
           // Root is always the original post

     

       425
       425
       -
           final rootUri = _postUri!;

     

       426
       426
       -
           final rootCid = _postCid!;

     

       453
       453
       +
           final rootUri = _postUri;

     

       454
       454
       +
           final rootCid = _postCid;

     

       427
       455
        
       

     

       428
       456
        
           // Parent depends on whether this is a top-level or nested reply

     

       429
       457
        
           final String parentUri;

     
···

       492
       520
        
         /// Retry loading after error

     

       493
       521
        
         Future<void> retry() async {

     

       494
       522
        
           _error = null;

     

       495
       495
       -
           if (_postUri != null && _postCid != null) {

     

       496
       496
       -
             await loadComments(postUri: _postUri!, postCid: _postCid!, refresh: true);

     

       497
       497
       -
           }

     

       523
       523
       +
           await loadComments(refresh: true);

     

       498
       524
        
         }

     

       499
       525
        
       

     

       500
       526
        
         /// Clear error

     

       501
       527
        
         void clearError() {

     

       502
       528
        
           _error = null;

     

       503
       503
       -
           notifyListeners();

     

       504
       504
       -
         }

     

       505
       505
       -
       

     

       506
       506
       -
         /// Reset comment state

     

       507
       507
       -
         void reset() {

     

       508
       508
       -
           _comments = [];

     

       509
       509
       -
           _cursor = null;

     

       510
       510
       -
           _hasMore = true;

     

       511
       511
       -
           _error = null;

     

       512
       512
       -
           _isLoading = false;

     

       513
       513
       -
           _isLoadingMore = false;

     

       514
       514
       -
           _postUri = null;

     

       515
       515
       -
           _postCid = null;

     

       516
       516
       -
           _pendingRefresh = false;

     

       517
       517
       -
           _collapsedComments.clear();

     

       518
       518
       -
           notifyListeners();

     

       529
       529
       +
           _safeNotifyListeners();

     

       519
       530
        
         }

     

       520
       531
        
       

     

       521
       532
        
         @override

     

       522
       533
        
         void dispose() {

     

       534
       534
       +
           _isDisposed = true;

     

       523
       535
        
           // Stop time updates and cancel timer (also sets value to null)

     

       524
       536
        
           stopTimeUpdates();

     

       525
       525
       -
           // Remove auth listener to prevent memory leaks

     

       526
       526
       -
           _authProvider.removeListener(_onAuthChanged);

     

       537
       537
       +
           // Dispose API service

     

       527
       538
        
           _apiService.dispose();

     

       528
       539
        
           // Dispose the ValueNotifier last

     

       529
       540
        
           _currentTimeNotifier.dispose();

+217

lib/services/comments_provider_cache.dart

···

       1
       1
       +
       import 'dart:collection';

     

       2
       2
       +
       

     

       3
       3
       +
       import 'package:flutter/foundation.dart';

     

       4
       4
       +
       import '../providers/auth_provider.dart';

     

       5
       5
       +
       import '../providers/comments_provider.dart';

     

       6
       6
       +
       import '../providers/vote_provider.dart';

     

       7
       7
       +
       import 'comment_service.dart';

     

       8
       8
       +
       

     

       9
       9
       +
       /// Comments Provider Cache

     

       10
       10
       +
       ///

     

       11
       11
       +
       /// Manages cached CommentsProvider instances per post URI using LRU eviction.

     

       12
       12
       +
       /// Inspired by Thunder app's architecture for instant back navigation.

     

       13
       13
       +
       ///

     

       14
       14
       +
       /// Key features:

     

       15
       15
       +
       /// - One CommentsProvider per post URI

     

       16
       16
       +
       /// - LRU eviction (default: 15 most recent posts)

     

       17
       17
       +
       /// - Sign-out cleanup via AuthProvider listener

     

       18
       18
       +
       ///

     

       19
       19
       +
       /// Usage:

     

       20
       20
       +
       /// ```dart

     

       21
       21
       +
       /// final cache = context.read<CommentsProviderCache>();

     

       22
       22
       +
       /// final provider = cache.getProvider(

     

       23
       23
       +
       ///   postUri: post.uri,

     

       24
       24
       +
       ///   postCid: post.cid,

     

       25
       25
       +
       /// );

     

       26
       26
       +
       /// ```

     

       27
       27
       +
       class CommentsProviderCache {

     

       28
       28
       +
         CommentsProviderCache({

     

       29
       29
       +
           required AuthProvider authProvider,

     

       30
       30
       +
           required VoteProvider voteProvider,

     

       31
       31
       +
           required CommentService commentService,

     

       32
       32
       +
           this.maxSize = 15,

     

       33
       33
       +
         }) : _authProvider = authProvider,

     

       34
       34
       +
              _voteProvider = voteProvider,

     

       35
       35
       +
              _commentService = commentService {

     

       36
       36
       +
           _wasAuthenticated = _authProvider.isAuthenticated;

     

       37
       37
       +
           _authProvider.addListener(_onAuthChanged);

     

       38
       38
       +
         }

     

       39
       39
       +
       

     

       40
       40
       +
         final AuthProvider _authProvider;

     

       41
       41
       +
         final VoteProvider _voteProvider;

     

       42
       42
       +
         final CommentService _commentService;

     

       43
       43
       +
       

     

       44
       44
       +
         /// Maximum number of providers to cache

     

       45
       45
       +
         final int maxSize;

     

       46
       46
       +
       

     

       47
       47
       +
         /// LRU cache - LinkedHashMap maintains insertion order

     

       48
       48
       +
         /// Most recently accessed items are at the end

     

       49
       49
       +
         final LinkedHashMap<String, CommentsProvider> _cache = LinkedHashMap();

     

       50
       50
       +
       

     

       51
       51
       +
         /// Reference counts for "in-use" providers.

     

       52
       52
       +
         ///

     

       53
       53
       +
         /// Screens that hold onto a provider instance should call [acquireProvider]

     

       54
       54
       +
         /// and later [releaseProvider] to prevent LRU eviction from disposing a

     

       55
       55
       +
         /// provider that is still mounted in the navigation stack.

     

       56
       56
       +
         final Map<String, int> _refCounts = {};

     

       57
       57
       +
       

     

       58
       58
       +
         /// Track auth state for sign-out detection

     

       59
       59
       +
         bool _wasAuthenticated = false;

     

       60
       60
       +
       

     

       61
       61
       +
         /// Acquire (get or create) a CommentsProvider for a post.

     

       62
       62
       +
         ///

     

       63
       63
       +
         /// This "pins" the provider to avoid LRU eviction while in use.

     

       64
       64
       +
         /// Call [releaseProvider] when the consumer unmounts.

     

       65
       65
       +
         ///

     

       66
       66
       +
         /// If provider exists in cache, moves it to end (LRU touch).

     

       67
       67
       +
         /// If cache is full, evicts the oldest *unreferenced* provider before

     

       68
       68
       +
         /// creating a new one. If all providers are currently referenced, the cache

     

       69
       69
       +
         /// may temporarily exceed [maxSize] to avoid disposing active providers.

     

       70
       70
       +
         CommentsProvider acquireProvider({

     

       71
       71
       +
           required String postUri,

     

       72
       72
       +
           required String postCid,

     

       73
       73
       +
         }) {

     

       74
       74
       +
           final provider = _getOrCreateProvider(postUri: postUri, postCid: postCid);

     

       75
       75
       +
           _refCounts[postUri] = (_refCounts[postUri] ?? 0) + 1;

     

       76
       76
       +
           return provider;

     

       77
       77
       +
         }

     

       78
       78
       +
       

     

       79
       79
       +
         /// Release a previously acquired provider for a post.

     

       80
       80
       +
         ///

     

       81
       81
       +
         /// Once released, the provider becomes eligible for LRU eviction.

     

       82
       82
       +
         void releaseProvider(String postUri) {

     

       83
       83
       +
           final current = _refCounts[postUri];

     

       84
       84
       +
           if (current == null) {

     

       85
       85
       +
             return;

     

       86
       86
       +
           }

     

       87
       87
       +
       

     

       88
       88
       +
           if (current <= 1) {

     

       89
       89
       +
             _refCounts.remove(postUri);

     

       90
       90
       +
           } else {

     

       91
       91
       +
             _refCounts[postUri] = current - 1;

     

       92
       92
       +
           }

     

       93
       93
       +
       

     

       94
       94
       +
           _evictIfNeeded();

     

       95
       95
       +
         }

     

       96
       96
       +
       

     

       97
       97
       +
         /// Legacy name kept for compatibility: prefer [acquireProvider].

     

       98
       98
       +
         CommentsProvider getProvider({

     

       99
       99
       +
           required String postUri,

     

       100
       100
       +
           required String postCid,

     

       101
       101
       +
         }) => acquireProvider(postUri: postUri, postCid: postCid);

     

       102
       102
       +
       

     

       103
       103
       +
         CommentsProvider _getOrCreateProvider({

     

       104
       104
       +
           required String postUri,

     

       105
       105
       +
           required String postCid,

     

       106
       106
       +
         }) {

     

       107
       107
       +
           // Check if already cached

     

       108
       108
       +
           if (_cache.containsKey(postUri)) {

     

       109
       109
       +
             // Move to end (most recently used)

     

       110
       110
       +
             final provider = _cache.remove(postUri)!;

     

       111
       111
       +
             _cache[postUri] = provider;

     

       112
       112
       +
       

     

       113
       113
       +
             if (kDebugMode) {

     

       114
       114
       +
               debugPrint('📦 Cache hit: $postUri (${_cache.length}/$maxSize)');

     

       115
       115
       +
             }

     

       116
       116
       +
       

     

       117
       117
       +
             return provider;

     

       118
       118
       +
           }

     

       119
       119
       +
       

     

       120
       120
       +
           // Evict unreferenced providers if at capacity.

     

       121
       121
       +
           if (_cache.length >= maxSize) {

     

       122
       122
       +
             _evictIfNeeded(includingOne: true);

     

       123
       123
       +
           }

     

       124
       124
       +
       

     

       125
       125
       +
           // Create new provider

     

       126
       126
       +
           final provider = CommentsProvider(

     

       127
       127
       +
             _authProvider,

     

       128
       128
       +
             voteProvider: _voteProvider,

     

       129
       129
       +
             commentService: _commentService,

     

       130
       130
       +
             postUri: postUri,

     

       131
       131
       +
             postCid: postCid,

     

       132
       132
       +
           );

     

       133
       133
       +
       

     

       134
       134
       +
           _cache[postUri] = provider;

     

       135
       135
       +
       

     

       136
       136
       +
           if (kDebugMode) {

     

       137
       137
       +
             debugPrint('📦 Cache miss: $postUri (${_cache.length}/$maxSize)');

     

       138
       138
       +
             if (_cache.length > maxSize) {

     

       139
       139
       +
               debugPrint(

     

       140
       140
       +
                 '📌 Cache exceeded maxSize because active providers are pinned',

     

       141
       141
       +
               );

     

       142
       142
       +
             }

     

       143
       143
       +
           }

     

       144
       144
       +
       

     

       145
       145
       +
           return provider;

     

       146
       146
       +
         }

     

       147
       147
       +
       

     

       148
       148
       +
         void _evictIfNeeded({bool includingOne = false}) {

     

       149
       149
       +
           final targetSize = includingOne ? maxSize - 1 : maxSize;

     

       150
       150
       +
           while (_cache.length > targetSize) {

     

       151
       151
       +
             String? oldestUnreferencedKey;

     

       152
       152
       +
             for (final key in _cache.keys) {

     

       153
       153
       +
               if ((_refCounts[key] ?? 0) == 0) {

     

       154
       154
       +
                 oldestUnreferencedKey = key;

     

       155
       155
       +
                 break;

     

       156
       156
       +
               }

     

       157
       157
       +
             }

     

       158
       158
       +
       

     

       159
       159
       +
             if (oldestUnreferencedKey == null) {

     

       160
       160
       +
               break;

     

       161
       161
       +
             }

     

       162
       162
       +
       

     

       163
       163
       +
             final evicted = _cache.remove(oldestUnreferencedKey);

     

       164
       164
       +
             evicted?.dispose();

     

       165
       165
       +
       

     

       166
       166
       +
             if (kDebugMode) {

     

       167
       167
       +
               debugPrint('🗑️ Cache evict: $oldestUnreferencedKey');

     

       168
       168
       +
             }

     

       169
       169
       +
           }

     

       170
       170
       +
         }

     

       171
       171
       +
       

     

       172
       172
       +
         /// Check if provider exists without creating

     

       173
       173
       +
         bool hasProvider(String postUri) => _cache.containsKey(postUri);

     

       174
       174
       +
       

     

       175
       175
       +
         /// Get existing provider without creating (for checking state)

     

       176
       176
       +
         CommentsProvider? peekProvider(String postUri) => _cache[postUri];

     

       177
       177
       +
       

     

       178
       178
       +
         /// Remove specific provider (e.g., after post deletion)

     

       179
       179
       +
         void removeProvider(String postUri) {

     

       180
       180
       +
           final provider = _cache.remove(postUri);

     

       181
       181
       +
           _refCounts.remove(postUri);

     

       182
       182
       +
           provider?.dispose();

     

       183
       183
       +
         }

     

       184
       184
       +
       

     

       185
       185
       +
         /// Handle auth state changes - clear all on sign-out

     

       186
       186
       +
         void _onAuthChanged() {

     

       187
       187
       +
           final isAuthenticated = _authProvider.isAuthenticated;

     

       188
       188
       +
       

     

       189
       189
       +
           // Clear all cached providers on sign-out

     

       190
       190
       +
           if (_wasAuthenticated && !isAuthenticated) {

     

       191
       191
       +
             if (kDebugMode) {

     

       192
       192
       +
               debugPrint('🔒 User signed out - clearing ${_cache.length} cached comment providers');

     

       193
       193
       +
             }

     

       194
       194
       +
             clearAll();

     

       195
       195
       +
           }

     

       196
       196
       +
       

     

       197
       197
       +
           _wasAuthenticated = isAuthenticated;

     

       198
       198
       +
         }

     

       199
       199
       +
       

     

       200
       200
       +
         /// Clear all cached providers

     

       201
       201
       +
         void clearAll() {

     

       202
       202
       +
           for (final provider in _cache.values) {

     

       203
       203
       +
             provider.dispose();

     

       204
       204
       +
           }

     

       205
       205
       +
           _cache.clear();

     

       206
       206
       +
           _refCounts.clear();

     

       207
       207
       +
         }

     

       208
       208
       +
       

     

       209
       209
       +
         /// Current cache size

     

       210
       210
       +
         int get size => _cache.length;

     

       211
       211
       +
       

     

       212
       212
       +
         /// Dispose and cleanup

     

       213
       213
       +
         void dispose() {

     

       214
       214
       +
           _authProvider.removeListener(_onAuthChanged);

     

       215
       215
       +
           clearAll();

     

       216
       216
       +
         }

     

       217
       217
       +
       }